minimize TransformationContext

Author: yaacovCR

cspell.yml

@@ -34,6 +34,8 @@ words:
 
   # TODO: contribute upstream
   - deno
+  - superschema
+  - superschemas
   - subschema
   - subschemas
 

src/transform/addNewLabels.ts

@@ -1,16 +1,19 @@
 import type {
   ArgumentNode,
   DirectiveNode,
+  OperationDefinitionNode,
   SelectionNode,
   SelectionSetNode,
-  ValidatedExecutionArgs,
 } from 'graphql';
 import { GraphQLDeferDirective, GraphQLStreamDirective } from 'graphql';
 // eslint-disable-next-line n/no-missing-import
+import type { FragmentDetails } from 'graphql/execution/collectFields.js';
+// eslint-disable-next-line n/no-missing-import
 import { Kind } from 'graphql/language/kinds.js';
 
 import { invariant } from '../jsutils/invariant.js';
 import { mapValue } from '../jsutils/mapValue.js';
+import type { ObjMap } from '../jsutils/ObjMap.js';
 
 interface AddNewLabelsContext {
   prefix: string;
@@ -19,14 +22,14 @@ interface AddNewLabelsContext {
 }
 
 export function addNewLabels(
+  operation: OperationDefinitionNode,
+  fragments: ObjMap<FragmentDetails>,
   prefix: string,
-  originalArgs: ValidatedExecutionArgs,
 ): {
-  argsWithNewLabels: ValidatedExecutionArgs;
+  operation: OperationDefinitionNode;
+  fragments: ObjMap<FragmentDetails>;
   originalLabels: Map<string, string | undefined>;
 } {
-  const { operation, fragments } = originalArgs;
-
   const context: AddNewLabelsContext = {
     prefix,
     incrementalCounter: 0,
@@ -44,21 +47,12 @@ export function addNewLabels(
     },
   }));
 
-  const argsWithNewLabels: ValidatedExecutionArgs = {
-    ...originalArgs,
+  return {
     operation: {
       ...operation,
       selectionSet: transformSelectionSet(context, operation.selectionSet),
     },
-    fragmentDefinitions: mapValue(
-      transformedFragments,
-      ({ definition }) => definition,
-    ),
     fragments: transformedFragments,
-  };
-
-  return {
-    argsWithNewLabels,
     originalLabels: context.originalLabels,
   };
 }

src/transform/buildTransformationContext.ts

@@ -4,12 +4,16 @@ import type {
   GraphQLField,
   GraphQLLeafType,
   GraphQLSchema,
+  OperationDefinitionNode,
   ValidatedExecutionArgs,
 } from 'graphql';
 import type {
+  FragmentDetails,
   GroupedFieldSet,
   // eslint-disable-next-line n/no-missing-import
 } from 'graphql/execution/collectFields.js';
+// eslint-disable-next-line n/no-missing-import
+import type { VariableValues } from 'graphql/execution/values.js';
 
 import { keyMap } from '../jsutils/keyMap.js';
 import type { ObjMap } from '../jsutils/ObjMap.js';
@@ -55,8 +59,12 @@ export interface PathSegmentNode {
 }
 
 export interface TransformationContext {
+  superschema: GraphQLSchema;
   subschemas: ObjMap<SubschemaConfig>;
-  argsWithNewLabels: ValidatedExecutionArgs;
+  operation: OperationDefinitionNode;
+  fragments: ObjMap<FragmentDetails>;
+  variableValues: VariableValues;
+  hideSuggestions: boolean;
   originalLabels: Map<string, string | undefined>;
   pathSegmentRootNode: PathSegmentNode;
   objectFieldTransformers: ObjectFieldTransformers;
@@ -82,20 +90,28 @@ export function buildTransformationContext(
   executionPlanBuilder: ExecutionPlanBuilder,
   prefix: string,
 ): TransformationContext {
-  const { argsWithNewLabels, originalLabels } = addNewLabels(
-    prefix,
-    originalArgs,
-  );
+  const { operation, fragments } = originalArgs;
+  const {
+    operation: operationWithNewLabels,
+    fragments: fragmentsWithNewLabels,
+    originalLabels,
+  } = addNewLabels(operation, fragments, prefix);
 
   const {
     objectFieldTransformers = {},
     pathScopedFieldTransformers = {},
     leafTransformers = {},
   } = transformers;
 
+  const { variableValues, hideSuggestions } = originalArgs;
+
   return {
+    superschema: originalArgs.schema,
     subschemas: keyMap(subschemas, (subschema) => subschema.label),
-    argsWithNewLabels,
+    operation: operationWithNewLabels,
+    fragments: fragmentsWithNewLabels,
+    variableValues,
+    hideSuggestions,
     originalLabels,
     objectFieldTransformers,
     pathSegmentRootNode: buildPathSegmentTree(pathScopedFieldTransformers),

src/transform/completeValue.ts

@@ -7,7 +7,6 @@ import type {
   GraphQLObjectType,
   GraphQLOutputType,
   OperationDefinitionNode,
-  ValidatedExecutionArgs,
 } from 'graphql';
 import {
   getDirectiveValues,
@@ -80,14 +79,13 @@ interface StreamUsage {
 
 const collectSubfields = memoize3(
   (
-    validatedExecutionArgs: ValidatedExecutionArgs,
+    context: TransformationContext,
     returnType: GraphQLObjectType,
     fieldDetailsList: ReadonlyArray<FieldDetails>,
   ) => {
-    const { schema, fragments, variableValues, hideSuggestions } =
-      validatedExecutionArgs;
+    const { superschema, fragments, variableValues, hideSuggestions } = context;
     return _collectSubfields(
-      schema,
+      superschema,
       fragments,
       variableValues,
       returnType,
@@ -118,14 +116,14 @@ export function completeInitialResult(
     incrementalDataRecords: [],
   };
 
-  const { schema, variableValues, hideSuggestions } = context.argsWithNewLabels;
+  const { superschema, variableValues, hideSuggestions } = context;
 
-  const rootType = schema.getRootType(operation.operation);
+  const rootType = superschema.getRootType(operation.operation);
   invariant(rootType != null);
 
   const { groupedFieldSet: originalGroupedFieldSet, newDeferUsages } =
     collectFields(
-      schema,
+      superschema,
       fragments,
       variableValues,
       rootType,
@@ -261,7 +259,7 @@ function completeValue(
 
   invariant(isObjectLike(result));
 
-  const { prefix, argsWithNewLabels } = context;
+  const { prefix, superschema } = context;
 
   const typeName = result[prefix];
 
@@ -271,12 +269,12 @@ function completeValue(
 
   invariant(typeof typeName === 'string');
 
-  const runtimeType = argsWithNewLabels.schema.getType(typeName);
+  const runtimeType = superschema.getType(typeName);
 
   invariant(isObjectType(runtimeType));
 
   const { groupedFieldSet: originalGroupedFieldSet, newDeferUsages } =
-    collectSubfields(argsWithNewLabels, runtimeType, fieldDetailsList);
+    collectSubfields(context, runtimeType, fieldDetailsList);
 
   const { groupedFieldSet, newGroupedFieldSets } = buildSubExecutionPlan(
     context,
@@ -373,9 +371,7 @@ function completeObjectValue(
   incrementalContext: IncrementalContext,
   deferMap: ReadonlyMap<DeferUsage, DeferredFragment> | undefined,
 ): ObjMap<unknown> {
-  const {
-    argsWithNewLabels: { schema },
-  } = context;
+  const superschema = context.superschema;
   const completedObject = Object.create(null);
 
   const objectFieldTransformers =
@@ -386,7 +382,7 @@ function completeObjectValue(
       continue;
     }
     const fieldName = fieldDetailsList[0].node.name.value;
-    const fieldDef = schema.getField(runtimeType, fieldName);
+    const fieldDef = superschema.getField(runtimeType, fieldName);
 
     if (fieldDef) {
       const fieldType = fieldDef.type;
@@ -719,7 +715,7 @@ function getStreamUsage(
   const stream = getDirectiveValues(
     GraphQLStreamDirective,
     fieldDetails.node,
-    context.argsWithNewLabels.variableValues,
+    context.variableValues,
     fieldDetails.fragmentVariableValues,
   );
 

src/transform/transform.ts

@@ -103,8 +103,6 @@ export function transform(
     prefix,
   );
 
-  const argsWithNewLabels = context.argsWithNewLabels;
-
   const withExecutors: Array<{
     subschemaConfig: SubschemaConfig;
     operation: OperationDefinitionNode;
@@ -121,7 +119,7 @@ export function transform(
       },
     },
   )) {
-    const { operation, fragments } = argsWithNewLabels;
+    const { operation, fragments } = context;
     const subschema = subschemaConfig.schema;
     const transformedForSubschema = transformForTargetSubschema(
       operation,
@@ -153,7 +151,7 @@ export function transform(
       fragments: transformedFragments,
       executor: () =>
         executor({
-          ...argsWithNewLabels,
+          ...originalArgs,
           schema: subschema,
           operation: transformedOperation,
           fragments: transformedFragments,