Model's remote method with input works on rest but not graphql

[meepeek]

This is my SystemUser.js model look like

'use strict';

module.exports = function(Systemuser) {

  Systemuser.test = function(msg, cb) {
    console.log(msg,cb)
    cb(null, 'test ' + msg)
  }
  Systemuser.remoteMethod('test', {
          accepts: {arg: 'msg', type: 'string'},
          returns: {arg: 'test', type: 'string'}
    });

};

calling with rest is perfectly fine but with this graphiql mutation

mutation {
  SystemUserTest(input:{msg:"test"}) {
    obj
    clientMutationId
  }
}

result is as follow

{
  "data": {
    "SystemUserTest": null
  },
  "errors": [
    {
      "message": "cb is not a function",
      "locations": [
        {
          "line": 2,
          "column": 3
        }
      ],
      "path": [
        "SystemUserTest"
      ]
    }
  ]
}

I console.log the cb as I called graphiql query, the result is an accessToken object, instead of callback function.

{ accessToken: { ttl: 1209600,
created: 2018-08-12T16:51:53.682Z,
userId: 5b7045af20ab2b6477ff819a,
id: 'yU5r8BpJhXdSk1x0ey50M3wFzG7Urix9rhMrTxN1LcqEYJaYy1R3anWtp1BLVz6d' } }

How do I return value in remote method to make it works with graphql ?

[meepeek]

I have read the issue #1 and try with the following code

'use strict';

module.exports = function(Systemuser) {

  Systemuser.test = function(msg) {
    return new Promise((resolve, reject) => {
        resolve(msg)
    })
  }
  Systemuser.remoteMethod('test', {
          accepts: {arg: 'msg', type: 'string'},
          returns: {arg: 'test', type: 'string'}
    });

};

mutation {
  SystemUserTest(input:{msg:"aaa"}) {
    obj
    clientMutationId
  }
}

{
  "data": {
    "SystemUserTest": null
  },
  "errors": [
    {
      "message": "Cannot create property 'clientMutationId' on string 'aaa'",
      "locations": [
        {
          "line": 2,
          "column": 3
        }
      ],
      "path": [
        "SystemUserTest"
      ]
    }
  ]
}

Still stuck with the problem. Please help.

[yahoohung]

Systemuser.test = function(msg, cb) Marshall

…

On 17 Aug 2018, at 1:26 PM, Thee, Meepeek ***@***.***> wrote: I have read the issue #1 and try with the following code 'use strict'; module.exports = function(Systemuser) { Systemuser.test = function(msg) { return new Promise((resolve, reject) => { resolve(msg) }) } Systemuser.remoteMethod('test', { accepts: {arg: 'msg', type: 'string'}, returns: {arg: 'test', type: 'string'} }); }; mutation { SystemUserTest(input:{msg:"aaa"}) { obj clientMutationId } } { "data": { "SystemUserTest": null }, "errors": [ { "message": "Cannot create property 'clientMutationId' on string 'aaa'", "locations": [ { "line": 2, "column": 3 } ], "path": [ "SystemUserTest" ] } ] } Still stuck with the problem. Please help. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[yahoohung]

Systemuser.test = function(msg, cb) { return new Promise((resolve, reject) => { resolve(msg) }) } Marshall

…

On 17 Aug 2018, at 1:26 PM, Thee, Meepeek ***@***.***> wrote: Systemuser.test = function(msg) { return new Promise((resolve, reject) => { resolve(msg) }) }

[lane-tang]

is it ok, if i use async/await for remote method?

[devpascoe]

Getting the same issue here with my Remote Methods. REST working fine, when hit with GraphQL query first param is undefined, second param is { accesstoken: undefined }.

Happens on a simple GET / Query and same result depending if server function is async or using callback.

Anonymous endpoint also.

[devpascoe]

@yahoohung where might be a good place to look to fix this parameter issue for Remote Methods?

[devpascoe]

I think maybe this line in getRemoteMethodQueries is something to consider.
let wrap = promisify(model[method.name](params.length > 1 ? _.merge(...params) : params[0], ctxOptions));
In debugger my remote method has params that = an empty array so wrap is undefined because params[0] of an empty array is undefined.

hmmm, need to test with more scenarios. Built in methods as well as custom remote methods.

[devpascoe]

Also, are Remote Methods only supported in this library by promises being returned? Or are callbacks allowed too?