Merge pull request #2798 from mohamed-hendawy/fix-can-create

yajra · web-flow · commit 40fd207aa91f · 2022-06-21T21:13:13.000+08:00
[10.x] Make canCreate at QueryDataTable accept QueryBuilder only
diff --git a/src/QueryDataTable.php b/src/QueryDataTable.php
@@ -82,7 +82,7 @@ public function getConnection(): Connection
      */
     public static function canCreate($source): bool
     {
-        return $source instanceof QueryBuilder;
+        return $source instanceof QueryBuilder && ! ($source instanceof EloquentBuilder);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ public function getConnection(): Connection`
`82`	`82`	`*/`
`83`	`83`	`public static function canCreate($source): bool`
`84`	`84`	`{`
`85`		`- return $source instanceof QueryBuilder;`
	`85`	`+ return $source instanceof QueryBuilder && ! ($source instanceof EloquentBuilder);`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`/**`