Skip to content

Commit 4af0d08

Browse files
committed
Clean to reduce code duplication
1 parent e93cce8 commit 4af0d08

File tree

1 file changed

+11
-13
lines changed

1 file changed

+11
-13
lines changed

tests/Integration/CustomOrderTest.php

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -15,21 +15,12 @@ class CustomOrderTest extends TestCase
1515
public function it_can_order_with_custom_order()
1616
{
1717
$response = $this->getJsonResponse([
18-
'order' => [
18+
'order' => [
1919
[
2020
'column' => 0,
2121
'dir' => 'asc',
2222
],
2323
],
24-
'length' => 10,
25-
'start' => 0,
26-
'draw' => 1,
27-
]);
28-
29-
$response->assertJson([
30-
'draw' => 1,
31-
'recordsTotal' => 60,
32-
'recordsFiltered' => 60,
3324
]);
3425

3526
$this->assertEquals(
@@ -43,12 +34,18 @@ protected function getJsonResponse(array $params = [])
4334
$data = [
4435
'columns' => [
4536
['data' => 'user.id', 'name' => 'user.id', 'searchable' => 'true', 'orderable' => 'true'],
46-
['data' => 'user.email', 'name' => 'user.email', 'searchable' => 'true', 'orderable' => 'true'],
4737
['data' => 'title', 'name' => 'posts.title', 'searchable' => 'true', 'orderable' => 'true'],
4838
],
39+
'length' => 10,
40+
'start' => 0,
41+
'draw' => 1,
4942
];
5043

51-
return $this->call('GET', '/relations/belongsTo', array_merge($data, $params));
44+
return $this->call(
45+
'GET',
46+
'/relations/belongsTo',
47+
array_merge($data, $params)
48+
);
5249
}
5350

5451
protected function setUp(): void
@@ -59,7 +56,8 @@ protected function setUp(): void
5956
return $datatables->eloquent(Post::with('user')->select('posts.*'))
6057
->orderColumn('user.id', function ($query, $order) {
6158
$query->orderBy('users.id', $order == 'desc' ? 'asc' : 'desc');
62-
})->toJson();
59+
})
60+
->toJson();
6361
});
6462
}
6563
}

0 commit comments

Comments
 (0)