Merge pull request #2806 from yajra/fix-2793

[10.x] Fix null recordsFiltered on empty collection

Author: yajra

src/DataTableAbstract.php

@@ -869,7 +869,7 @@ protected function render(array $data): JsonResponse
         $output = $this->attachAppends([
             'draw' => $this->request->draw(),
             'recordsTotal' => $this->totalRecords,
-            'recordsFiltered' => $this->filteredRecords,
+            'recordsFiltered' => $this->filteredRecords ?? 0,
             'data' => $data,
         ]);
 

tests/Integration/CollectionDataTableTest.php

@@ -25,6 +25,19 @@ public function it_returns_all_records_when_no_parameters_is_passed()
         ]);
     }
 
+    /** @test */
+    public function it_returns_zero_filtered_records_on_empty_collection()
+    {
+        $crawler = $this->call('GET', '/collection/empty');
+        $crawler->assertExactJson([
+            "data" => [],
+            "draw" => 0,
+            "input" => [],
+            'recordsTotal'    => 0,
+            'recordsFiltered' => 0,
+        ]);
+    }
+
     /** @test */
     public function it_can_perform_global_search()
     {
@@ -242,5 +255,9 @@ protected function setUp(): void
         $this->app['router']->get('/collection/users', function (DataTables $datatables) {
             return $datatables->collection(User::all())->toJson();
         });
+
+        $this->app['router']->get('/collection/empty', function (DataTables $datatables) {
+            return $datatables->collection([])->toJson();
+        });
     }
 }