Skip to content

Commit a651324

Browse files
yakovypgyakovypg
committed
Rename ParseKnownArgs to ParseKnownArguments 
1 parent 6e1e5e1 commit a651324

File tree

3 files changed

+21
-21
lines changed

3 files changed

+21
-21
lines changed

‎Core/NetArgumentParser/src/ArgumentParser.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ public OptionGroup<ICommonOption> AddOptionGroup(string name)
104104

105105
#region Parsing Methods
106106

107-
public virtual void ParseKnownArgs(IEnumerable<string> arguments, out List<string> extraArguments)
107+
public virtual void ParseKnownArguments(IEnumerable<string> arguments, out List<string> extraArguments)
108108
{
109109
ArgumentNullException.ThrowIfNull(arguments, nameof(arguments));
110110

@@ -151,7 +151,7 @@ public void Parse(IEnumerable<string> arguments)
151151
{
152152
ArgumentNullException.ThrowIfNull(arguments, nameof(arguments));
153153

154-
ParseKnownArgs(arguments, out List<string> extraArguments);
154+
ParseKnownArguments(arguments, out List<string> extraArguments);
155155

156156
if (extraArguments?.Count > 0)
157157
throw new ArgumentsAreUnknownException(null, [..extraArguments]);

‎Examples/NetArgumentParser.Examples.AllUseCases/src/Program.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@
123123

124124
try
125125
{
126-
parser.ParseKnownArgs(args, out extraArguments);
126+
parser.ParseKnownArguments(args, out extraArguments);
127127
}
128128
catch (Exception ex)
129129
{

‎Tests/NetArgumentParser.Tests/src/ArgumentParserTests.cs‎

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public void Parse_FlagOptions_OptionsHandledCorrectly()
5151
};
5252

5353
parser.AddOptions(options);
54-
parser.ParseKnownArgs(arguments, out List<string> extraArguments);
54+
parser.ParseKnownArguments(arguments, out List<string> extraArguments);
5555

5656
Assert.True(savaLog);
5757
Assert.True(autoRotate);
@@ -93,7 +93,7 @@ public void Parse_EnumValueOptions_OptionsHandledCorrectly()
9393
};
9494

9595
parser.AddOptions(options);
96-
parser.ParseKnownArgs(arguments, out List<string> extraArguments);
96+
parser.ParseKnownArguments(arguments, out List<string> extraArguments);
9797

9898
Assert.Equal(StringSplitOptions.RemoveEmptyEntries, splitOption);
9999
Assert.Equal(BindMode.OneWayToSource, bindMode);
@@ -180,7 +180,7 @@ public void Parse_ValueOptions_OptionsHandledCorrectly()
180180
};
181181

182182
parser.AddOptions(options);
183-
parser.ParseKnownArgs(arguments, out List<string> extraArguments);
183+
parser.ParseKnownArguments(arguments, out List<string> extraArguments);
184184

185185
Assert.Equal(bool.Parse(boolValue), recievedBool);
186186
Assert.Equal(byte.Parse(byteValue), recievedByte);
@@ -251,7 +251,7 @@ public void Parse_MultipleValueOptions_OptionsHandledCorrectly()
251251
};
252252

253253
parser.AddOptions(options);
254-
parser.ParseKnownArgs(arguments, out List<string> extraArguments);
254+
parser.ParseKnownArguments(arguments, out List<string> extraArguments);
255255

256256
var expectedMargin = new Margin(
257257
int.Parse(leftMargin),
@@ -332,7 +332,7 @@ public void Parse_ValueOptions_SpecialConverterApplied()
332332
parser.AddOptions(options);
333333
parser.AddConverters(converters);
334334

335-
parser.ParseKnownArgs(arguments, out List<string> extraArguments);
335+
parser.ParseKnownArguments(arguments, out List<string> extraArguments);
336336

337337
var expectedMargin = new Margin(
338338
leftMargin,
@@ -402,7 +402,7 @@ public void Parse_ValueOptions_DefaultValueApplied()
402402
};
403403

404404
parser.AddOptions(options);
405-
parser.ParseKnownArgs(arguments, out List<string> extraArguments);
405+
parser.ParseKnownArguments(arguments, out List<string> extraArguments);
406406

407407
Assert.Equal(expectedAngle, angle);
408408
Assert.Equal(expectedWidth, width);
@@ -545,7 +545,7 @@ public void Parse_MinusBasedOptions_ExtraArgumentsExtracted()
545545
};
546546

547547
parser.AddOptions(options);
548-
parser.ParseKnownArgs(arguments, out List<string> extraArguments);
548+
parser.ParseKnownArguments(arguments, out List<string> extraArguments);
549549

550550
VerifyExtraArguments(expectedExtraArguments, extraArguments);
551551
}
@@ -606,7 +606,7 @@ public void Parse_SlashBasedOptions_ExtraArgumentsExtracted()
606606
};
607607

608608
parser.AddOptions(options);
609-
parser.ParseKnownArgs(arguments, out List<string> extraArguments);
609+
parser.ParseKnownArguments(arguments, out List<string> extraArguments);
610610

611611
VerifyExtraArguments(expectedExtraArguments, extraArguments);
612612
}
@@ -668,7 +668,7 @@ public void Parse_SlashBasedOptionsDisabled_SlashBasedOptionsNotRecognized()
668668
};
669669

670670
parser.AddOptions(options);
671-
parser.ParseKnownArgs(arguments, out List<string> extraArguments);
671+
parser.ParseKnownArguments(arguments, out List<string> extraArguments);
672672

673673
Assert.Equal(default, saveLog);
674674
Assert.Equal(default, width);
@@ -733,7 +733,7 @@ public void Parse_SlashBasedOptionsEnabled_SlashBasedOptionsRecognized()
733733
};
734734

735735
parser.AddOptions(options);
736-
parser.ParseKnownArgs(arguments, out List<string> extraArguments);
736+
parser.ParseKnownArguments(arguments, out List<string> extraArguments);
737737

738738
Assert.True(saveLog);
739739
Assert.Equal(expectedWidth, width);
@@ -778,7 +778,7 @@ public void Parse_CompoundOptionsDisabled_OptionsNotExpanded()
778778
};
779779

780780
parser.AddOptions(options);
781-
parser.ParseKnownArgs(arguments, out List<string> extraArguments);
781+
parser.ParseKnownArguments(arguments, out List<string> extraArguments);
782782

783783
Assert.True(a);
784784
Assert.True(abc);
@@ -817,7 +817,7 @@ public void Parse_CompoundOptionsEnabled_OptionsExpanded()
817817
};
818818

819819
parser.AddOptions(options);
820-
parser.ParseKnownArgs(arguments, out List<string> extraArguments);
820+
parser.ParseKnownArguments(arguments, out List<string> extraArguments);
821821

822822
Assert.True(a);
823823
Assert.True(b);
@@ -858,7 +858,7 @@ public void Parse_NotSkipFirstArguments_ArgumentsNotSkipped()
858858
};
859859

860860
parser.AddOptions(options);
861-
parser.ParseKnownArgs(arguments, out List<string> extraArguments);
861+
parser.ParseKnownArguments(arguments, out List<string> extraArguments);
862862

863863
Assert.True(a);
864864
Assert.True(b);
@@ -899,7 +899,7 @@ public void Parse_SkipFewFirstArguments_ArgumentsSkipped()
899899
};
900900

901901
parser.AddOptions(options);
902-
parser.ParseKnownArgs(arguments, out List<string> extraArguments);
902+
parser.ParseKnownArguments(arguments, out List<string> extraArguments);
903903

904904
Assert.False(a);
905905
Assert.False(b);
@@ -964,7 +964,7 @@ public void Parse_OptionsWithEqualSign_HandledCorrectly()
964964
};
965965

966966
parser.AddOptions(options);
967-
parser.ParseKnownArgs(arguments, out List<string> extraArguments);
967+
parser.ParseKnownArguments(arguments, out List<string> extraArguments);
968968

969969
Assert.Equal(expectedAngle, angle);
970970
Assert.Equal(expectedWidth, width);
@@ -1020,7 +1020,7 @@ public void Parse_HelpOption_OtherArgumentsSkipped()
10201020
};
10211021

10221022
parser.AddOptions(options);
1023-
parser.ParseKnownArgs(arguments, out List<string> extraArguments);
1023+
parser.ParseKnownArguments(arguments, out List<string> extraArguments);
10241024

10251025
Assert.True(help);
10261026

@@ -1078,7 +1078,7 @@ public void Parse_VersionOption_OtherArgumentsSkipped()
10781078
};
10791079

10801080
parser.AddOptions(options);
1081-
parser.ParseKnownArgs(arguments, out List<string> extraArguments);
1081+
parser.ParseKnownArguments(arguments, out List<string> extraArguments);
10821082

10831083
Assert.True(version);
10841084

@@ -1273,7 +1273,7 @@ public void Parse_SeveralUseCases_ArgumentsParsedCorrectly()
12731273
parser.AddOptions(options);
12741274
parser.AddConverters(converters);
12751275

1276-
parser.ParseKnownArgs(arguments, out List<string> extraArguments);
1276+
parser.ParseKnownArguments(arguments, out List<string> extraArguments);
12771277

12781278
Assert.True(saveLog);
12791279
Assert.True(autoRotate);

0 commit comments

Comments
 (0)