setup_default_stack_size: set __default_stacksize unconditionally (WebAssembly#396)

yamt · web-flow · commit b67d6b261db9 · 2023-02-22T07:02:50.000-08:00
If a user specifies a small stack size for the main,
maybe it's reasonable to use the same size for threads as well.
diff --git a/libc-top-half/musl/src/env/__init_tls.c b/libc-top-half/musl/src/env/__init_tls.c
@@ -47,10 +47,9 @@ static inline void setup_default_stack_size()
 		stack_size = sp > &__global_base ? &__heap_base - &__data_end : (ptrdiff_t)&__global_base;
 	}
 
-	if (stack_size > __default_stacksize)
-		__default_stacksize =
-			stack_size < DEFAULT_STACK_MAX ?
-			stack_size : DEFAULT_STACK_MAX;
+	__default_stacksize =
+		stack_size < DEFAULT_STACK_MAX ?
+		stack_size : DEFAULT_STACK_MAX;
 }
 
 void __wasi_init_tp() {

Original file line number	Diff line number	Diff line change
`@@ -47,10 +47,9 @@ static inline void setup_default_stack_size()`
`47`	`47`	`stack_size = sp > &__global_base ? &__heap_base - &__data_end : (ptrdiff_t)&__global_base;`
`48`	`48`	`}`
`49`	`49`
`50`		`- if (stack_size > __default_stacksize)`
`51`		`- __default_stacksize =`
`52`		`- stack_size < DEFAULT_STACK_MAX ?`
`53`		`- stack_size : DEFAULT_STACK_MAX;`
	`50`	`+ __default_stacksize =`
	`51`	`+ stack_size < DEFAULT_STACK_MAX ?`
	`52`	`+ stack_size : DEFAULT_STACK_MAX;`
`54`	`53`	`}`
`55`	`54`
`56`	`55`	`void __wasi_init_tp() {`