Merge rust-bitcoin#3623: backport: Deprecate Amount::fmt_value_in

107acf3 backport: Deprecate Amount::fmt_value_in (Tobin C. Harding)

Pull request description:

  We an use `Amount::display_in` now, this was done on master in PR rust-bitcoin#2951.

ACKs for top commit:
  shinghim:
    ACK 107acf3
  apoelstra:
    ACK 107acf3; successfully ran local tests

Tree-SHA512: b46156415a281caad5cd3238921f70dd8f575d700b901583fcdd9e037f51dab348d44efb1a74b385252a37d677d7fd7369ec7b623b680585a9427f1d1c448fb0

Author: apoelstra

units/src/amount.rs

@@ -987,6 +987,7 @@ impl Amount {
     ///
     /// Does not include the denomination.
     #[rustfmt::skip]
+    #[deprecated(since = "0.1.3", note = "use `display_in()` instead")]
     pub fn fmt_value_in(self, f: &mut dyn fmt::Write, denom: Denomination) -> fmt::Result {
         fmt_satoshi_in(self.to_sat(), false, f, denom, false, FormatOptions::default())
     }
@@ -995,20 +996,13 @@ impl Amount {
     ///
     /// Does not include the denomination.
     #[cfg(feature = "alloc")]
-    pub fn to_string_in(self, denom: Denomination) -> String {
-        let mut buf = String::new();
-        self.fmt_value_in(&mut buf, denom).unwrap();
-        buf
-    }
+    pub fn to_string_in(self, denom: Denomination) -> String { self.display_in(denom).to_string() }
 
     /// Get a formatted string of this [Amount] in the given denomination,
     /// suffixed with the abbreviation for the denomination.
     #[cfg(feature = "alloc")]
     pub fn to_string_with_denomination(self, denom: Denomination) -> String {
-        let mut buf = String::new();
-        self.fmt_value_in(&mut buf, denom).unwrap();
-        write!(buf, " {}", denom).unwrap();
-        buf
+        self.display_in(denom).show_denomination().to_string()
     }
 
     // Some arithmetic that doesn't fit in `core::ops` traits.