Skip to content

Commit e1302a1

Browse files
committed
Log conflicts with inode ID
1 parent b00985d commit e1302a1

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

internal/file.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1336,7 +1336,7 @@ func (inode *Inode) SendUpload() bool {
13361336
err = nil
13371337
notFoundIgnore = true
13381338
} else if mappedErr == fuse.ENOENT || mappedErr == syscall.ERANGE {
1339-
s3Log.Warnf("Conflict detected: failed to copy %v to %v: %v. File is removed remotely, dropping cache", from, key, err)
1339+
s3Log.Warnf("Conflict detected (inode %v): failed to copy %v to %v: %v. File is removed remotely, dropping cache", inode.Id, from, key, err)
13401340
inode.mu.Lock()
13411341
newParent := inode.Parent
13421342
oldParent := inode.oldParent
@@ -1482,7 +1482,7 @@ func (inode *Inode) SendUpload() bool {
14821482
inode.userMetadataDirty = 2
14831483
if mappedErr == fuse.ENOENT || mappedErr == syscall.ERANGE {
14841484
// Object is deleted or resized remotely (416). Discard local version
1485-
log.Warnf("Conflict detected: File %v is deleted or resized remotely, discarding local changes", inode.FullName())
1485+
s3Log.Warnf("Conflict detected (inode %v): File %v is deleted or resized remotely, discarding local changes", inode.Id, inode.FullName())
14861486
inode.resetCache()
14871487
}
14881488
log.Errorf("Error flushing metadata using COPY for %v: %v", key, err)
@@ -1726,7 +1726,7 @@ func (inode *Inode) FlushSmallObject() {
17261726
mappedErr := mapAwsError(err)
17271727
if mappedErr == fuse.ENOENT || mappedErr == syscall.ERANGE {
17281728
// Object is deleted or resized remotely (416). Discard local version
1729-
log.Warnf("Conflict detected: File %v is deleted or resized remotely, discarding local changes", inode.FullName())
1729+
s3Log.Warnf("Conflict detected (inode %v): File %v is deleted or resized remotely, discarding local changes", inode.Id, inode.FullName())
17301730
inode.resetCache()
17311731
inode.IsFlushing -= inode.fs.flags.MaxParallelParts
17321732
atomic.AddInt64(&inode.fs.activeFlushers, -1)
@@ -1780,7 +1780,7 @@ func (inode *Inode) FlushSmallObject() {
17801780
inode.userMetadataDirty = 2
17811781
}
17821782
} else {
1783-
log.Debugf("Flushed small file %v: etag=%v, size=%v", key, NilStr(resp.ETag), sz)
1783+
log.Debugf("Flushed small file %v (inode %v): etag=%v, size=%v", key, inode.Id, NilStr(resp.ETag), sz)
17841784
stillDirty := inode.userMetadataDirty != 0 || inode.oldParent != nil
17851785
for i := 0; i < len(inode.buffers); i++ {
17861786
b := inode.buffers[i]
@@ -1924,7 +1924,7 @@ func (inode *Inode) FlushPart(part uint64) {
19241924
mappedErr := mapAwsError(err)
19251925
if mappedErr == fuse.ENOENT || mappedErr == syscall.ERANGE {
19261926
// Object is deleted or resized remotely (416). Discard local version
1927-
log.Warnf("Conflict detected: File %v is deleted or resized remotely, discarding local changes", inode.FullName())
1927+
s3Log.Warnf("Conflict detected (inode %v): File %v is deleted or resized remotely, discarding local changes", inode.Id, inode.FullName())
19281928
inode.resetCache()
19291929
return
19301930
}
@@ -2008,7 +2008,7 @@ func (inode *Inode) completeMultipart() {
20082008
mappedErr := mapAwsError(err)
20092009
if mappedErr == fuse.ENOENT || mappedErr == syscall.ERANGE {
20102010
// Object is deleted or resized remotely (416). Discard local version
2011-
log.Warnf("Conflict detected: File %v is deleted or resized remotely, discarding local changes", inode.FullName())
2011+
s3Log.Warnf("Conflict detected (inode %v): File %v is deleted or resized remotely, discarding local changes", inode.Id, inode.FullName())
20122012
inode.resetCache()
20132013
return
20142014
}

internal/handles.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,9 +204,9 @@ func (inode *Inode) SetFromBlobItem(item *BlobItemOutput) {
204204
// Otherwise we may not be able to make a correct object version
205205
if item.ETag != nil && inode.knownETag != *item.ETag || item.Size != inode.knownSize {
206206
if inode.CacheState != ST_CACHED && (inode.knownETag != "" || inode.knownSize > 0) {
207-
s3Log.Warnf("Conflict detected: server-side ETag or size of %v"+
207+
s3Log.Warnf("Conflict detected (inode %v): server-side ETag or size of %v"+
208208
" (%v, %v) differs from local (%v, %v). File is changed remotely, dropping cache",
209-
inode.FullName(), NilStr(item.ETag), item.Size, inode.knownETag, inode.knownSize)
209+
inode.Id, inode.FullName(), NilStr(item.ETag), item.Size, inode.knownETag, inode.knownSize)
210210
}
211211
inode.resetCache()
212212
inode.ResizeUnlocked(item.Size, false, false)

0 commit comments

Comments
 (0)