Skip to content

Commit e89933d

Browse files
kltsvaNOOBisTheGod
authored and
robot-piglet
committed
Checks for 3.35.7 and 3.38.4
1. Add CI checks for Flutter version 3.35.7 and 3.38.4 2. Update yx_scope_linter dependencies, min Dart SDK - 3.6.0 3. Ignore `avoid_types_as_parameter_names` for yx_scope --- I hereby agree to the terms of the CLA available at: <https://yandex.ru/legal/cla/?lang=ru> --- Pull Request resolved: <#30> Co-authored-by: anoobis <anoobis@yandex-team.com> Co-authored-by: anoobis <anoobis@yandex-team.com> Co-authored-by: anoobis <anoobis@yandex-team.com> commit_hash:2b780d7345868c4a2a44d3a650f467ba462dd01e
1 parent a618518 commit e89933d

File tree

7 files changed

+65
-15
lines changed

7 files changed

+65
-15
lines changed

‎.github/workflows/yx_scope_pr.yaml‎

Lines changed: 39 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ jobs:
1515
runs-on: ubuntu-latest
1616

1717
strategy:
18+
fail-fast: false
1819
matrix:
19-
# Check the library against the most recent version and the previous minor version
20-
flutter-version: [3.32.4, 3.29.2, 3.27.1, 3.24.5]
20+
# Check the packages against the most recent previous minor version
21+
flutter-version: [3.38.4, 3.35.7, 3.32.8, 3.29.3, 3.27.3, 3.24.5]
2122
package:
2223
- yx_scope/packages/yx_scope
2324
- yx_scope/packages/yx_scope_flutter
24-
- yx_scope/packages/yx_scope_linter
2525

2626
defaults:
2727
run:
@@ -46,10 +46,42 @@ jobs:
4646
- name: Run linter
4747
run: flutter analyze
4848

49+
- name: Run tests
50+
run: flutter test
51+
52+
ci_checks_linter:
53+
name: CI Checks (Linter)
54+
runs-on: ubuntu-latest
55+
56+
strategy:
57+
fail-fast: false
58+
matrix:
59+
# Check the linter against the most recent previous minor version
60+
dart-version: [3.6.2, 3.7.2, 3.8.1, 3.9.2, 3.10.4]
61+
62+
defaults:
63+
run:
64+
working-directory: yx_scope/packages/yx_scope_linter
65+
shell: bash
66+
67+
steps:
68+
- name: Checkout code
69+
uses: actions/checkout@v4
70+
71+
- name: Set up Dart SDK
72+
uses: dart-lang/setup-dart@v1
73+
with:
74+
dart-version: ${{ matrix.dart-version }}
75+
76+
- name: Install dependencies
77+
run: dart pub get
78+
79+
- name: Check formatting
80+
run: dart format --set-exit-if-changed .
81+
82+
- name: Run linter
83+
run: dart analyze
84+
4985
- name: Verify custom_lint
5086
working-directory: yx_scope/packages/yx_scope_linter/example
5187
run: dart run custom_lint --watch
52-
53-
- name: Run tests
54-
if: matrix.package != 'yx_scope/packages/yx_scope_linter'
55-
run: flutter test

‎yx_scope/packages/yx_scope/analysis_options.yaml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,5 @@
11
include: package:lints/recommended.yaml
2+
3+
linter:
4+
rules:
5+
avoid_types_as_parameter_names: false

‎yx_scope/packages/yx_scope_flutter/example/pubspec.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ dev_dependencies:
1818
flutter_test:
1919
sdk: flutter
2020
flutter_lints: ^2.0.0
21-
custom_lint: ^0.6.8
22-
yx_scope_linter: ^0.1.0
21+
custom_lint: ^0.7.0
22+
yx_scope_linter: ^0.2.0
2323

2424
flutter:
2525
uses-material-design: true

‎yx_scope/packages/yx_scope_linter/CHANGELOG.md‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
## 0.2.0 - 2025.12.16
2+
3+
* custom_lint ^0.6.8 -> ^0.7.0;
4+
* custom_lint_builder ^0.6.2 -> ^0.7.0;
5+
* analyzer_plugin ^0.11.2 -> ^0.13.4;
6+
* analyzer ^6.4.1 -> ^7.0.0
7+
* min Dart version 2.27.0 -> 3.6.0
8+
19
## 0.1.4 - 2025.07.08
210

311
* Documentation links fixed

‎yx_scope/packages/yx_scope_linter/analysis_options.yaml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,5 @@
11
include: package:lints/recommended.yaml
2+
3+
analyzer:
4+
errors:
5+
deprecated_member_use: ignore

‎yx_scope/packages/yx_scope_linter/example/pubspec.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@ dependencies:
1111

1212
dev_dependencies:
1313
lints: ^2.0.0
14-
custom_lint: ^0.6.8
14+
custom_lint: ^0.7.0
1515
yx_scope_linter:
1616
path: ..

‎yx_scope/packages/yx_scope_linter/pubspec.yaml‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: yx_scope_linter
22
description: A package that contains static analysis rules for yx_scope DI framework
3-
version: 0.1.4
3+
version: 0.2.0
44
repository: https://github.com/yandex/city-services-pub/tree/main/yx_scope/packages/yx_scope_linter
55
issue_tracker: https://github.com/yandex/city-services-pub/issues
66
topics:
@@ -10,13 +10,15 @@ topics:
1010
- dependency-management
1111

1212
environment:
13-
sdk: '>=2.19.6 <4.0.0'
13+
sdk: '>=3.6.0 <4.0.0'
1414

1515
dependencies:
16-
analyzer: ^6.4.1
17-
analyzer_plugin: ^0.11.2
18-
custom_lint_builder: ^0.6.2
16+
analyzer: '>=6.4.1 <8.0.0'
17+
analyzer_plugin: '>=0.11.2 <0.14.0'
18+
custom_lint_builder: '>=0.6.2 <0.8.0'
1919
yx_scope: ^1.1.1
2020

2121
dev_dependencies:
2222
lints: ^2.0.0
23+
# TODO: migrate to analysis_server_plugin — https://github.com/dart-lang/sdk/blob/main/pkg/analysis_server_plugin/doc/writing_a_plugin.md
24+
custom_lint: '>=0.6.8 <0.8.0'

0 commit comments

Comments
 (0)