feat(config): auto-extract and deduplicate named volumes from services and dependencies

Author: yarlson

pkg/config/config.go

@@ -217,6 +217,7 @@ func ParseConfig(data []byte) (*Config, error) {
 
 	validate := validator.New()
 
+	// Register custom validations
 	_ = validate.RegisterValidation("volume_reference", func(fl validator.FieldLevel) bool {
 		value := fl.Field().String()
 		parts := strings.Split(value, ":")
@@ -232,9 +233,66 @@ func ParseConfig(data []byte) (*Config, error) {
 		return nil, fmt.Errorf("validation error: %v", err)
 	}
 
+	// Collect all named volumes from config.Services and config.Dependencies,
+	// plus any that were explicitly listed in config.Volumes, deduplicating them.
+	uniqueVolNames := make(map[string]struct{})
+
+	// First, preserve any volumes already defined in config.Volumes
+	for _, volName := range config.Volumes {
+		uniqueVolNames[volName] = struct{}{}
+	}
+
+	// Check volumes in each service
+	for _, svc := range config.Services {
+		for _, volRef := range svc.Volumes {
+			if volName := extractNamedVolume(volRef); volName != "" {
+				uniqueVolNames[volName] = struct{}{}
+			}
+		}
+	}
+
+	// Check volumes in each dependency
+	for _, dep := range config.Dependencies {
+		for _, volRef := range dep.Volumes {
+			if volName := extractNamedVolume(volRef); volName != "" {
+				uniqueVolNames[volName] = struct{}{}
+			}
+		}
+	}
+
+	// Convert to a sorted slice
+	finalVols := make([]string, 0, len(uniqueVolNames))
+	for name := range uniqueVolNames {
+		finalVols = append(finalVols, name)
+	}
+	sort.Strings(finalVols)
+	config.Volumes = finalVols
+
 	return &config, nil
 }
 
+// extractNamedVolume checks if volRef is in the form "NAME:/some/path"
+// and if NAME starts with a letter. If so, it returns NAME; otherwise "".
+func extractNamedVolume(volRef string) string {
+	parts := strings.SplitN(volRef, ":", 2)
+	if len(parts) < 2 {
+		return ""
+	}
+	namePart := parts[0]
+	if len(namePart) == 0 {
+		return ""
+	}
+
+	// Check if first character is a letter [a-zA-Z].
+	first := namePart[0]
+	if (first >= 'a' && first <= 'z') || (first >= 'A' && first <= 'Z') {
+		return namePart
+	}
+
+	// If it starts with '/', '.', or anything else, we treat it as a path, not a named volume
+	return ""
+}
+
 func (s *Service) Hash() (string, error) {
 	sortedService := s.sortServiceFields()
 	bytes, err := json.Marshal(sortedService)

pkg/config/config_test.go

@@ -341,3 +341,120 @@ dependencies:
 	assert.Equal(suite.T(), "elasticsearch", config.Dependencies[2].Name)
 	assert.Equal(suite.T(), "elasticsearch:latest", config.Dependencies[2].Image)
 }
+
+func (suite *ConfigTestSuite) TestParseConfig_VolumesExtraction() {
+	yamlData := []byte(`
+project:
+  name: "test-project"
+  domain: "example.com"
+  email: "test@example.com"
+
+server:
+  host: "example.com"
+  port: 22
+  user: "user"
+  ssh_key: "~/.ssh/id_rsa"
+
+services:
+  - name: "web"
+    image: "nginx:latest"
+    port: 80
+    routes:
+      - path: "/"
+    volumes:
+      - "my-vol:/app/data"
+      - "/host/data:/container/data"  # not a named volume
+  - name: "worker"
+    image: "golang:latest"
+    routes:
+      - path: "/worker"
+    port: 9000
+    volumes:
+      - "my-other-vol:/srv"
+
+dependencies:
+  - name: "some-db"
+    image: "postgres:15"
+    volumes:
+      - "third-vol:/some/dep/path"
+      - "123bad:/skip"
+      - "logs:/var/log"
+
+volumes:
+  - "predefined-volume"
+`)
+
+	config, err := ParseConfig(yamlData)
+	assert.NoError(suite.T(), err)
+	assert.NotNil(suite.T(), config)
+
+	expected := []string{"logs", "my-other-vol", "my-vol", "predefined-volume", "third-vol"}
+	assert.Equal(suite.T(), expected, config.Volumes)
+}
+
+func (suite *ConfigTestSuite) TestParseConfig_VolumesExtraction_NoNamedVolumes() {
+	yamlData := []byte(`
+project:
+  name: "path-volumes-only"
+  domain: "example.com"
+  email: "test@example.com"
+
+server:
+  host: "example.com"
+  port: 22
+  user: "user"
+  ssh_key: "~/.ssh/id_rsa"
+
+services:
+  - name: "web"
+    image: "nginx:latest"
+    port: 80
+    volumes:
+      - "/absolute/path:/container/path"
+      - "./relative:/opt/app"
+dependencies:
+  - name: "redis"
+    image: "redis:latest"
+    volumes:
+      - "/redis/logs:/var/log/redis"
+      - "./some-local-dir:/data"
+volumes: []
+`)
+
+	config, err := ParseConfig(yamlData)
+	assert.NoError(suite.T(), err)
+	assert.NotNil(suite.T(), config)
+
+	assert.Empty(suite.T(), config.Volumes)
+}
+
+func (suite *ConfigTestSuite) TestParseConfig_VolumesExtraction_DefaultConfigs() {
+	yamlData := []byte(`
+project:
+  name: "default-configs-only"
+  domain: "example.com"
+  email: "test@example.com"
+
+server:
+  host: "example.com"
+  port: 22
+  user: "user"
+  ssh_key: "~/.ssh/id_rsa"
+
+services:
+  - name: "web"
+    image: "nginx:latest"
+    routes:
+      - path: "/"
+    port: 80
+dependencies:
+  - "redis:6"
+`)
+
+	config, err := ParseConfig(yamlData)
+	assert.NoError(suite.T(), err)
+	assert.NotNil(suite.T(), config)
+
+	expected := []string{"redis_data"}
+	assert.Equal(suite.T(), expected, config.Volumes)
+}