refactor: remove AsRef<Path> from functions (#38)

While examining rolldown binary size, I noticed 6 copies of
`pnp::resolve_to_unqualified_via_manifes`.

```
 Lines                  Copies               Function name
  -----                  ------               -------------
    17436 (0.4%,  8.2%)      6 (0.0%,  7.0%)  pnp::resolve_to_unqualified_via_manifes
```

Remove all `AsRef<Path>` to avoid accidental generic instantiation
and code bloat, these functions do not need to be generic anyway.

Author: Boshen

src/lib.rs

@@ -94,13 +94,13 @@ pub fn find_closest_pnp_manifest_path(path: &Path) -> Option<PathBuf> {
     None
 }
 
-pub fn load_pnp_manifest<P: AsRef<Path>>(p: P) -> Result<Manifest, Error> {
-    let manifest_content = std::fs::read_to_string(p.as_ref()).map_err(|err| {
+pub fn load_pnp_manifest(p: &Path) -> Result<Manifest, Error> {
+    let manifest_content = std::fs::read_to_string(p).map_err(|err| {
         Error::FailedManifestHydration(Box::new(FailedManifestHydration {
             message: format!(
                 "We failed to read the content of the manifest.\n\nOriginal error: {err}"
             ),
-            manifest_path: p.as_ref().to_path_buf(),
+            manifest_path: p.to_path_buf(),
         }))
     })?;
 
@@ -117,7 +117,7 @@ pub fn load_pnp_manifest<P: AsRef<Path>>(p: P) -> Result<Manifest, Error> {
         .unwrap_or_default()
         .ok_or_else(|| Error::FailedManifestHydration(Box::new(FailedManifestHydration {
             message: String::from("We failed to locate the PnP data payload inside its manifest file. Did you manually edit the file?"),
-            manifest_path: p.as_ref().to_path_buf(),
+            manifest_path: p.to_path_buf(),
         })))?;
 
     let iter = manifest_content.chars().skip(manifest_match.end());
@@ -142,18 +142,18 @@ pub fn load_pnp_manifest<P: AsRef<Path>>(p: P) -> Result<Manifest, Error> {
     let mut manifest: Manifest = serde_json::from_str(&json_string.to_owned())
         .map_err(|err| Error::FailedManifestHydration(Box::new(FailedManifestHydration {
             message: format!("We failed to parse the PnP data payload as proper JSON; Did you manually edit the file?\n\nOriginal error: {err}"),
-            manifest_path: p.as_ref().to_path_buf(),
+            manifest_path: p.to_path_buf(),
         })))?;
 
-    init_pnp_manifest(&mut manifest, p.as_ref());
+    init_pnp_manifest(&mut manifest, p);
 
     Ok(manifest)
 }
 
-pub fn init_pnp_manifest<P: AsRef<Path>>(manifest: &mut Manifest, p: P) {
-    manifest.manifest_path = p.as_ref().to_path_buf();
+pub fn init_pnp_manifest(manifest: &mut Manifest, p: &Path) {
+    manifest.manifest_path = p.to_path_buf();
 
-    manifest.manifest_dir = p.as_ref().parent().expect("Should have a parent directory").to_owned();
+    manifest.manifest_dir = p.parent().expect("Should have a parent directory").to_owned();
 
     for (name, ranges) in manifest.package_registry_data.iter_mut() {
         for (reference, info) in ranges.iter_mut() {
@@ -187,17 +187,14 @@ pub fn init_pnp_manifest<P: AsRef<Path>>(manifest: &mut Manifest, p: P) {
 }
 
 pub fn find_pnp_manifest(parent: &Path) -> Result<Option<Manifest>, Error> {
-    find_closest_pnp_manifest_path(parent).map_or(Ok(None), |p| Ok(Some(load_pnp_manifest(p)?)))
+    find_closest_pnp_manifest_path(parent).map_or(Ok(None), |p| Ok(Some(load_pnp_manifest(&p)?)))
 }
 
 pub fn is_dependency_tree_root<'a>(manifest: &'a Manifest, locator: &'a PackageLocator) -> bool {
     manifest.dependency_tree_roots.contains(locator)
 }
 
-pub fn find_locator<'a, P: AsRef<Path>>(
-    manifest: &'a Manifest,
-    path: &P,
-) -> Option<&'a PackageLocator> {
+pub fn find_locator<'a>(manifest: &'a Manifest, path: &Path) -> Option<&'a PackageLocator> {
     let rel_path = pathdiff::diff_paths(path, &manifest.manifest_dir)
         .expect("Assertion failed: Provided path should be absolute");
 
@@ -240,14 +237,14 @@ pub fn find_broken_peer_dependencies(
     [].to_vec()
 }
 
-pub fn resolve_to_unqualified_via_manifest<P: AsRef<Path>>(
+pub fn resolve_to_unqualified_via_manifest(
     manifest: &Manifest,
     specifier: &str,
-    parent: P,
+    parent: &Path,
 ) -> Result<Resolution, Error> {
     let (ident, module_path) = parse_bare_identifier(specifier)?;
 
-    if let Some(parent_locator) = find_locator(manifest, &parent) {
+    if let Some(parent_locator) = find_locator(manifest, parent) {
         let parent_pkg = get_package(manifest, parent_locator)?;
 
         let mut reference_or_alias: Option<PackageDependency> = None;
@@ -281,7 +278,7 @@ pub fn resolve_to_unqualified_via_manifest<P: AsRef<Path>>(
                         } else {
                             String::from("")
                         },
-                        issuer_path = parent.as_ref().to_string_lossy(),
+                        issuer_path = parent.to_string_lossy(),
                     )
                 } else {
                     format!(
@@ -293,7 +290,7 @@ pub fn resolve_to_unqualified_via_manifest<P: AsRef<Path>>(
                         } else {
                             String::from("")
                         },
-                        issuer_path = parent.as_ref().to_string_lossy(),
+                        issuer_path = parent.to_string_lossy(),
                     )
                 }
             } else if is_dependency_tree_root(manifest, parent_locator) {
@@ -305,7 +302,7 @@ pub fn resolve_to_unqualified_via_manifest<P: AsRef<Path>>(
                     } else {
                         String::from("")
                     },
-                    issuer_path = parent.as_ref().to_string_lossy(),
+                    issuer_path = parent.to_string_lossy(),
                 )
             } else {
                 format!(
@@ -318,7 +315,7 @@ pub fn resolve_to_unqualified_via_manifest<P: AsRef<Path>>(
                     } else {
                         String::from("")
                     },
-                    issuer_path = parent.as_ref().to_string_lossy(),
+                    issuer_path = parent.to_string_lossy(),
                 )
             };
 
@@ -327,7 +324,7 @@ pub fn resolve_to_unqualified_via_manifest<P: AsRef<Path>>(
                 request: specifier.to_string(),
                 dependency_name: ident,
                 issuer_locator: parent_locator.clone(),
-                issuer_path: parent.as_ref().to_path_buf(),
+                issuer_path: parent.to_path_buf(),
             })));
         }
 
@@ -354,7 +351,7 @@ pub fn resolve_to_unqualified_via_manifest<P: AsRef<Path>>(
                     } else {
                         String::from("")
                     },
-                    issuer_path = parent.as_ref().to_string_lossy(),
+                    issuer_path = parent.to_string_lossy(),
                 )
             } else if !broken_ancestors.is_empty()
                 && broken_ancestors.iter().all(|locator| is_dependency_tree_root(manifest, locator))
@@ -369,7 +366,7 @@ pub fn resolve_to_unqualified_via_manifest<P: AsRef<Path>>(
                     } else {
                         String::from("")
                     },
-                    issuer_path = parent.as_ref().to_string_lossy(),
+                    issuer_path = parent.to_string_lossy(),
                 )
             } else {
                 format!(
@@ -382,7 +379,7 @@ pub fn resolve_to_unqualified_via_manifest<P: AsRef<Path>>(
                     } else {
                         String::from("")
                     },
-                    issuer_path = parent.as_ref().to_string_lossy(),
+                    issuer_path = parent.to_string_lossy(),
                 )
             };
 
@@ -391,7 +388,7 @@ pub fn resolve_to_unqualified_via_manifest<P: AsRef<Path>>(
                 request: specifier.to_string(),
                 dependency_name: ident,
                 issuer_locator: parent_locator.clone(),
-                issuer_path: parent.as_ref().to_path_buf(),
+                issuer_path: parent.to_path_buf(),
                 broken_ancestors: [].to_vec(),
             })))
         }
@@ -400,13 +397,13 @@ pub fn resolve_to_unqualified_via_manifest<P: AsRef<Path>>(
     }
 }
 
-pub fn resolve_to_unqualified<P: AsRef<Path>>(
+pub fn resolve_to_unqualified(
     specifier: &str,
-    parent: P,
+    parent: &Path,
     config: &ResolutionConfig,
 ) -> Result<Resolution, Error> {
-    if let Some(manifest) = (config.host.find_pnp_manifest)(parent.as_ref())? {
-        resolve_to_unqualified_via_manifest(&manifest, specifier, &parent)
+    if let Some(manifest) = (config.host.find_pnp_manifest)(parent)? {
+        resolve_to_unqualified_via_manifest(&manifest, specifier, parent)
     } else {
         Ok(Resolution::Skipped)
     }

src/lib_tests.rs

@@ -1,3 +1,5 @@
+use std::path::Path;
+
 use serde::Deserialize;
 
 use crate::{Manifest, Resolution};
@@ -28,18 +30,15 @@ mod tests {
 
     #[test]
     fn example() {
-        let manifest = load_pnp_manifest("data/pnp-yarn-v3.cjs").unwrap();
+        let manifest = load_pnp_manifest(Path::new("data/pnp-yarn-v3.cjs")).unwrap();
 
         let host =
             ResolutionHost { find_pnp_manifest: Box::new(move |_| Ok(Some(manifest.clone()))) };
 
         let config = ResolutionConfig { host };
 
-        let resolution = resolve_to_unqualified(
-            "lodash/cloneDeep",
-            std::path::PathBuf::from("/path/to/file"),
-            &config,
-        );
+        let resolution =
+            resolve_to_unqualified("lodash/cloneDeep", Path::new("/path/to/file"), &config);
 
         match resolution {
             Ok(Resolution::Resolved(_path, _subpath)) => {
@@ -60,10 +59,10 @@ mod tests {
 
     #[test]
     fn test_load_pnp_manifest() {
-        load_pnp_manifest("data/pnp-yarn-v3.cjs")
+        load_pnp_manifest(Path::new("data/pnp-yarn-v3.cjs"))
             .expect("Assertion failed: Expected to load the .pnp.cjs file generated by Yarn 3");
 
-        load_pnp_manifest("data/pnp-yarn-v4.cjs")
+        load_pnp_manifest(Path::new("data/pnp-yarn-v4.cjs"))
             .expect("Assertion failed: Expected to load the .pnp.cjs file generated by Yarn 4");
     }
 
@@ -81,7 +80,7 @@ mod tests {
 
         for test_suite in test_suites.iter_mut() {
             let manifest = &mut test_suite.manifest;
-            init_pnp_manifest(manifest, PathBuf::from("/path/to/project/.pnp.cjs"));
+            init_pnp_manifest(manifest, Path::new("/path/to/project/.pnp.cjs"));
 
             for test in test_suite.tests.iter() {
                 let specifier = &test.imported;
@@ -119,7 +118,7 @@ mod tests {
                 std::env::current_dir().unwrap().join("./data/edge_case_manifest_state.json");
             let manifest_content = fs::read_to_string(&manifest_json_path).unwrap();
             let mut manifest = serde_json::from_str::<Manifest>(&manifest_content).unwrap();
-            init_pnp_manifest(&mut manifest, manifest_json_path);
+            init_pnp_manifest(&mut manifest, &manifest_json_path);
             manifest
         };