Binary size with regex

[Boshen]

For the record, compiling in oxc-resolver (pnpm run build, ls -lh napi/resolver.darwin-arm64.node):

• with fancy_regex: 1.6M
• with regex: 1.3M
• without regex: 1.0M
• without pnp-rs: 866K

[Boshen]

For https://yarnpkg.com/configuration/yarnrc#pnpIgnorePatterns

pnp-rs/src/lib.rs

Line 90 in 790b34f

ignore_pattern_data: Option<RegexDef>,

It's probably safe to use https://github.com/oxc-project/fast-glob

[Boshen]

For

pnp-rs/src/lib.rs

Line 191 in 790b34f

"(const[ \\r\\n]+RAW_RUNTIME_STATE[ \\r\\n]*=[ \\r\\n]*|hydrateRuntimeState\\(JSON\\.parse\\()'"

I can hand-roll the pattern match.

[arcanis]

It's probably safe to use https://github.com/oxc-project/fast-glob

No, the serialized value in the .pnp.cjs file is a regex. We convert the glob pattern into a regex (since it's native to JS, unlike glob). We can't change that without changing the format.

[Boshen]

That's unfortunate.

I wonder why we need fancy regex for the look-around and backtracking features 🤔

We can pick regex_lite if we relax the constraint.