Add request pattern to resolver and add tests (#4189)

Author: kaylieEB

__tests__/commands/list.js

@@ -1,5 +1,5 @@
 /* @flow */
-
+import path from 'path';
 import type {Tree} from '../../src/reporters/types.js';
 import {BufferReporter} from '../../src/reporters/index.js';
 import {run as buildRun} from './_helpers.js';
@@ -8,8 +8,6 @@ import * as reporters from '../../src/reporters/index.js';
 
 jasmine.DEFAULT_TIMEOUT_INTERVAL = 90000;
 
-const path = require('path');
-
 function makeTree(name, {children = [], hint = null, color = null, depth = 0}: Object = {}): Tree {
   return {
     name,
@@ -56,6 +54,17 @@ test.concurrent('lists everything with no args', (): Promise<void> => {
   });
 });
 
+test.concurrent('should not throw when list is called with resolutions field', (): Promise<void> => {
+  return runList([], {}, {source: '', cwd: 'resolutions'}, (config, reporter): ?Promise<void> => {
+    const rprtr = new BufferReporter({});
+    const tree = reporter.getBuffer().slice(-1);
+    const children = [{name: 'left-pad@^1.1.3', color: 'dim', shadow: true}];
+    const trees = [makeTree('[email protected]', {children, color: 'bold'}), makeTree('[email protected]')];
+    rprtr.tree('list', trees);
+    expect(tree).toEqual(rprtr.getBuffer());
+  });
+});
+
 test.concurrent('respects depth flag', (): Promise<void> => {
   return runList([], {depth: 1}, 'depth-flag', (config, reporter): ?Promise<void> => {
     const rprtr = new BufferReporter({});

__tests__/fixtures/list/no-args/package.json

@@ -1,4 +1,6 @@
 {
+  "name": "depA",
+  "version": "1.0.0",
   "dependencies": {
     "left-pad": "^1.1.3"
   },

__tests__/fixtures/list/resolutions/package.json

@@ -0,0 +1,10 @@
+{
+  "name": "project",
+  "version": "1.0.0",
+  "dependencies": {
+    "depA": "file:../no-args"
+  },
+  "resolutions": {
+    "left-pad": "1.0.0"
+  }
+}

src/package-resolver.js

@@ -568,6 +568,7 @@ export default class PackageResolver {
       invariant(resolutionManifest._reference, 'resolutions should have a resolved reference');
 
       resolutionManifest._reference.patterns.push(pattern);
+      this.addPattern(pattern, resolutionManifest);
       this.lockfile.removePattern(pattern);
 
       return null;