Skip to content

Conversation

@RizkySugiharto
Copy link

Add type-hinting for each functions in Gdrive class and fix type-hint in its interface

@yaza-putu
Copy link
Owner

Add type-hinting for each functions in Gdrive class and fix type-hint in its interface

Did you have chan?

@yaza-putu yaza-putu closed this Oct 26, 2025
@yaza-putu yaza-putu reopened this Oct 26, 2025
@yaza-putu
Copy link
Owner

Add type-hinting for each functions in Gdrive class and fix type-hint in its interface

Sory, I for the late reply.

May I know, what the purpose of these changes is?

Is it just for code style or is it related with performance or anyting anything else?

@RizkySugiharto
Copy link
Author

I think its just the code style, i dont really know if the changes is giving impact to performance

@RizkySugiharto
Copy link
Author

if u look the changes, i change the return type of function like Gdrive::get or Gdrive::readStream into the defined class's object instead of the unknown/directed object

@yaza-putu
Copy link
Owner

if u look the changes, i change the return type of function like Gdrive::get or Gdrive::readStream into the defined class's object instead of the unknown/directed object

Do you have any idea where to store the new file instead of the helpers folder?

Usually, the helpers folder is associated with helper functions

@RizkySugiharto
Copy link
Author

if u look the changes, i change the return type of function like Gdrive::get or Gdrive::readStream into the defined class's object instead of the unknown/directed object

Do you have any idea where to store the new file instead of the helpers folder?

Usually, the helpers folder is associated with helper functions

i think so, but, when I search in google for standard global laravel file structure, one of them said the typing files should be in Helpers

i just realized that this is the composer package, not the laravel app. If you ask for my recommendation, I think it would be better to put the typing files in the typings directory

@yaza-putu
Copy link
Owner

If you ask for my recommendation, I think it would be better to put the typing files in the typings directory

Yes, I agree with you to put the typing file into typing folder

@RizkySugiharto
Copy link
Author

Yes, I agree with you to put the typing file into typing folder

Should I change it or you want to change it?

@yaza-putu
Copy link
Owner

yaza-putu commented Nov 5, 2025

You have created a new folder in your PR, so, I think you can rename that folder to typings

@RizkySugiharto
Copy link
Author

You have created a new folder in your PR, so, I think you can rename that folder to typings

I have renamed the Helpers directory into typings within the namespaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants