-
Notifications
You must be signed in to change notification settings - Fork 40
style: add comment/type-hint to each functions on Gdrive class for be… #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Did you have chan? |
Sory, I for the late reply. May I know, what the purpose of these changes is? Is it just for code style or is it related with performance or anyting anything else? |
|
I think its just the code style, i dont really know if the changes is giving impact to performance |
|
if u look the changes, i change the return type of function like |
Do you have any idea where to store the new file instead of the helpers folder? Usually, the helpers folder is associated with helper functions |
i think so, but, when I search in google for standard global laravel file structure, one of them said the typing files should be in i just realized that this is the composer package, not the laravel app. If you ask for my recommendation, I think it would be better to put the typing files in the |
Yes, I agree with you to put the typing file into typing folder |
Should I change it or you want to change it? |
|
You have created a new folder in your PR, so, I think you can rename that folder to typings |
I have renamed the |
Add type-hinting for each functions in Gdrive class and fix type-hint in its interface