Merge pull request GoogleCloudPlatform#168 from GoogleCloudPlatform/ajayhemnani-patch-4

ajayhemnani · web-flow · commit cb5845126587 · 2023-03-20T15:49:55.000-07:00
Update runner.py
diff --git a/workshops/tfx-caip-tf23/lab-04-tfx-metadata/labs/lab-04.ipynb b/workshops/tfx-caip-tf23/lab-04-tfx-metadata/labs/lab-04.ipynb
@@ -147,7 +147,7 @@
     "Update  the below constants  with the settings reflecting your lab environment.\n",
     "\n",
     "- `GCP_REGION` - the compute region for AI Platform Training and Prediction\n",
-    "- `ARTIFACT_STORE` - the GCS bucket created during installation of AI Platform Pipelines. The bucket name starts with the `kubeflowpipelines-` prefix. Alternatively, you can specify create a new storage bucket to write pipeline artifacts to."
+    "- `ARTIFACT_STORE` - the GCS bucket created during installation of AI Platform Pipelines. The bucket name starts with the `kubeflowpipelines-` prefix. Alternatively, you can specify create a new storage bucket to write pipeline artifacts to. When specifying the bucket, do not use the trailing slash (/) at the end of the bucket name."
    ]
   },
   {
diff --git a/workshops/tfx-caip-tf23/lab-04-tfx-metadata/labs/pipeline/runner.py b/workshops/tfx-caip-tf23/lab-04-tfx-metadata/labs/pipeline/runner.py
@@ -47,7 +47,7 @@
 
   beam_tmp_folder = '{}/beam/tmp'.format(Config.ARTIFACT_STORE_URI)
   beam_pipeline_args = [
-      '--runner=DataflowRunner',
+      '--runner=DirectRunner',
       '--experiments=shuffle_mode=auto',
       '--project=' + Config.PROJECT_ID,
       '--temp_location=' + beam_tmp_folder,
diff --git a/workshops/tfx-caip-tf23/lab-04-tfx-metadata/solutions/lab-04.ipynb b/workshops/tfx-caip-tf23/lab-04-tfx-metadata/solutions/lab-04.ipynb
@@ -147,7 +147,7 @@
     "Update  the below constants  with the settings reflecting your lab environment.\n",
     "\n",
     "- `GCP_REGION` - the compute region for AI Platform Training and Prediction\n",
-    "- `ARTIFACT_STORE` - the GCS bucket created during installation of AI Platform Pipelines. The bucket name starts with the `kubeflowpipelines-` prefix. Alternatively, you can specify create a new storage bucket to write pipeline artifacts to."
+    "- `ARTIFACT_STORE` - the GCS bucket created during installation of AI Platform Pipelines. The bucket name starts with the `kubeflowpipelines-` prefix. Alternatively, you can specify create a new storage bucket to write pipeline artifacts to. When specifying the bucket, do not use the trailing slash (/) at the end of the bucket name." 
    ]
   },
   {
diff --git a/workshops/tfx-caip-tf23/lab-04-tfx-metadata/solutions/pipeline/runner.py b/workshops/tfx-caip-tf23/lab-04-tfx-metadata/solutions/pipeline/runner.py
@@ -47,7 +47,7 @@
 
   beam_tmp_folder = '{}/beam/tmp'.format(Config.ARTIFACT_STORE_URI)
   beam_pipeline_args = [
-      '--runner=DataflowRunner',
+      '--runner=DirectRunner',
       '--experiments=shuffle_mode=auto',
       '--project=' + Config.PROJECT_ID,
       '--temp_location=' + beam_tmp_folder,

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@`
`147`	`147`	`"Update the below constants with the settings reflecting your lab environment.\n",`
`148`	`148`	`"\n",`
`149`	`149`	"- `GCP_REGION` - the compute region for AI Platform Training and Prediction\n",
`150`		- "- `ARTIFACT_STORE` - the GCS bucket created during installation of AI Platform Pipelines. The bucket name starts with the `kubeflowpipelines-` prefix. Alternatively, you can specify create a new storage bucket to write pipeline artifacts to."
	`150`	+ "- `ARTIFACT_STORE` - the GCS bucket created during installation of AI Platform Pipelines. The bucket name starts with the `kubeflowpipelines-` prefix. Alternatively, you can specify create a new storage bucket to write pipeline artifacts to. When specifying the bucket, do not use the trailing slash (/) at the end of the bucket name."
`151`	`151`	`]`
`152`	`152`	`},`
`153`	`153`	`{`