Skip to content

Commit 2273bbd

Browse files
author
Avery Levin
committed
updated log statements
1 parent b07869b commit 2273bbd

File tree

1 file changed

+18
-6
lines changed

1 file changed

+18
-6
lines changed

cache_helper/decorators.py

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@ def wrapper(*args, **kwargs):
2626
try:
2727
value = cache.get(cache_key)
2828
except Exception:
29+
logger.warning(
30+
f'Error retrieving value from Cache for Key: {function_cache_key}',
31+
exc_info=True,
32+
)
2933
value = None
3034

3135
if value is None:
@@ -38,7 +42,7 @@ def wrapper(*args, **kwargs):
3842

3943
except CacheSetError:
4044
logger.warning(
41-
f'Error saving value to Cache for Key: {cache_key}',
45+
f'Error saving value to Cache for Key: {function_cache_key}',
4246
exc_info=True,
4347
)
4448

@@ -77,6 +81,10 @@ def wrapper(*args, **kwargs):
7781
try:
7882
value = cache.get(cache_key)
7983
except Exception:
84+
logger.warning(
85+
f'Error retrieving value from Cache for Key: {function_cache_key}',
86+
exc_info=True,
87+
)
8088
value = None
8189

8290
if value is None:
@@ -88,7 +96,7 @@ def wrapper(*args, **kwargs):
8896
cache.set(cache_key, value, timeout)
8997
except CacheSetError:
9098
logger.warning(
91-
f'Error saving value to Cache for Key: {cache_key}',
99+
f'Error saving value to Cache for Key: {function_cache_key}',
92100
exc_info=True,
93101
)
94102

@@ -141,10 +149,14 @@ def __get__(self, obj, objtype):
141149
return fn
142150

143151
def __call__(self, *args, **kwargs):
144-
cache_key = self.create_cache_key(*args, **kwargs)
152+
cache_key, function_cache_key = self.create_cache_key(*args, **kwargs)
145153
try:
146154
value = cache.get(cache_key)
147155
except Exception:
156+
logger.warning(
157+
f'Error retrieving value from Cache for Key: {function_cache_key}',
158+
exc_info=True,
159+
)
148160
value = None
149161
if value is None:
150162
value = self.func(*args, **kwargs)
@@ -155,7 +167,7 @@ def __call__(self, *args, **kwargs):
155167
cache.set(cache_key, value, timeout)
156168
except CacheSetError:
157169
logger.warning(
158-
f'Error saving value to Cache for Key: {cache_key}',
170+
f'Error saving value to Cache for Key: {function_cache_key}',
159171
exc_info=True,
160172
)
161173
return value
@@ -168,14 +180,14 @@ def _invalidate(self, *args, **kwargs):
168180
:param kwargs: The kwargs passed into the original function.
169181
:rtype: None
170182
"""
171-
cache_key = self.create_cache_key(*args, **kwargs)
183+
cache_key, _ = self.create_cache_key(*args, **kwargs)
172184
cache.delete(cache_key)
173185

174186
def create_cache_key(self, *args, **kwargs):
175187
# Need to include the first arg (self) in the cache key
176188
func_name = utils.get_function_name(self.func)
177189
function_cache_key = utils.get_function_cache_key(func_name, args, kwargs)
178190
cache_key = utils.get_hashed_cache_key(function_cache_key)
179-
return cache_key
191+
return cache_key, function_cache_key
180192

181193
return wrapper

0 commit comments

Comments
 (0)