add logging and handle none values

Author: anthonyp97

cache_helper/decorators.py

@@ -36,12 +36,25 @@ def wrapper(*args, **kwargs):
                 )
                 value = sentinel
 
-            if value is sentinel:
+            if value is None:
+                logger.warning(
+                    'None cache value found for cache key: {}, function cache key: {}, value: {}'.format(
+                        cache_key, function_cache_key, value
+                    )
+                )
+
+            # Need to check for None as well because the cache client sends a None response at times
+            if value is sentinel or value is None:
                 value = func(*args, **kwargs)
                 # Try and set the key, value pair in the cache.
                 # But if it fails on an error from the underlying
                 # cache system, handle it.
                 try:
+                    logger.info(
+                        'Setting cache key: {}, value: {} for function cache key: {}'.format(
+                            cache_key, value, function_cache_key
+                            )
+                        )
                     cache.set(cache_key, value, timeout)
                 except CacheSetError:
                     logger.warning(
@@ -91,12 +104,25 @@ def wrapper(*args, **kwargs):
                 )
                 value = sentinel
 
-            if value is sentinel:
+            if value is None:
+                logger.warning(
+                    'None cache value found for cache key: {}, function cache key: {}, value: {}'.format(
+                        cache_key, function_cache_key, value
+                    )
+                )
+
+            # Need to check for None as well because the cache client sends a None response at times
+            if value is sentinel or value is None:
                 value = func(*args, **kwargs)
                 # Try and set the key, value pair in the cache.
                 # But if it fails on an error from the underlying
                 # cache system, handle it.
                 try:
+                    logger.info(
+                        'Setting cache key: {}, value: {} for function cache key: {}'.format(
+                            cache_key, value, function_cache_key
+                            )
+                        )
                     cache.set(cache_key, value, timeout)
                 except CacheSetError:
                     logger.warning(
@@ -167,12 +193,25 @@ def __call__(self, *args, **kwargs):
                 )
                 value = sentinel
 
-            if value is sentinel:
+            if value is None:
+                logger.warning(
+                    'None cache value found for cache key: {}, function cache key: {}, value: {}'.format(
+                        cache_key, function_cache_key, value
+                    )
+                )
+
+            # Need to check for None as well because the cache client sends a None response at times
+            if value is sentinel or value is None:
                 value = self.func(*args, **kwargs)
                 # Try and set the key, value pair in the cache.
                 # But if it fails on an error from the underlying
                 # cache system, handle it.
                 try:
+                    logger.info(
+                        'Setting cache key: {}, value: {} for function cache key: {}'.format(
+                            cache_key, value, function_cache_key
+                            )
+                        )
                     cache.set(cache_key, value, timeout)
                 except CacheSetError:
                     logger.warning(