Useful pylint fixes

After combing through all the stuff pylint has found, this seems to me
the useful part.

The only questionable thing here, I think, could be the stuff related to
`open()` and explicit encoding argument. This changes behaviour!
Without specifying, the encoding is platform dependent. See
https://docs.python.org/3/library/functions.html#open for details.

Fixes #1672

Author: bstaletic

.ycm_extra_conf.py

@@ -29,9 +29,7 @@
 # For more information, please refer to <http://unlicense.org/>
 
 from sysconfig import get_path
-import platform
 import os.path as p
-import subprocess
 
 DIR_OF_THIS_SCRIPT = p.abspath( p.dirname( __file__ ) )
 DIR_OF_THIRD_PARTY = p.join( DIR_OF_THIS_SCRIPT, 'third_party' )
@@ -120,7 +118,7 @@ def FindCorrespondingSourceFile( filename ):
 def PathToPythonUsedDuringBuild():
   try:
     filepath = p.join( DIR_OF_THIS_SCRIPT, 'PYTHON_USED_DURING_BUILDING' )
-    with open( filepath ) as f:
+    with open( filepath, encoding = 'utf8' ) as f:
       return f.read().strip()
   except OSError:
     return None

build.py

@@ -123,7 +123,7 @@ def UseVsWhere( quiet, vswhere_args ):
   latest_full_v = subprocess.check_output( vswhere_args ).strip().decode()
   if '.' in latest_full_v:
     try:
-      latest_v = int( latest_full_v.split( '.' )[ 0 ] )
+      latest_v = int( latest_full_v.split( '.', 1 )[ 0 ] )
     except ValueError:
       raise ValueError( f"{ latest_full_v } is not a version number." )
 
@@ -481,10 +481,10 @@ def ParseArguments():
                                DEFAULT_RUST_TOOLCHAIN + '" is tested/'
                               'supported by the maintainers of YCM/ycmd' )
   parser.add_argument( '--java-completer', action = 'store_true',
-                       help = 'Enable Java semantic completion engine.' ),
+                       help = 'Enable Java semantic completion engine.' )
   parser.add_argument( '--ts-completer', action = 'store_true',
                        help = 'Enable JavaScript and TypeScript semantic '
-                              'completion engine.' ),
+                              'completion engine.' )
   parser.add_argument( '--system-libclang', action = 'store_true',
                        help = 'Use system libclang instead of downloading one '
                        'from llvm.org. NOT RECOMMENDED OR SUPPORTED!' )
@@ -855,7 +855,6 @@ def CleanCsCompleter( build_dir, version ):
     if os.path.isfile( file_path ):
       os.remove( file_path )
     elif os.path.isdir( file_path ):
-      import shutil
       shutil.rmtree( file_path )
 
 
@@ -974,14 +973,14 @@ def EnableGoCompleter( args ):
 
 def WriteToolchainVersion( version ):
   path = p.join( RUST_ANALYZER_DIR, 'TOOLCHAIN_VERSION' )
-  with open( path, 'w' ) as f:
+  with open( path, 'w', encoding = 'utf8' ) as f:
     f.write( version )
 
 
 def ReadToolchainVersion():
   try:
     filepath = p.join( RUST_ANALYZER_DIR, 'TOOLCHAIN_VERSION' )
-    with open( filepath ) as f:
+    with open( filepath, encoding = 'utf8' ) as f:
       return f.read().strip()
   except OSError:
     return None
@@ -1255,7 +1254,7 @@ def Print( msg ):
 
 def WritePythonUsedDuringBuild():
   path = p.join( DIR_OF_THIS_SCRIPT, 'PYTHON_USED_DURING_BUILDING' )
-  with open( path, 'w' ) as f:
+  with open( path, 'w', encoding = 'utf8' ) as f:
     f.write( sys.executable )
 
 

run_tests.py

@@ -191,9 +191,9 @@ def BuildYcmdLibs( args ):
       '--core-tests'
     ]
 
-    for key in COMPLETERS:
+    for key, value in COMPLETERS.items():
       if key in args.completers:
-        build_cmd.extend( COMPLETERS[ key ][ 'build' ] )
+        build_cmd.extend( value[ 'build' ] )
 
     if args.msvc and platform.system() == 'Windows':
       build_cmd.extend( [ '--msvc', str( args.msvc ) ] )

update_clang_headers.py

@@ -39,7 +39,7 @@ def ExtractTar( uncompressed_data, destination ):
     tar_file.extractall( destination )
 
   # Determine the directory name
-  return os.path.join( destination, a_member.name.split( '/' )[ 0 ] )
+  return os.path.join( destination, a_member.name.split( '/', 1 )[ 0 ] )
 
 
 def ExtractLZMA( compressed_data, destination ):

update_unicode.py

@@ -607,7 +607,7 @@ def GenerateNormalizationTestCases( output_file ):
         JoinUnicodeToUtf8( captures[ 4 ].split() ) + '"},\n' )
 
   res[ -1 ] = res[ -1 ].rstrip( ',\n' )
-  with open( output_file, 'w' ) as f:
+  with open( output_file, 'w', encoding = 'utf8' ) as f:
     f.writelines( res )
 
 
@@ -629,7 +629,7 @@ def GenerateGraphemeBreakTestCases( output_file ):
                   for x in split_data ] ).rstrip( ',' ) + '}},\n' )
 
   res[ -1 ] = res[ -1 ].rstrip( ',\n' )
-  with open( output_file, 'w' ) as f:
+  with open( output_file, 'w', encoding = 'utf8' ) as f:
     f.writelines( res )
 
 

ycmd/__main__.py

@@ -133,7 +133,7 @@ def ParseArguments():
 def SetupLogging( log_level ):
   numeric_level = getattr( logging, log_level.upper(), None )
   if not isinstance( numeric_level, int ):
-    raise ValueError( 'Invalid log level: %s' % log_level )
+    raise ValueError( f'Invalid log level: { log_level }' )
 
   # Has to be called before any call to logging.getLogger()
   logging.basicConfig( format = '%(asctime)s - %(levelname)s - %(message)s',

ycmd/completers/cpp/clang_completer.py

@@ -436,9 +436,9 @@ def DebugInfo( self, request_data ):
 
     database_item = responses.DebugInfoItem(
       key = 'compilation database path',
-      value = '{0}'.format( database_directory ) )
+      value = f'{ database_directory }' )
     flags_item = responses.DebugInfoItem(
-      key = 'flags', value = '{0}'.format( list( flags ) ) )
+      key = 'flags', value = f'{ list( flags ) }' )
     filename_item = responses.DebugInfoItem(
       key = 'translation unit', value = filename )
 

ycmd/completers/cpp/flags.py

@@ -673,13 +673,12 @@ def UserIncludePaths( user_flags, filename ):
       it = iter( user_flags )
       for user_flag in it:
         user_flag_len = len( user_flag )
-        for flag in include_flags:
+        for flag, container in include_flags.items():
           if user_flag.startswith( flag ):
             flag_len = len( flag )
             include_path = ( next( it ) if user_flag_len == flag_len else
                              user_flag[ flag_len: ] )
             if include_path:
-              container = include_flags[ flag ]
               container.append( ToUnicode( include_path ) )
             break
     except StopIteration:

ycmd/completers/cs/cs_completer.py

@@ -393,7 +393,7 @@ def _GetSolutionFile( self, filepath ):
     return self._solution_for_file[ filepath ]
 
 
-class CsharpSolutionCompleter( object ):
+class CsharpSolutionCompleter:
   def __init__( self,
                 solution_path,
                 keep_logfiles,

ycmd/completers/language_server/generic_lsp_completer.py

@@ -48,11 +48,11 @@ def __init__( self, user_options, server_settings ):
       cmd = utils.FindExecutable( self._command_line[ 0 ] )
 
       if cmd is None:
-        utils.LOGGER.warn( "Unable to find any executable with the path %s. "
-                           "Cannot use %s completer.",
-                           self._command_line[ 0 ],
-                           self._name )
-        raise RuntimeError( f"Invalid cmdline: { str( self._command_line ) }" )
+        utils.LOGGER.warning( "Unable to find any executable with the path %s. "
+                              "Cannot use %s completer.",
+                              self._command_line[ 0 ],
+                              self._name )
+        raise RuntimeError( f"Invalid cmdline: { self._command_line }" )
 
       self._command_line[ 0 ] = cmd
       for idx in range( len( self._command_line ) ):