Provide a setting to disable tern

Author: puremourning

ycmd/completers/javascript/hook.py

@@ -22,7 +22,7 @@
 
 
 def GetCompleter( user_options ):
-  if ShouldEnableTernCompleter():
+  if ShouldEnableTernCompleter( user_options ):
     return TernCompleter( user_options )
   if ShouldEnableTypeScriptCompleter( user_options ):
     return TypeScriptCompleter( user_options )

ycmd/completers/javascript/tern_completer.py

@@ -54,12 +54,16 @@
 LOGFILE_FORMAT = 'tern_{port}_{std}_'
 
 
-def ShouldEnableTernCompleter():
+def ShouldEnableTernCompleter( user_options ):
   """Returns whether or not the tern completer is 'installed'. That is whether
   or not the tern submodule has a 'node_modules' directory. This is pretty much
   the only way we can know if the user added '--js-completer' on
   install or manually ran 'npm install' in the tern submodule directory."""
 
+  if user_options.get( 'disable_tern' ):
+    LOGGER.info( 'Not using Tern completer: disabled by user' )
+    return False
+
   if not PATH_TO_NODE:
     LOGGER.warning( 'Not using Tern completer: unable to find node' )
     return False

ycmd/tests/javascript/__init__.py

@@ -39,10 +39,8 @@ def setUpModule():
   subserver, should be done here."""
   global shared_app
 
-  with patch( 'ycmd.completers.javascript.hook.'
-              'ShouldEnableTernCompleter', return_value = False ):
-    shared_app = SetUpApp()
-    WaitUntilCompleterServerReady( shared_app, 'javascript' )
+  shared_app = SetUpApp( { 'disable_tern': True } )
+  WaitUntilCompleterServerReady( shared_app, 'javascript' )
 
 
 def tearDownModule():