Upgrade to clang 16.0.1

Author: puremourning

build.py

@@ -107,7 +107,7 @@ def Exit( self ):
   'issue tracker, including the entire output of this script (with --verbose) '
   'and the invocation line used to run it.' )
 
-CLANGD_VERSION = '15.0.1'
+CLANGD_VERSION = '16.0.1'
 CLANGD_BINARIES_ERROR_MESSAGE = (
   'No prebuilt Clang {version} binaries for {platform}. '
   'You\'ll have to compile Clangd {version} from source '
@@ -217,10 +217,6 @@ def OnWindows():
   return platform.system() == 'Windows'
 
 
-def OnFreeBSD():
-  return platform.system() == 'FreeBSD'
-
-
 def OnAArch64():
   return platform.machine().lower().startswith( 'aarch64' )
 
@@ -1131,38 +1127,30 @@ def GetClangdTarget():
   if OnWindows():
     return [
       ( 'clangd-{version}-win64',
-        'e5da88a729d1c9d00c8a965bdbfdf081a9c7a1602d5cdf7cd75aacea72180195' ),
+        'a0a7b16f6f92d545c84baff5e4bdb56897e955689ffc7407c915cc9d3c69a945' ),
       ( 'clangd-{version}-win32',
-        'e5be596af3b4ab5f648e6a3b67bb60a3e97f6567d2b3c43a38f30158792e2641' ) ]
+        '870de4d2a45380eba7c6b6640e2cb870219dd2025ed3bcb58101fd1d17f51d75' ) ]
   if OnMac():
     if OnArm():
       return [
         ( 'clangd-{version}-arm64-apple-darwin',
-          '7a606e37b03a795bf673116ef6c58cb888e7bd01199602bcae549c90927f124f' ) ]
+          'c5b0a314c00e4ce839ce1f4ee1ed46116f839949b7874affa759e10589340948' ) ]
     return [
       ( 'clangd-{version}-x86_64-apple-darwin',
-        '0be7dc9042584a84524f57d62bde0ef168b3e00a02205053cfe5f73a13475c97' ) ]
-  # FreeBSD binaries are not yet available for clang 15.0.1
-  #
-  # if OnFreeBSD():
-  #   return [
-  #     ( 'clangd-{version}-amd64-unknown-freebsd13',
-  #       '' ),
-  #     ( 'clangd-{version}-i386-unknown-freebsd13',
-  #       '' ) ]
+        '826c85889a1c288418e2c05b91e40158cde06f2e79f1e951d4983de2652a6d2c' ) ]
   if OnAArch64():
     return [
       ( 'clangd-{version}-aarch64-linux-gnu',
-        '2497705a703c0ed5b5ef8717e247b87d084729d6cae20176e0f4dc8e33fff24b' ) ]
+        '79f4a0a20342479c0e29573cf58810e0daabbf00178cf042edf6e1acb20a8602' ) ]
   if OnArm():
     return [
       None, # First list index is for 64bit archives. ARMv7 is 32bit only.
       ( 'clangd-{version}-armv7a-linux-gnueabihf',
-        '615262e7827f0ab273445390d9a0f4d841ba7fc75326483466651a846f4f5586' ) ]
+        'e521f21021885aaeb94e631949db6c0a65cc9c5c9c708afe4a42a058eb91ebca' ) ]
   if OnX86_64():
     return [
       ( 'clangd-{version}-x86_64-unknown-linux-gnu',
-        '8bf1177483daf10012f4e98ae4a6eec4f737bd1b6c8823b3b9b4a670479fcf58' ) ]
+        '51e69f6f5394ed6990cd7d938c53135ef2b5f8d2da1026eb291ffb3c81968847' ) ]
   raise InstallationFailed(
     CLANGD_BINARIES_ERROR_MESSAGE.format( version = CLANGD_VERSION,
                                           platform = 'this system' ) )

cpp/ycm/CMakeLists.txt

@@ -30,55 +30,41 @@ if ( USE_CLANG_COMPLETER AND
      NOT PATH_TO_LLVM_ROOT AND
      NOT EXTERNAL_LIBCLANG_PATH )
 
-  set( CLANG_VERSION 15.0.1 )
+  set( CLANG_VERSION 16.0.1 )
 
   if ( APPLE )
     if ( "${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "arm64" )
       set( LIBCLANG_DIRNAME "libclang-${CLANG_VERSION}-arm64-apple-darwin" )
       set( LIBCLANG_SHA256
-           "91d0c94cea43abe36d1fc954f78bc44dc77773fdf4680dd0958f05a8c859fcae" )
+           "3fd9230f591fc2cb081b3088d0b640b3692812adc59d03fb015441a65c68c328" )
     else()
       set( LIBCLANG_DIRNAME "libclang-${CLANG_VERSION}-x86_64-apple-darwin" )
       set( LIBCLANG_SHA256
-           "f004735cb8bfd56a8ea3c0ed21d1c8c02127ea23ce62eda38143270650a902fe" )
+           "43f7e4e72bc1d661eb01ee61666ee3a62a97d2993586c0b98efa6f46a96e768f" )
     endif()
   elseif ( WIN32 )
     if( 64_BIT_PLATFORM )
       set( LIBCLANG_DIRNAME "libclang-${CLANG_VERSION}-win64" )
       set( LIBCLANG_SHA256
-           "6e3196a4b92b5313898e51745c51d95410efd08fb2f1fabeba7205537ef7fed8" )
+           "06280c023ff339af29d68ea66366507607b03d01061d3d7066875b2ff4f78c29" )
     else()
       set( LIBCLANG_DIRNAME "libclang-${CLANG_VERSION}-win32" )
       set( LIBCLANG_SHA256
-           "3e0f81aeb47ad1f748abc51a5b37cdb5086a9aaac03955c1fdd0930b41887e11" )
+           "8f424ac12623638d8f8fa5f410499fe02a4a4ea9d1e02facdc484db9f1b0f4d8" )
     endif()
-  # FreeBSD binaries are not yet available for llvm 15.0,1
-  #
-  # elseif ( SYSTEM_IS_FREEBSD )
-  #   if ( 64_BIT_PLATFORM )
-  #     set( LIBCLANG_DIRNAME
-  #          "libclang-${CLANG_VERSION}-amd64-unknown-freebsd13" )
-  #     set( LIBCLANG_SHA256
-  #         "" )
-  #   else()
-  #     set( LIBCLANG_DIRNAME
-  #          "libclang-${CLANG_VERSION}-i386-unknown-freebsd13" )
-  #     set( LIBCLANG_SHA256
-  #          "" )
-  #  endif()
   elseif ( CMAKE_SYSTEM_PROCESSOR MATCHES "^(aarch64.*|AARCH64.*)" )
     set( LIBCLANG_DIRNAME "libclang-${CLANG_VERSION}-aarch64-linux-gnu" )
     set( LIBCLANG_SHA256
-         "294ffae61aab3198dc26b8cb891475ab4c08ab4e20f826c687260730350a3eaf" )
+         "518725f324e425cc3d0eafd1897cbf9cc35d9e442983b5efaa19112b73ae0ebf" )
   elseif ( CMAKE_SYSTEM_PROCESSOR MATCHES "^(arm.*|ARM.*)" )
     set( LIBCLANG_DIRNAME "libclang-${CLANG_VERSION}-armv7a-linux-gnueabihf" )
     set( LIBCLANG_SHA256
-         "e8ebe03b6fc558699f8ce389dd3693a9ac8cf4170b436cc0123fd923eba057d6" )
+         "5b45929923ec241bec18b714765554eb31365c4c90bf58529555665edd79a2f1" )
   elseif ( CMAKE_SYSTEM_PROCESSOR MATCHES "^(x86_64)" )
     set( LIBCLANG_DIRNAME
          "libclang-${CLANG_VERSION}-x86_64-unknown-linux-gnu" )
     set( LIBCLANG_SHA256
-         "89e8fdb6e7b694226405c6c2b8f5ef26f7683b4328bca7d7e611314189a75aa9" )
+         "e0c69d229f6dd91d0530508fa28250f658cb27d7b8825394bf539f8cc1db8c9c" )
   else()
     message( FATAL_ERROR
       "No prebuilt Clang ${CLANG_VERSION} binaries for this system. "

ycmd/tests/clangd/get_completions_test.py

@@ -372,7 +372,7 @@ def test_GetCompletions_NoCompletionsWhenAutoTriggerOff( self, app ):
 
 
   @WithRetry()
-  @SharedYcmd
+  @IsolatedYcmd( { 'clangd_uses_ycmd_caching': 1 } )
   def test_GetCompletions_ForceSemantic_YcmdCache( self, app ):
     RunTest( app, {
       'description': 'completions are returned when using ycmd filtering',
@@ -397,8 +397,9 @@ def test_GetCompletions_ForceSemantic_YcmdCache( self, app ):
       'expect': {
         'response': requests.codes.ok,
         'data': has_entries( {
-          'completions': contains_exactly( CompletionEntryMatcher( 'foobar' ),
-                                   CompletionEntryMatcher( 'floozar' ) ),
+          'completions': contains_exactly(
+            CompletionEntryMatcher( 'foobar' ),
+            CompletionEntryMatcher( 'floozar' ) ),
           'errors': empty()
         } )
       },
@@ -614,7 +615,7 @@ def test_GetCompletions_QuotedInclude( self, app ):
         'response': requests.codes.ok,
         'data': has_entries( {
           'completion_start_column': 11,
-          'completions': contains_exactly(
+          'completions': has_items(
             CompletionEntryMatcher( 'a.hpp"' ),
             CompletionEntryMatcher( 'b.hpp"' ),
             CompletionEntryMatcher( 'c.hpp"' ),

ycmd/tests/clangd/subcommands_test.py

@@ -522,7 +522,7 @@ def FixIt_Check_MacroExpand_Resolved( results ):
 def FixIt_Check_AutoExpand_Resolved( results ):
   assert_that( results, has_entries( {
     'fixits': has_items( has_entries( {
-        'text': "Expand auto type",
+        'text': "Replace with deduced type",
         'chunks': contains_exactly(
           ChunkMatcher( 'const char *',
                         LineColMatcher( 80, 1 ),
@@ -752,7 +752,6 @@ def test_Subcommands_GoToInclude( self, app ):
         { 'req': ( 'main.cpp',  6, 11 ), 'res': ( 'system/c.hpp', 1, 1 ) },
         # Expected failures
         { 'req': ( 'main.cpp',  7,  1 ), 'res': 'Cannot jump to location' },
-        { 'req': ( 'main.cpp', 10, 13 ), 'res': 'Cannot jump to location' },
       ],
       [ 'GoToImprecise', 'GoToInclude', 'GoTo' ] ):
       with self.subTest( test = test, cmd = cmd ):
@@ -789,7 +788,7 @@ def test_Subcommands_GoToReferences( self, app ):
         RunGoToTest_all( app, '', 'GoToReferences', test )
 
 
-  @SharedYcmd
+  @IsolatedYcmd()
   def test_Subcommands_GoToSymbol( self, app ):
     for test in [
       # In same file - 1 result