Skip to content

Commit 0c0d40a

Browse files
ycombinatorclaude
andcommitted
fix(e2e): remove implicit parent directory creation in extractTar/extractZip
Remove MkdirAll(filepath.Dir(path)) calls for regular files and symlinks so that missing directory entries in archives surface as test failures rather than being silently papered over (ref: PR elastic#4985). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 0734d74 commit 0c0d40a

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

testing/e2e/agent_download.go

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -229,9 +229,6 @@ func extractTar(t *testing.T, r io.Reader, destDir string) extractedPaths {
229229
t.Fatalf("failed to create directory %s: %v", path, err)
230230
}
231231
case mode.IsRegular():
232-
if err := os.MkdirAll(filepath.Dir(path), 0755); err != nil {
233-
t.Fatalf("failed to create parent directory for %s: %v", path, err)
234-
}
235232
w, err := os.OpenFile(path, os.O_RDWR|os.O_CREATE|os.O_TRUNC, mode.Perm())
236233
if err != nil {
237234
t.Fatalf("failed to create file %s: %v", path, err)
@@ -248,9 +245,6 @@ func extractTar(t *testing.T, r io.Reader, destDir string) extractedPaths {
248245
paths.fleetServerBinary = path
249246
}
250247
case mode.Type()&os.ModeSymlink == os.ModeSymlink:
251-
if err := os.MkdirAll(filepath.Dir(path), 0755); err != nil {
252-
t.Fatalf("failed to create parent directory for symlink %s: %v", path, err)
253-
}
254248
if err := os.Symlink(header.Linkname, path); err != nil {
255249
t.Fatalf("failed to create symlink %s: %v", path, err)
256250
}
@@ -289,9 +283,6 @@ func extractZip(t *testing.T, r io.Reader, destDir string) extractedPaths {
289283
t.Fatalf("failed to create directory %s: %v", path, err)
290284
}
291285
case mode.IsRegular():
292-
if err := os.MkdirAll(filepath.Dir(path), 0755); err != nil {
293-
t.Fatalf("failed to create parent directory for %s: %v", path, err)
294-
}
295286
w, err := os.OpenFile(path, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, file.Mode())
296287
if err != nil {
297288
t.Fatalf("failed to create file %s: %v", path, err)

0 commit comments

Comments
 (0)