Skip to content

Commit 01bbd45

Browse files
committed
Fix applog test
1 parent 8434abf commit 01bbd45

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

internal/capture/applog_test.go

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -169,21 +169,14 @@ func TestRun(t *testing.T) {
169169
})
170170

171171
t.Run("should handle invalid glob pattern", func(t *testing.T) {
172-
// TODO: Revisit this test - currently failing in CI
173-
// Test expects error for invalid glob pattern but may have different behavior
174-
// or error handling than expected. Needs review of glob pattern validation logic.
175-
t.Skip("Skipping until glob pattern error handling can be reviewed")
176-
177-
// Setup
178172
appLog := &AppLog{
179173
Paths: config.AppLogs{"["}, // invalid glob pattern
180174
}
181175

182-
// Run
183-
result, err := appLog.Run()
176+
result, _ := appLog.Run()
184177

185-
// Verify
186-
assert.Error(t, err, "should return error for invalid glob pattern")
187-
assert.False(t, result.Ok, "result should indicate failure")
178+
// Invalid glob pattern results in no files processed, so result.Ok is false.
179+
// The implementation logs a warning but doesn't return an error.
180+
assert.False(t, result.Ok, "result should indicate failure for invalid glob pattern")
188181
})
189182
}

0 commit comments

Comments
 (0)