WIP lint

Author: andy-tier1app

.golangci.yml

@@ -1,6 +1,30 @@
 version: "2"
+
 linters:
   default: standard
   disable:
-  - errcheck
+    - errcheck  # Too many issues to fix incrementally (50+)
+  enable:
+    - gocyclo
+    - misspell
+    - gocritic
+    - unconvert
+    - unparam
+    - revive
+  settings:
+    gocyclo:
+      min-complexity: 80  # Start lenient, tighten later (default: 30)
+    gocritic:
+      disabled-checks:
+        - ifElseChain  # Stylistic preference, not a bug
+    unparam:
+      check-exported: false  # Only check unexported functions
+    revive:
+      rules:
+        - name: exported
+          disabled: true  # Too many missing comments
+        - name: package-comments
+          disabled: true  # Too many missing package comments
+        - name: var-naming
+          disabled: true  # Would require significant refactoring (ApiKey -> APIKey, etc)
 

internal/agent/m3/m3.go

@@ -140,7 +140,7 @@ func (m3 *M3App) RunSingle() error {
 			return err
 		}
 
-		if len(resp) <= 0 {
+		if len(resp) == 0 {
 			logger.Log("WARNING: skip empty resp")
 			return err
 		}
@@ -184,7 +184,7 @@ func GetM3FinEndpoint(timestamp string, timezone string, pids map[int]string) st
 	/// append pod name and namespace in Kubernetes
 	if config.GlobalConfig.Kubernetes {
 		podName := getPodName()
-		//parameters += "&pod=" + podName
+		// parameters += "&pod=" + podName
 		ns := getMatchingNamespace(podName)
 		if ns != "" {
 			//	parameters += "&ns=" + ns
@@ -211,7 +211,8 @@ func GetM3CommonEndpointParameters(timestamp string, timezone string) string {
 	return parameters
 }
 
-func (m3 *M3App) captureAndTransmit(pids map[int]string, endpoint string) (err error) {
+//nolint:unparam // error return kept for future error handling
+func (m3 *M3App) captureAndTransmit(pids map[int]string, endpoint string) error {
 	logger.Log("yc-360 script version: " + executils.SCRIPT_VERSION)
 	logger.Log("yc-360 script starting in m3 mode...")
 
@@ -264,7 +265,7 @@ Resp: %s
 --------------------------------
 `, lpM3Result.Ok, lpM3Result.Msg)
 
-	return
+	return nil
 }
 
 func uploadGCLogM3(endpoint string, pid int) string {
@@ -506,7 +507,7 @@ Resps: %s
 
 func (m3 *M3App) uploadAccessLogM3(endpoint string, pid int, appName string) {
 	var accessLogM3Chan chan capture.Result
-	if len(config.GlobalConfig.AccessLogs) <= 0 {
+	if len(config.GlobalConfig.AccessLogs) == 0 {
 		return
 	}
 

internal/agent/m3/m3_test.go

@@ -23,7 +23,7 @@ func TestProcessResp(t *testing.T) {
 
 func TestM3FinPids(t *testing.T) {
 	var a = func(pids []int) string {
-		if len(pids) <= 0 {
+		if len(pids) == 0 {
 			return ""
 		}
 		var ps strings.Builder

internal/agent/ondemand/ondemand.go

@@ -36,7 +36,7 @@ import (
 var Wg sync.WaitGroup
 
 func ProcessPids(pids []int, pid2Name map[int]string, hd bool, tags string, timestamps []string) (rUrls []string, err error) {
-	if len(pids) <= 0 {
+	if len(pids) == 0 {
 		logger.Log("Empty pids, no action needed.")
 		return
 	}
@@ -103,7 +103,7 @@ func FullCapture(pid int, appName string, hd bool, tags string, tsParam string)
 			if tsParam == "" {
 				tsParam = timestamp
 			}
-			//parameters = fmt.Sprintf("de=%s&ts=%s", getOutboundIP().String(), tsParam)
+			// parameters = fmt.Sprintf("de=%s&ts=%s", getOutboundIP().String(), tsParam)
 			timezoneBase64 := base64.StdEncoding.EncodeToString([]byte(timezone))
 			parameters = fmt.Sprintf("de=%s&ts=%s&timezoneId=%s", getOutboundIP().String(), tsParam, timezoneBase64)
 			endpoint = fmt.Sprintf("%s/ycrash-receiver?%s", config.GlobalConfig.Server, parameters)
@@ -454,7 +454,7 @@ Falling back to capture all configured appLogs without appName filtering.`)
 
 		paths := config.AppLogs{}
 		for _, f := range discoveredLogFiles {
-			logger.Debug().Msgf("OnDemand FullCapture: discovered log file: %s", string(f))
+			logger.Debug().Msgf("OnDemand FullCapture: discovered log file: %s", f)
 			isGCLog := false
 			for _, fileName := range globFiles {
 				// To exclude discovered gc log such f as /tmp/buggyapp-%p-%t.log

internal/capture/access_log.go

@@ -10,6 +10,7 @@ import (
 const accessLogOut = "accesslog.out"
 
 // AccessLog represents struct that captures and uploads the specified log file.
+//
 // Deprecated: use App logs auto discovery instead.
 type AccessLog struct {
 	Capture

internal/capture/accesslogm3.go

@@ -78,7 +78,7 @@ func (a *AccessLogM3) Run() (Result, error) {
 			// %t = current date
 			p := strings.ReplaceAll(string(path.Path), "%t", currentDateStr)
 
-			matches, err := zglob.Glob(string(p))
+			matches, err := zglob.Glob(p)
 
 			if err != nil {
 				results = append(results, Result{

internal/capture/app_logs_auto_discovery.go

@@ -35,7 +35,7 @@ func DiscoverOpenedLogFilesByProcess(pid int) ([]string, error) {
 	}
 
 	for _, filePath := range openedFiles {
-		logger.Debug().Msgf("DiscoverOpenedLogFilesByProcess: opened file by process (pid=%d): %s", pid, string(filePath))
+		logger.Debug().Msgf("DiscoverOpenedLogFilesByProcess: opened file by process (pid=%d): %s", pid, filePath)
 
 		fileBaseName := filepath.Base(filePath)
 		if matchLogPattern(fileBaseName) {

internal/capture/applog.go

@@ -52,7 +52,7 @@ func (al *AppLog) Run() (Result, error) {
 
 	// Process each expanded file path
 	for _, filePath := range expandedPaths {
-		logger.Debug().Msgf("AppLog: expanded path: %s", string(filePath))
+		logger.Debug().Msgf("AppLog: expanded path: %s", filePath)
 
 		r, err := al.CaptureSingleAppLog(filePath)
 		results = append(results, r)

internal/capture/boomi.go

@@ -100,7 +100,7 @@ type AtomConnector struct {
 
 func CaptureBoomiDetails(endpoint string, timestamp string, pid int) {
 	// get Boomi details from the config
-	boomiURL := BoomiURL //config.GlobalConfig.BoomiUrl
+	boomiURL := BoomiURL // config.GlobalConfig.BoomiUrl
 	if boomiURL == "" {
 		logger.Log("Boomi server URL is missing. It is mandatory.")
 		return
@@ -204,7 +204,7 @@ func fetchBoomiExecutionRecords(boomiUserName, boomiPassword, boomiURL string) (
 
 		logger.Log("Length of Boomi queryResult.Result->%d", len(queryResult.Result))
 
-		if len(queryResult.Result) <= 0 {
+		if len(queryResult.Result) == 0 {
 			return records, nil
 		}
 
@@ -254,7 +254,7 @@ func fetchAtomConnectorDetails(boomiUserName, boomiPassword, boomiURL string) ([
 			return records, fmt.Errorf("error unmarshalling Boomi response as JSON: %w", jsonErr)
 		}
 		logger.Log("Length of Boomi queryResult.Result->%d", len(queryResult.Result))
-		if len(queryResult.Result) <= 0 {
+		if len(queryResult.Result) == 0 {
 			return records, nil
 		}
 
@@ -439,7 +439,7 @@ func (b *BoomiExecutionOutput) WriteAtomQueryDetails(atomQueryResult AtomQueryRe
 			if err != nil {
 				return fmt.Errorf("error while writing boomi execution output: %w", err)
 			}
-			//break
+			// break
 		} else {
 			boomiData := fmt.Sprintf("%s,%s,%s,%s,%s,%s,%s,%d,%s,%s\n", atomQuery.Type, atomQuery.Name, atomQuery.Status, atomQuery.AtomType, atomQuery.HostName, atomQuery.DateInstalled, atomQuery.CurrentVersion, atomQuery.ForceRestartTime, atomQuery.ID, "N")
 			_, err := b.file.WriteString(boomiData)
@@ -526,7 +526,7 @@ func makeBoomiRequest(queryToken string, username string, password string, boomi
 			}
 
 			// Print the body content
-			//fmt.Printf("Request Body: %s\n", string(bodyBytes))
+			// fmt.Printf("Request Body: %s\n", string(bodyBytes))
 
 			// Reset the request body
 			req.Body = io.NopCloser(bytes.NewReader(bodyBytes))
@@ -639,7 +639,7 @@ func makeAtomConnectorsRequest(queryToken string, username string, password stri
 			}
 
 			// Print the body content
-			//fmt.Printf("Request Body: %s\n", string(bodyBytes))
+			// fmt.Printf("Request Body: %s\n", string(bodyBytes))
 
 			// Reset the request body
 			req.Body = io.NopCloser(bytes.NewReader(bodyBytes))
@@ -722,7 +722,7 @@ func getAtomQueryDetails(accountID string, username string, password string) Ato
 		return atomQueryResult
 	}
 
-	//logger.Log("Atom Query details Result %v", atomQueryResult)
+	// logger.Log("Atom Query details Result %v", atomQueryResult)
 
 	return atomQueryResult
 }

internal/capture/extended_data_test.go

@@ -23,7 +23,7 @@ func setupMockServer(t *testing.T) *httptest.Server {
 }
 
 // createTestScript creates a cross-platform test script
-func createTestScript(t *testing.T, outputFile string) (string, string) {
+func createTestScript(t *testing.T, outputFile string) string {
 	scriptDir, err := os.MkdirTemp("", "extended-script-test-*")
 	if err != nil {
 		t.Fatalf("Failed to create temp dir: %v", err)
@@ -51,7 +51,7 @@ func createTestScript(t *testing.T, outputFile string) (string, string) {
 		t.Fatalf("Failed to get absolute path of script: %v", err)
 	}
 
-	return absScriptFile, scriptDir
+	return absScriptFile
 }
 
 // createLongRunningScript creates a script that runs for a specified duration
@@ -100,7 +100,7 @@ func TestExtendedData_Run_Success(t *testing.T) {
 	outputFile := filepath.Join(testDir, "output.log")
 
 	// Step 3: Create test script
-	absScriptFile, _ := createTestScript(t, outputFile)
+	absScriptFile := createTestScript(t, outputFile)
 
 	// Step 4: Create the ExtendedData struct
 	ed := &ExtendedData{
@@ -180,7 +180,7 @@ func TestExtendedData_Run_FolderDeleting(t *testing.T) {
 	outputFile := filepath.Join(testDir, "output.log")
 
 	// Step 3: Create test script
-	absScriptFile, _ := createTestScript(t, outputFile)
+	absScriptFile := createTestScript(t, outputFile)
 
 	// Step 4: Create the ExtendedData struct
 	ed := &ExtendedData{
@@ -215,7 +215,7 @@ func TestExtendedData_Run_ScriptFolderSameAsDataFolder(t *testing.T) {
 	outputFile := filepath.Join(testDir, "output.log")
 
 	// Step 3: Create test script
-	absScriptFile, _ := createTestScript(t, outputFile)
+	absScriptFile := createTestScript(t, outputFile)
 
 	// Step 4: Create the ExtendedData struct
 	ed := &ExtendedData{
@@ -241,7 +241,7 @@ func TestExtendedData_Run_EmptyDataFolder(t *testing.T) {
 
 	// Step 1: Create test script
 	tempOutputFile := filepath.Join(os.TempDir(), "output.log")
-	absScriptFile, _ := createTestScript(t, tempOutputFile)
+	absScriptFile := createTestScript(t, tempOutputFile)
 
 	// Step 2: Create the ExtendedData struct
 	ed := &ExtendedData{
@@ -297,7 +297,7 @@ func TestExtendedData_Run_RelativePath(t *testing.T) {
 	outputFile := filepath.Join(testDir, "output.log")
 
 	// Step 2: Create test script
-	absScriptFile, _ := createTestScript(t, outputFile)
+	absScriptFile := createTestScript(t, outputFile)
 
 	// Step 3: Create the ExtendedData struct
 	ed := &ExtendedData{