WIP re-enable agent test

Author: andy-tier1app

internal/agent/agent_test.go

@@ -1,6 +1,8 @@
 package agent
 
 import (
+	"os"
+	"runtime"
 	"testing"
 	"time"
 
@@ -11,10 +13,9 @@ import (
 )
 
 func TestRun(t *testing.T) {
-	// TODO: Revisit this test - currently failing in CI
-	// The test subcase "should_handle_invalid_glob_pattern" is failing.
-	// May be related to environment differences or test expectations needing adjustment.
-	t.Skip("Skipping until invalid glob pattern handling can be reviewed")
+	// Tests basic mode validation error cases that return immediately
+	t.Logf("DEBUG: TestRun starting - GOOS=%s GOARCH=%s NumCPU=%d", runtime.GOOS, runtime.GOARCH, runtime.NumCPU())
+	t.Logf("DEBUG: Working dir: %s", mustGetwd())
 
 	// Save original config and restore after tests
 	originalConfig := config.GlobalConfig
@@ -66,11 +67,9 @@ func TestRun(t *testing.T) {
 }
 
 func TestModeValidation(t *testing.T) {
-	// TODO: Revisit this test - currently failing in CI
-	// The test validates mode combinations (ondemand, m3, api) but has timing/blocking issues
-	// with goroutines and channels. Needs investigation of async behavior in CI environment.
-	// Related tests: m3 only, api only, ondemand_and_m3_conflict, m3_and_api_together, ondemand_and_api_together
-	t.Skip("Skipping until mode validation async behavior can be fixed")
+	// Tests various mode combinations with goroutine-based timeout detection
+	// Valid modes (m3, api) block indefinitely, so timeout = success for those cases
+	t.Logf("DEBUG: TestModeValidation starting - GOOS=%s GOARCH=%s", runtime.GOOS, runtime.GOARCH)
 
 	// Save original config and restore after tests
 	originalConfig := config.GlobalConfig
@@ -194,10 +193,8 @@ func TestModeValidation(t *testing.T) {
 }
 
 func TestResolvePidsFromToken(t *testing.T) {
-	// TODO: Revisit this test - currently failing in CI
-	// Test attempts to resolve PIDs from process tokens but may depend on
-	// environment-specific processes that don't exist in CI. Needs mocking.
-	t.Skip("Skipping until PID resolution can be properly mocked")
+	// Tests PID resolution from process tokens - uses nonexistent token to avoid env dependency
+	t.Logf("DEBUG: TestResolvePidsFromToken starting - GOOS=%s", runtime.GOOS)
 
 	// Save original config and restore after tests
 	originalConfig := config.GlobalConfig
@@ -216,9 +213,9 @@ func TestResolvePidsFromToken(t *testing.T) {
 }
 
 func TestModeLogic(t *testing.T) {
-	// TODO: Revisit this test - currently failing in CI
-	// Empty test that may have been a placeholder. Needs implementation or removal.
-	t.Skip("Skipping empty test - needs implementation")
+	// Placeholder test for future mode logic validation
+	// Currently validates test infrastructure only
+	t.Logf("DEBUG: TestModeLogic - placeholder test")
 
 	// Save original config and restore after tests
 	originalConfig := config.GlobalConfig
@@ -228,4 +225,16 @@ func TestModeLogic(t *testing.T) {
 
 	// Initialize logger for tests
 	logger.Init("", 0, 0, "info")
+
+	// Basic validation that config restoration works
+	assert.NotNil(t, originalConfig)
+}
+
+// mustGetwd returns current working directory or "unknown" on error
+func mustGetwd() string {
+	wd, err := os.Getwd()
+	if err != nil {
+		return "unknown"
+	}
+	return wd
 }