Introduce overlapping zero or write requests IBlockStore protection layer (#5282)

Author: drbasic

cloud/blockstore/config/server.proto

@@ -268,6 +268,9 @@ message TServerConfig
     // Optimal IO size for vhost devices. Zero value is the default one.
     // For linux, sets the value of /sys/block/<device>/queue/optimal_io_size.
     optional uint32 VhostOptimalIoSize = 127;
+
+    // Enables protection from executing overlapping zero or write requests.
+    optional bool EnableOverlappingRequestsGuard = 128;
 }
 
 ////////////////////////////////////////////////////////////////////////////////

cloud/blockstore/libs/client/switchable_session.h

@@ -21,6 +21,7 @@ namespace NCloud::NBlockStore::NClient {
 // 7. The old session is drained.
 // 8. The old session and all its underlying clients are deleted.
 /*
+Diagram
          Vhost
            |
            v
@@ -56,6 +57,9 @@ namespace NCloud::NBlockStore::NClient {
            |                          |
            v                          v
     StorageDataClient          StorageDataClient
+           |                          |
+           v                          v
+       IStorage                    IStorage
 */
 
 struct ISwitchableSession: public ISession

cloud/blockstore/libs/daemon/common/bootstrap.cpp

@@ -54,6 +54,7 @@
 #include <cloud/blockstore/libs/server/config.h>
 #include <cloud/blockstore/libs/server/server.h>
 #include <cloud/blockstore/libs/service/device_handler.h>
+#include <cloud/blockstore/libs/service/overlapping_requests_guard_service.h>
 #include <cloud/blockstore/libs/service/request_helpers.h>
 #include <cloud/blockstore/libs/service/service.h>
 #include <cloud/blockstore/libs/service/service_error_transform.h>
@@ -242,6 +243,10 @@ void TBootstrapBase::Init()
 
     STORAGE_INFO("Service initialized");
 
+    if (Configs->ServerConfig->GetEnableOverlappingRequestsGuard()) {
+        Service = CreateOverlappingRequestsGuardsService(std::move(Service));
+    }
+
     if (Configs->RdmaConfig->GetBlockstoreServerTargetEnabled()) {
         InitRdmaRequestServer();
         if (RdmaRequestServer) {

cloud/blockstore/libs/server/config.cpp

@@ -23,7 +23,7 @@ constexpr TDuration Seconds(int s)
 }
 
 ////////////////////////////////////////////////////////////////////////////////
-
+// clang-format off
 #define BLOCKSTORE_SERVER_CONFIG(xxx)                                          \
     xxx(Host,                        TString,               "localhost"       )\
     xxx(Port,                        ui32,                  9766              )\
@@ -112,9 +112,12 @@ constexpr TDuration Seconds(int s)
         NProto::EEncryptZeroPolicy,                                            \
         NProto::EZP_WRITE_ENCRYPTED_ZEROS                                     )\
     xxx(VhostPteFlushByteThreshold,  ui64,                   0                )\
-    xxx(AutomaticNbdDeviceManagement,bool,                   false            )
+    xxx(AutomaticNbdDeviceManagement,bool,                   false            )\
+    xxx(EnableOverlappingRequestsGuard,  bool,               false            )\
 // BLOCKSTORE_SERVER_CONFIG
 
+// clang-format on
+
 #define BLOCKSTORE_SERVER_DECLARE_CONFIG(name, type, value)                    \
     Y_DECLARE_UNUSED static const type Default##name = value;                  \
 // BLOCKSTORE_SERVER_DECLARE_CONFIG

cloud/blockstore/libs/server/config.h

@@ -143,6 +143,7 @@ class TServerAppConfig
     NProto::EEncryptZeroPolicy GetEncryptZeroPolicy() const;
     ui64 GetVhostPteFlushByteThreshold() const;
     bool GetAutomaticNbdDeviceManagement() const;
+    bool GetEnableOverlappingRequestsGuard() const;
 
     void Dump(IOutputStream& out) const override;
     void DumpHtml(IOutputStream& out) const override;