[Disk Manager] save state after set estimate in CreateDRBasedDiskCheckpoint task #4585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gy2411
added
large-tests
Collaborator
Author
|
Hmm, maybe there are some other tasks where we don't save state after setting estimages... |
Collaborator
Author
|
Wait, this is strange. We should update task state after its execution is stopped. Why don't we do it in this case?... Because we don't save state in case of NewInterruptExecutionError: https://github.com/ydb-platform/nbs/blob/main/cloud/tasks/runner.go#L213 |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SaveState call after setting the estimate. Without this call the estimate will be saved to database only after checkpoint is fully created. It might cause false positive hanging task reports.