rewrited parseStringLiteral func to be more understandable

Author: 1NepuNep1

internal/engine/ydb/convert.go

@@ -479,7 +479,7 @@ func (c *cc) VisitObject_feature_value(n *parser.Object_feature_valueContext) in
 		return bindPar
 
 	case n.STRING_VALUE() != nil:
-		value, _ := parseStringValue(n.STRING_VALUE().GetText())
+		value, _ := parseStringLiteral(n.STRING_VALUE().GetText())
 		return &ast.A_Const{Val: NewIdentifier(value), Location: c.pos(n.GetStart())}
 
 	case n.Bool_value() != nil:
@@ -3728,13 +3728,9 @@ func (c *cc) VisitLiteral_value(n *parser.Literal_valueContext) interface{} {
 
 	case n.STRING_VALUE() != nil: // !!! debug !!! (problem with quoted strings)
 		originalText := n.STRING_VALUE().GetText()
-		content, hasSuffix := parseStringValue(originalText)
+		content, _ := parseStringLiteral(originalText)
 
-		if hasSuffix {
-			return &ast.A_Const{Val: &ast.String{Str: originalText}, Location: c.pos(n.GetStart())}
-		} else {
-			return &ast.A_Const{Val: &ast.String{Str: content}, Location: c.pos(n.GetStart())}
-		}
+		return &ast.A_Const{Val: &ast.String{Str: content}, Location: c.pos(n.GetStart())}
 
 	case n.Bool_value() != nil:
 		var i bool

internal/engine/ydb/utils.go

@@ -296,8 +296,10 @@ func (c *cc) collectEqualityOps(ctx parser.ICond_exprContext) []antlr.TerminalNo
 	return ops
 }
 
-
-func parseStringValue(s string) (value string, hasSuffix bool) {
+// parseStringLiteral parses a string literal from a YQL query and returns the value and whether it has a suffix.
+// If a valid suffix is found, it is stripped and the content is returned.
+// FIXME: rewrite this logic to correctly handle the type based on the suffix.
+func parseStringLiteral(s string) (value string, hasSuffix bool) {
 	if len(s) < 2 {
 		return s, false
 	}