[C++ SDK] Fixed race on precommit callback add (#20733)

Author: Gazizonoki

.github/last_commit.txt

@@ -1 +1 @@
-576c1b6898e3f5d9a8c54e6df7f802575532aac3
+9184024c04c9a6f9cc079ebaea346ac89bc37aac

src/client/query/client.cpp

@@ -834,6 +834,8 @@ class TTransaction::TImpl : public std::enable_shared_from_this<TImpl> {
     }
 
     void AddPrecommitCallback(TPrecommitTransactionCallback cb) {
+        std::lock_guard lock(PrecommitCallbacksMutex);
+
         if (!ChangesAreAccepted) {
             ythrow TContractViolation("Changes are no longer accepted");
         }
@@ -842,6 +844,8 @@ class TTransaction::TImpl : public std::enable_shared_from_this<TImpl> {
     }
 
     void AddOnFailureCallback(TOnFailureTransactionCallback cb) {
+        std::lock_guard lock(OnFailureCallbacksMutex);
+
         if (!ChangesAreAccepted) {
             ythrow TContractViolation("Changes are no longer accepted");
         }
@@ -856,6 +860,9 @@ class TTransaction::TImpl : public std::enable_shared_from_this<TImpl> {
     bool ChangesAreAccepted = true; // haven't called Commit or Rollback yet
     std::vector<TPrecommitTransactionCallback> PrecommitCallbacks;
     std::vector<TOnFailureTransactionCallback> OnFailureCallbacks;
+
+    std::mutex PrecommitCallbacksMutex;
+    std::mutex OnFailureCallbacksMutex;
 };
 
 TTransaction::TTransaction(const TSession& session, const std::string& txId)

src/client/table/impl/transaction.cpp

@@ -92,6 +92,8 @@ TAsyncStatus TTransaction::TImpl::Rollback(const TRollbackTxSettings& settings)
 
 void TTransaction::TImpl::AddPrecommitCallback(TPrecommitTransactionCallback cb)
 {
+    std::lock_guard lock(PrecommitCallbacksMutex);
+
     if (!ChangesAreAccepted) {
         ythrow TContractViolation("Changes are no longer accepted");
     }
@@ -101,6 +103,8 @@ void TTransaction::TImpl::AddPrecommitCallback(TPrecommitTransactionCallback cb)
 
 void TTransaction::TImpl::AddOnFailureCallback(TOnFailureTransactionCallback cb)
 {
+    std::lock_guard lock(OnFailureCallbacksMutex);
+
     if (!ChangesAreAccepted) {
         ythrow TContractViolation("Changes are no longer accepted");
     }

src/client/table/impl/transaction.h

@@ -2,6 +2,8 @@
 
 #include <ydb-cpp-sdk/client/table/table.h>
 
+#include <mutex>
+
 namespace NYdb::inline V3::NTable {
 
 class TTransaction::TImpl : public std::enable_shared_from_this<TImpl> {
@@ -40,6 +42,9 @@ class TTransaction::TImpl : public std::enable_shared_from_this<TImpl> {
     bool ChangesAreAccepted = true; // haven't called Commit or Rollback yet
     mutable std::vector<TPrecommitTransactionCallback> PrecommitCallbacks;
     mutable std::vector<TOnFailureTransactionCallback> OnFailureCallbacks;
+
+    std::mutex PrecommitCallbacksMutex;
+    std::mutex OnFailureCallbacksMutex;
 };
 
 }