dev: Added specification YdbCommandTests and YdbParameterTests

Author: KirillKurdyukov

src/Ydb.Sdk/src/Ado/YdbCommand.cs

@@ -9,22 +9,23 @@ namespace Ydb.Sdk.Ado;
 
 public sealed class YdbCommand : DbCommand
 {
-    private YdbConnection? YdbConnection { get; set; }
+    private YdbConnection? _ydbConnection;
+    private string _commandText = string.Empty;
 
-    private string? _commandText = string.Empty;
+    private YdbConnection YdbConnection =>
+        _ydbConnection ?? throw new InvalidOperationException("Connection property has not been initialized");
 
     public YdbCommand()
     {
     }
 
     public YdbCommand(YdbConnection ydbConnection)
     {
-        YdbConnection = ydbConnection;
+        _ydbConnection = ydbConnection;
     }
 
     public override void Cancel()
     {
-        throw new NotImplementedException("Currently not supported");
     }
 
     public override int ExecuteNonQuery()
@@ -63,14 +64,37 @@ public override async Task<int> ExecuteNonQueryAsync(CancellationToken cancellat
 
     public override void Prepare()
     {
-        // Do nothing
+        if (YdbConnection.State == ConnectionState.Closed)
+        {
+            throw new InvalidOperationException("Connection is not open");
+        }
+
+        if (CommandText.Length == 0)
+        {
+            throw new InvalidOperationException("CommandText property has not been initialized");
+        }
+
+        if (YdbConnection.IsBusy)
+        {
+            throw new YdbOperationInProgressException(YdbConnection);
+        }
     }
 
     public override string CommandText
     {
-        get => _commandText ?? throw new InvalidOperationException("CommandText property has not been initialized");
+        get => _commandText;
 #pragma warning disable CS8765 // Nullability of type of parameter doesn't match overridden member (possibly because of nullability attributes).
-        [param: AllowNull] set => _commandText = value;
+        [param: AllowNull]
+        set
+        {
+            if (_ydbConnection?.LastReader?.IsOpen ?? false)
+            {
+                throw new InvalidOperationException("An open data reader exists for this command");
+            }
+
+            // ReSharper disable once NullCoalescingConditionIsAlwaysNotNullAccordingToAPIContract
+            _commandText = value ?? string.Empty;
+        }
 #pragma warning restore CS8765 // Nullability of type of parameter doesn't match overridden member (possibly because of nullability attributes).
     }
 
@@ -95,17 +119,22 @@ public override int CommandTimeout
 
     protected override DbConnection? DbConnection
     {
-        get => YdbConnection;
+        get => _ydbConnection;
         set
         {
+            if (_ydbConnection?.IsBusy ?? false)
+            {
+                throw new InvalidOperationException("An open data reader exists for this command.");
+            }
+
             if (value is null or Ado.YdbConnection)
             {
-                YdbConnection = (YdbConnection?)value;
+                _ydbConnection = (YdbConnection?)value;
             }
             else
             {
                 throw new ArgumentException(
-                    $"Unsupported DbTransaction type: {value.GetType()}, expected: {typeof(YdbConnection)}");
+                    $"Unsupported DbConnection type: {value.GetType()}, expected: {typeof(YdbConnection)}");
             }
         }
     }
@@ -153,16 +182,19 @@ protected override YdbDataReader ExecuteDbDataReader(CommandBehavior behavior)
     protected override async Task<DbDataReader> ExecuteDbDataReaderAsync(CommandBehavior behavior,
         CancellationToken cancellationToken)
     {
-        if (YdbConnection?.IsBusy
-            ?? throw new InvalidOperationException("Connection property has not been initialized."))
+        if (YdbConnection.IsBusy)
         {
             throw new YdbOperationInProgressException(YdbConnection);
         }
 
         YdbConnection.EnsureConnectionOpen();
 
         var ydbParameters = DbParameterCollection.YdbParameters;
-        var (sql, paramNames) = SqlParser.Parse(CommandText);
+        var (sql, paramNames) = SqlParser.Parse(
+            CommandText.Length > 0
+                ? CommandText
+                : throw new InvalidOperationException("CommandText property has not been initialized")
+        );
         var preparedSql = new StringBuilder();
 
         foreach (var paramName in paramNames)
@@ -182,9 +214,15 @@ protected override async Task<DbDataReader> ExecuteDbDataReaderAsync(CommandBeha
         var execSettings = CommandTimeout > 0
             ? new ExecuteQuerySettings { TransportTimeout = TimeSpan.FromSeconds(CommandTimeout) }
             : new ExecuteQuerySettings();
+        execSettings.CancellationToken = cancellationToken;
 
         var transaction = YdbConnection.CurrentTransaction;
 
+        if (Transaction != null && Transaction != transaction) // assert on legacy DbTransaction property
+        {
+            throw new InvalidOperationException("Transaction mismatched! (Maybe using another connection)");
+        }
+
         var ydbDataReader = await YdbDataReader.CreateYdbDataReader(YdbConnection.Session.ExecuteQuery(
                 preparedSql.ToString(), ydbParameters, execSettings, transaction?.TransactionControl),
             YdbConnection.Session.OnStatus, transaction);

src/Ydb.Sdk/src/Ado/YdbConnection.cs

@@ -163,9 +163,7 @@ public override string ConnectionString
         }
     }
 
-    public override string Database => State == ConnectionState.Closed
-        ? string.Empty
-        : ConnectionStringBuilder.Database;
+    public override string Database => _connectionStringBuilder?.Database ?? string.Empty;
 
     public override ConnectionState State => ConnectionState;
 

src/Ydb.Sdk/src/Ado/YdbDataReader.cs

@@ -597,7 +597,8 @@ private async Task<State> NextExecPart()
 
     private void OnFailReadStream()
     {
-        ReaderState = State.IsConsumed;
+        ReaderState = State.Close;
+
         if (_ydbTransaction != null)
         {
             _ydbTransaction.Failed = true;

src/Ydb.Sdk/src/Ado/YdbException.cs

@@ -29,7 +29,7 @@ public YdbException(Status status) : base(status.ToString())
     public StatusCode Code { get; }
 }
 
-public class YdbOperationInProgressException : YdbException
+public class YdbOperationInProgressException : InvalidOperationException
 {
     public YdbOperationInProgressException(YdbConnection ydbConnection)
         : base("A command is already in progress: " + ydbConnection.LastCommand)

src/Ydb.Sdk/src/Ado/YdbParameter.cs

@@ -61,7 +61,8 @@ public override void ResetDbType()
     }
 
     public override DbType DbType { get; set; } = DbType.Object;
-    public override ParameterDirection Direction { get; set; } = ParameterDirection.InputOutput;
+    public override ParameterDirection Direction { get; set; } = ParameterDirection.Input;
+    public override DataRowVersion SourceVersion { get; set; } = DataRowVersion.Current;
     public override bool IsNullable { get; set; }
 
     [AllowNull]
@@ -73,15 +74,24 @@ public override string ParameterName
         {
             _parameterName = value switch
             {
-                null => throw new YdbException("ParameterName must not be null!"),
+                null => string.Empty,
                 _ when value.StartsWith("$") => value,
                 _ when value.StartsWith("@") && value.Length > 1 => $"${value[1..]}",
                 _ => $"${value}"
             };
         }
     }
 
-    [AllowNull] [DefaultValue("")] public override string SourceColumn { get; set; } = string.Empty;
+    private string _sourceColumn = string.Empty;
+
+    [AllowNull]
+    [DefaultValue("")]
+    public override string SourceColumn
+    {
+        get => _sourceColumn;
+        set => _sourceColumn = value ?? string.Empty;
+    }
+
     public override object? Value { get; set; }
     public override bool SourceColumnNullMapping { get; set; }
     public override int Size { get; set; }
@@ -102,22 +112,22 @@ string valueString when DbType is DbType.String or DbType.AnsiString or DbType.A
                     DbType.Date => YdbValue.MakeDate(dateTimeValue),
                     DbType.DateTime => YdbValue.MakeDatetime(dateTimeValue),
                     DbType.DateTime2 or DbType.Object => YdbValue.MakeTimestamp(dateTimeValue),
-                    _ => ThrowInvalidCast()
+                    _ => ThrowInvalidOperation()
                 },
                 DateTimeOffset dateTimeOffset when DbType is DbType.DateTimeOffset or DbType.Object =>
                     YdbValue.MakeTimestamp(dateTimeOffset.UtcDateTime),
                 float floatValue => DbType switch
                 {
                     DbType.Single or DbType.Object => YdbValue.MakeFloat(floatValue),
                     DbType.Double => YdbValue.MakeDouble(floatValue),
-                    _ => ThrowInvalidCast()
+                    _ => ThrowInvalidOperation()
                 },
                 double doubleValue when DbType is DbType.Double or DbType.Object => YdbValue.MakeDouble(doubleValue),
                 int intValue => DbType switch
                 {
                     DbType.Int32 or DbType.Object => YdbValue.MakeInt32(intValue),
                     DbType.Int64 => YdbValue.MakeInt64(intValue),
-                    _ => ThrowInvalidCast()
+                    _ => ThrowInvalidOperation()
                 },
                 long longValue when DbType is DbType.Int64 or DbType.Object => YdbValue.MakeInt64(longValue),
                 decimal decimalValue when DbType is DbType.Decimal or DbType.Currency or DbType.Object =>
@@ -128,7 +138,7 @@ string valueString when DbType is DbType.String or DbType.AnsiString or DbType.A
                     DbType.UInt32 or DbType.Object => YdbValue.MakeUint32(uintValue),
                     DbType.UInt64 => YdbValue.MakeUint64(uintValue),
                     DbType.Int64 => YdbValue.MakeInt64(uintValue),
-                    _ => ThrowInvalidCast()
+                    _ => ThrowInvalidOperation()
                 },
                 byte byteValue => DbType switch
                 {
@@ -139,15 +149,15 @@ string valueString when DbType is DbType.String or DbType.AnsiString or DbType.A
                     DbType.UInt64 => YdbValue.MakeUint64(byteValue),
                     DbType.UInt32 => YdbValue.MakeUint32(byteValue),
                     DbType.UInt16 => YdbValue.MakeUint16(byteValue),
-                    _ => ThrowInvalidCast()
+                    _ => ThrowInvalidOperation()
                 },
                 sbyte sbyteValue => DbType switch
                 {
                     DbType.SByte or DbType.Object => YdbValue.MakeInt8(sbyteValue),
                     DbType.Int64 => YdbValue.MakeInt64(sbyteValue),
                     DbType.Int32 => YdbValue.MakeInt32(sbyteValue),
                     DbType.Int16 => YdbValue.MakeInt16(sbyteValue),
-                    _ => ThrowInvalidCast()
+                    _ => ThrowInvalidOperation()
                 },
                 ushort ushortValue => DbType switch
                 {
@@ -156,27 +166,29 @@ string valueString when DbType is DbType.String or DbType.AnsiString or DbType.A
                     DbType.Int32 => YdbValue.MakeInt32(ushortValue),
                     DbType.UInt64 => YdbValue.MakeUint64(ushortValue),
                     DbType.UInt32 => YdbValue.MakeUint32(ushortValue),
-                    _ => ThrowInvalidCast()
+                    _ => ThrowInvalidOperation()
                 },
                 short shortValue => DbType switch
                 {
                     DbType.Int16 or DbType.Object => YdbValue.MakeInt16(shortValue),
                     DbType.Int64 => YdbValue.MakeInt64(shortValue),
                     DbType.Int32 => YdbValue.MakeInt32(shortValue),
-                    _ => ThrowInvalidCast()
+                    _ => ThrowInvalidOperation()
                 },
                 byte[] bytesValue when DbType is DbType.Binary or DbType.Object => YdbValue.MakeString(bytesValue),
                 Guid guidValue when DbType is DbType.Guid or DbType.Object => YdbValue.MakeUuid(guidValue),
+                MemoryStream memoryStream when DbType is DbType.Binary or DbType.Object => YdbValue.MakeString(
+                    memoryStream.ToArray()),
                 _ when DbType is DbType.VarNumeric or DbType.Xml or DbType.Time =>
                     throw new YdbException($"Ydb don't supported this DbType: {DbType}"),
-                _ => ThrowInvalidCast()
+                _ => ThrowInvalidOperation()
             };
         }
     }
 
-    private YdbValue ThrowInvalidCast()
+    private YdbValue ThrowInvalidOperation()
     {
-        throw new InvalidCastException(
+        throw new InvalidOperationException(
             $"Writing value of '{Value?.GetType().ToString() ?? "null"}' is not supported for parameters having DbType '{DbType}'");
     }
 }

src/Ydb.Sdk/src/Ado/YdbParameterCollection.cs

@@ -104,15 +104,15 @@ public bool Remove(YdbParameter item)
     }
 
     /// <inheritdoc />
-    public override int IndexOf(object value)
+    public override int IndexOf(object? value)
     {
         return _parameters.IndexOf(Cast(value));
     }
 
     /// <inheritdoc />
     public override void Insert(int index, object value)
     {
-        _parameters[index] = Cast(value);
+        _parameters.Insert(index, Cast(value));
     }
 
     /// <summary>
@@ -175,6 +175,7 @@ protected override void SetParameter(int index, DbParameter value)
     /// <inheritdoc />
     protected override void SetParameter(string parameterName, DbParameter value)
     {
+        ArgumentNullException.ThrowIfNull(value);
         var index = IndexOf(parameterName);
 
         if (index == -1)
@@ -258,12 +259,9 @@ public override void AddRange(Array values)
 
     private static YdbParameter Cast(object? value)
     {
-        if (value is YdbParameter ydbParameter)
-        {
-            return ydbParameter;
-        }
+        ArgumentNullException.ThrowIfNull(value);
 
-        throw new InvalidCastException(
+        return value as YdbParameter ?? throw new InvalidCastException(
             $"The value \"{value}\" is not of type \"{nameof(YdbParameter)}\" and cannot be used in this parameter collection.");
     }
 }