Skip to content

Commit 0d318d2

Browse files
feat: update CAS on buffer
1 parent b24c825 commit 0d318d2

File tree

7 files changed

+21
-21
lines changed

7 files changed

+21
-21
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ jobs:
108108
uses: actions/setup-dotnet@v4
109109
with:
110110
dotnet-version: ${{ matrix.dotnet-version }}
111-
- name: Run ADO.NET tests
111+
- name: Run Topic tests
112112
run: |
113113
docker cp ydb-local:/ydb_certs/ca.pem ~/
114114
cd src
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,28 @@
11
namespace Ydb.Sdk.Services.Topic;
22

3-
public class YdbWriterException : Exception
3+
public class WriterException : Exception
44
{
5-
public YdbWriterException(string message) : base(message)
5+
public WriterException(string message) : base(message)
66
{
77
Status = new Status(StatusCode.Unspecified);
88
}
99

10-
public YdbWriterException(string message, Status status) : base(message + ": " + status)
10+
public WriterException(string message, Status status) : base(message + ": " + status)
1111
{
1212
Status = status;
1313
}
1414

15-
public YdbWriterException(string message, Driver.TransportException e) : base(message, e)
15+
public WriterException(string message, Driver.TransportException e) : base(message, e)
1616
{
1717
Status = e.Status;
1818
}
1919

2020
public Status Status { get; }
2121
}
2222

23-
public class YdbReaderException : Exception
23+
public class ReaderException : Exception
2424
{
25-
protected YdbReaderException(string message) : base(message)
25+
protected ReaderException(string message) : base(message)
2626
{
2727
}
2828
}

src/Ydb.Sdk/src/Services/Topic/Reader/ReaderBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public Task<IReader<TValue>> Build()
2222
// Deserializer ?? (IDeserializer<TValue>)(
2323
// Deserializers.DefaultDeserializers.TryGetValue(typeof(TValue), out var deserializer)
2424
// ? deserializer
25-
// : throw new YdbWriterException("The serializer is not set")
25+
// : throw new WriterException("The serializer is not set")
2626
// )
2727
// );
2828
//

src/Ydb.Sdk/src/Services/Topic/Writer/WriteResult.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ internal WriteResult(StreamWriteMessage.Types.WriteResponse.Types.WriteAck ack)
1919
break;
2020
case StreamWriteMessage.Types.WriteResponse.Types.WriteAck.MessageWriteStatusOneofCase.None:
2121
default:
22-
throw new YdbWriterException($"Unexpected WriteAck status: {ack.MessageWriteStatusCase}");
22+
throw new WriterException($"Unexpected WriteAck status: {ack.MessageWriteStatusCase}");
2323
}
2424
}
2525

src/Ydb.Sdk/src/Services/Topic/Writer/Writer.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,8 @@ public async Task<WriteResult> WriteAsync(Message<TValue> message)
7474
curLimitBufferSize == _config.BufferMaxSize && data.Length > curLimitBufferSize
7575
|| curLimitBufferSize >= data.Length)
7676
{
77-
if (Interlocked.CompareExchange(ref _limitBufferMaxSize, curLimitBufferSize,
78-
curLimitBufferSize - data.Length) == curLimitBufferSize)
77+
if (Interlocked.CompareExchange(ref _limitBufferMaxSize,
78+
curLimitBufferSize - data.Length, curLimitBufferSize) == curLimitBufferSize)
7979
{
8080
_toSendBuffer.Enqueue(new MessageSending(messageData, completeTask));
8181

@@ -92,7 +92,7 @@ public async Task<WriteResult> WriteAsync(Message<TValue> message)
9292
"Buffer overflow: the data size [{DataLength}] exceeds the current buffer limit ({CurLimitBufferSize}) [BufferMaxSize = {BufferMaxSize}]",
9393
data.Length, curLimitBufferSize, _config.BufferMaxSize);
9494

95-
throw new YdbWriterException("Buffer overflow");
95+
throw new WriterException("Buffer overflow");
9696
}
9797

9898
try
@@ -199,7 +199,7 @@ private async Task Initialize()
199199
_logger.LogError(e, "Unable to connect the session");
200200

201201
_session = new NotStartedWriterSession(
202-
new YdbWriterException("Transport error on creating write session", e));
202+
new WriterException("Transport error on creating write session", e));
203203
}
204204
}
205205

@@ -227,19 +227,19 @@ internal interface IWriteSession : IDisposable
227227

228228
internal class NotStartedWriterSession : IWriteSession
229229
{
230-
private readonly YdbWriterException _reasonException;
230+
private readonly WriterException _reasonException;
231231

232232
public NotStartedWriterSession(string reasonExceptionMessage)
233233
{
234-
_reasonException = new YdbWriterException(reasonExceptionMessage);
234+
_reasonException = new WriterException(reasonExceptionMessage);
235235
}
236236

237237
public NotStartedWriterSession(string reasonExceptionMessage, Status status)
238238
{
239-
_reasonException = new YdbWriterException(reasonExceptionMessage, status);
239+
_reasonException = new WriterException(reasonExceptionMessage, status);
240240
}
241241

242-
public NotStartedWriterSession(YdbWriterException reasonException)
242+
public NotStartedWriterSession(WriterException reasonException)
243243
{
244244
_reasonException = reasonException;
245245
}
@@ -365,7 +365,7 @@ Completing task on exception...
365365
Client SeqNo: {SeqNo}, WriteAck: {WriteAck}",
366366
messageFromClient.MessageData.SeqNo, ack);
367367

368-
messageFromClient.TaskCompletionSource.SetException(new YdbWriterException(
368+
messageFromClient.TaskCompletionSource.SetException(new WriterException(
369369
$"Client SeqNo[{messageFromClient.MessageData.SeqNo}] is less then server's WriteAck[{ack}]"));
370370
}
371371
else

src/Ydb.Sdk/src/Services/Topic/Writer/WriterBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public IWriter<TValue> Build()
2121
Serializer ?? (ISerializer<TValue>)(
2222
Serializers.DefaultSerializers.TryGetValue(typeof(TValue), out var serializer)
2323
? serializer
24-
: throw new YdbWriterException("The serializer is not set")
24+
: throw new WriterException("The serializer is not set")
2525
)
2626
);
2727
}

src/Ydb.Sdk/tests/Topic/WriterIntegrationTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public async Task WriteAsync_WhenTopicNotFound_ReturnNotFoundException()
4444
new WriterConfig(_topicName + "_not_found") { ProducerId = "producerId" })
4545
.Build();
4646

47-
Assert.Equal(StatusCode.SchemeError, (await Assert.ThrowsAsync<YdbWriterException>(
48-
() => writer.WriteAsync("hello world"))).Status.StatusCode);
47+
Assert.Equal(StatusCode.SchemeError, (await Assert.ThrowsAsync<WriterException>(
48+
() => writer.WriteAsync("hello world"))).Status.StatusCode);
4949
}
5050
}

0 commit comments

Comments
 (0)