checking logs

Author: LiamHamsters

src/EFCore.Ydb/src/Storage/Internal/Mapping/YdbDecimalTypeMapping.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Data.Common;
 using Microsoft.EntityFrameworkCore.Storage;
 
@@ -36,13 +35,10 @@ protected override void ConfigureParameter(DbParameter parameter)
     {
         base.ConfigureParameter(parameter);
 
-        var p = (byte)(Precision ?? DefaultPrecision);
-        var s = (byte)(Scale ?? DefaultScale);
+        if (Precision is { } p)
+            parameter.Precision = (byte)p;
 
-        parameter.Precision = p;
-        parameter.Scale = s;
-
-        if (parameter.Value is decimal d)
-            parameter.Value = decimal.Round(d, s, MidpointRounding.ToEven);
+        if (Scale is { } s)
+            parameter.Scale = (byte)s;
     }
 }

src/EFCore.Ydb/test/EntityFrameworkCore.Ydb.FunctionalTests/Query/DecimalParameterQueryYdbFixture.cs

@@ -10,6 +10,14 @@ public class DecimalParameterQueryYdbFixture : SharedStoreFixtureBase<DecimalPar
 
     protected override ITestStoreFactory TestStoreFactory => YdbTestStoreFactory.Instance;
 
+    public override async Task InitializeAsync()
+    {
+        await base.InitializeAsync();
+
+        await using var context = CreateContext();
+        await context.Database.EnsureCreatedAsync();
+    }
+
     public class TestContext(DbContextOptions options) : DbContext(options)
     {
         protected override void OnModelCreating(ModelBuilder modelBuilder)

src/EFCore.Ydb/test/EntityFrameworkCore.Ydb.FunctionalTests/Query/DecimalParameterizedYdbTheoryTest.cs

@@ -52,52 +52,32 @@ private ParametricDecimalContext NewCtx(int p, int s)
     public async Task Decimal_roundtrips_or_rounds_like_ado(int p, int s, decimal value)
     {
         await using var ctx = NewCtx(p, s);
+        await ctx.Database.EnsureCreatedAsync();
 
-        try
-        {
-            var e = new ParamItem { Price = value };
-            ctx.Add(e);
-            await ctx.SaveChangesAsync();
+        var e = new ParamItem { Price = value };
+        ctx.Add(e);
+        await ctx.SaveChangesAsync();
 
-            var got = await ctx.Items.AsNoTracking().SingleAsync(x => x.Id == e.Id);
+        var got = await ctx.Items.AsNoTracking().SingleAsync(x => x.Id == e.Id);
 
-            var expected = Math.Round(value, s, MidpointRounding.ToEven);
-            Assert.Equal(expected, got.Price);
+        var expected = Math.Round(value, s, MidpointRounding.ToEven);
+        Assert.Equal(expected, got.Price);
 
-            var tms = ctx.GetService<IRelationalTypeMappingSource>();
-            var et = ctx.Model.FindEntityType(typeof(ParamItem))!;
-            var prop = et.FindProperty(nameof(ParamItem.Price))!;
-            var mapping = tms.FindMapping(prop)!;
-            Assert.Equal($"Decimal({p}, {s})", mapping.StoreType);
-        }
-        catch (DbUpdateException ex) when ((ex.InnerException?.Message ?? "").Contains("Cannot find table",
-                                               StringComparison.OrdinalIgnoreCase))
-        {
-        }
-        catch (Exception ex) when (ex.ToString()
-                                       .Contains("EnableParameterizedDecimal", StringComparison.OrdinalIgnoreCase))
-        {
-        }
+        var tms = ctx.GetService<IRelationalTypeMappingSource>();
+        var et = ctx.Model.FindEntityType(typeof(ParamItem))!;
+        var prop = et.FindProperty(nameof(ParamItem.Price))!;
+        var mapping = tms.FindMapping(prop)!;
+        Assert.Equal($"Decimal({p}, {s})", mapping.StoreType);
     }
 
     [Theory]
     [MemberData(nameof(OverflowCases))]
     public async Task Decimal_overflow_bubbles_up(int p, int s, decimal value)
     {
         await using var ctx = NewCtx(p, s);
+        await ctx.Database.EnsureCreatedAsync();
 
-        try
-        {
-            ctx.Add(new ParamItem { Price = value });
-            await Assert.ThrowsAsync<DbUpdateException>(() => ctx.SaveChangesAsync());
-        }
-        catch (DbUpdateException ex) when ((ex.InnerException?.Message ?? "").Contains("Cannot find table",
-                                               StringComparison.OrdinalIgnoreCase))
-        {
-        }
-        catch (Exception ex) when (ex.ToString()
-                                       .Contains("EnableParameterizedDecimal", StringComparison.OrdinalIgnoreCase))
-        {
-        }
+        ctx.Add(new ParamItem { Price = value });
+        await Assert.ThrowsAsync<DbUpdateException>(() => ctx.SaveChangesAsync());
     }
 }

src/EFCore.Ydb/test/EntityFrameworkCore.Ydb.FunctionalTests/Query/ParametricDecimalContext.cs

@@ -19,6 +19,7 @@ public ParametricDecimalContext(DbContextOptions<ParametricDecimalContext> optio
     protected override void OnModelCreating(ModelBuilder modelBuilder) =>
         modelBuilder.Entity<ParamItem>(b =>
         {
+            b.ToTable($"Items_{_p}_{_s}");
             b.HasKey(x => x.Id);
             b.Property(x => x.Price).HasPrecision(_p, _s);
         });