fix

Author: KirillKurdyukov

.github/workflows/slo.yml

@@ -7,19 +7,6 @@ on:
   pull_request:
     branches:
       - main
-  workflow_dispatch:
-    inputs:
-      github_pull_request_number:
-        required: true
-      slo_workload_duration_seconds:
-        default: '600'
-        required: false
-      slo_workload_read_max_rps:
-        default: '1000'
-        required: false
-      slo_workload_write_max_rps:
-        default: '1000'
-        required: false
 
 jobs:
   ydb-slo-action:
@@ -33,6 +20,16 @@ jobs:
           - AdoNet
           - Dapper
           - EF
+        include:
+          - workload: AdoNet
+            read_rps: 1000
+            write_rps: 1000
+          - workload: Dapper
+            read_rps: 1000
+            write_rps: 1000
+          - workload: EF
+            read_rps: 200
+            write_rps: 200
 
     concurrency:
       group: slo-${{ github.ref }}-${{ matrix.workload }}
@@ -66,9 +63,9 @@ jobs:
           dotnet run run "Host=localhost;Port=2135;Database=/Root/testdb" \
             --prom-pgw http://localhost:9091  \
             --report-period 250 \
-            --time ${{inputs.slo_workload_duration_seconds || 600 }} \
-            --read-rps ${{inputs.slo_workload_read_max_rps || 1000 }} \
-            --write-rps ${{inputs.slo_workload_write_max_rps || 1000 }} \
+            --time 600 \
+            --read-rps ${{matrix.read_rps || 1000 }} \
+            --write-rps ${{matrix.write_rps || 1000 }} \
             --read-timeout 1000 \
             --write-timeout 1000
 

src/EFCore.Ydb/src/Query/Internal/Translators/YdbDAteTimeMemberTranslator.cs renamed to src/EFCore.Ydb/src/Query/Internal/Translators/YdbDateTimeMemberTranslator.cs

@@ -1,4 +1,3 @@
-using System;
 using Microsoft.EntityFrameworkCore.Storage;
 
 namespace EntityFrameworkCore.Ydb.Storage.Internal.Mapping;
@@ -8,9 +7,11 @@ public class YdbDecimalTypeMapping : DecimalTypeMapping
     private const byte DefaultPrecision = 22;
     private const byte DefaultScale = 9;
 
-    public YdbDecimalTypeMapping(Type? type) : this(
+    public new static YdbDecimalTypeMapping Default => new();
+    
+    public YdbDecimalTypeMapping() : this(
         new RelationalTypeMappingParameters(
-            new CoreTypeMappingParameters(type ?? typeof(decimal)),
+            new CoreTypeMappingParameters(typeof(decimal)),
             storeType: "Decimal",
             dbType: System.Data.DbType.Decimal
         )

src/EFCore.Ydb/src/Storage/Internal/Mapping/YdbDecimalTypeMapping.cs

@@ -0,0 +1,21 @@
+using Microsoft.EntityFrameworkCore.Storage;
+
+namespace EntityFrameworkCore.Ydb.Storage.Internal.Mapping;
+
+public class YdbGuidTypeMapping : GuidTypeMapping
+{
+    public new static YdbGuidTypeMapping Default => new();
+
+    private YdbGuidTypeMapping() : base("Uuid", System.Data.DbType.Guid)
+    {
+    }
+
+    protected YdbGuidTypeMapping(RelationalTypeMappingParameters parameters) : base(parameters)
+    {
+    }
+
+    protected override RelationalTypeMapping Clone(RelationalTypeMappingParameters parameters) =>
+        new YdbGuidTypeMapping(parameters);
+
+    protected override string SqlLiteralFormatString => "Uuid('{0}')";
+}

src/EFCore.Ydb/src/Storage/Internal/Mapping/YdbGuidTypeMapping.cs

@@ -8,5 +8,5 @@ public class YdbExecutionStrategy(ExecutionStrategyDependencies dependencies)
     : ExecutionStrategy(dependencies, maxRetryCount: 10, maxRetryDelay: TimeSpan.FromSeconds(10)) // TODO User settings
 {
     protected override bool ShouldRetryOn(Exception exception)
-        => exception is YdbException { IsTransientWhenIdempotent: true };
+        => exception is YdbException { IsTransient: true };
 }

src/EFCore.Ydb/src/Storage/Internal/YdbExecutionStrategy.cs

@@ -30,9 +30,9 @@ RelationalTypeMappingSourceDependencies relationalDependencies
     private static readonly FloatTypeMapping Float = new("Float", DbType.Single);
     private static readonly DoubleTypeMapping Double = new("Double", DbType.Double);
 
-    private static readonly YdbDecimalTypeMapping Decimal = new(typeof(decimal));
+    private static readonly YdbDecimalTypeMapping Decimal = YdbDecimalTypeMapping.Default;
 
-    private static readonly GuidTypeMapping Guid = new("Uuid");
+    private static readonly GuidTypeMapping Guid = YdbGuidTypeMapping.Default;
 
     private static readonly YdbTextTypeMapping Text = YdbTextTypeMapping.Default;
     private static readonly YdbBytesTypeMapping Bytes = YdbBytesTypeMapping.Default;

src/EFCore.Ydb/src/Storage/Internal/YdbTypeMappingSource.cs

@@ -1091,9 +1091,8 @@ public async Task
         _mockStream.Verify(stream => stream.Current, Times.Exactly(7));
 
         _mockStream.Verify(stream => stream.Write(It.Is<FromClient>(msg =>
-            msg.InitRequest != null &&
-            msg.InitRequest.Consumer == "Consumer" &&
-            msg.InitRequest.TopicsReadSettings[0].Path == "/topic")), Times.Exactly(2));
+            msg.InitRequest != null && msg.InitRequest.Consumer == "Consumer" &&
+            msg.InitRequest.TopicsReadSettings[0].Path == "/topic")), Times.Between(2, 3, Range.Inclusive));
         _mockStream.Verify(stream => stream.Write(It.Is<FromClient>(msg =>
             msg.ReadRequest != null && msg.ReadRequest.BytesSize == 100)), Times.Exactly(2));
         _mockStream.Verify(stream => stream.Write(It.Is<FromClient>(msg =>