Skip to content

Commit 370df2c

Browse files
feat: Added Specification tests for DbDataReader
1 parent c352d6d commit 370df2c

File tree

11 files changed

+550
-89
lines changed

11 files changed

+550
-89
lines changed

src/Ydb.Sdk/src/Ado/ThrowHelper.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,9 @@ internal static T ThrowInvalidCast<T>(YdbValue ydbValue)
88
{
99
throw new InvalidCastException($"Field type {ydbValue.TypeId} can't be cast to {typeof(T)} type.");
1010
}
11+
12+
internal static void ThrowIndexOutOfRangeException(int columnCount)
13+
{
14+
throw new IndexOutOfRangeException("Ordinal must be between 0 and " + (columnCount - 1));
15+
}
1116
}

src/Ydb.Sdk/src/Ado/YdbCommand.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,7 @@ public override async Task<int> ExecuteNonQueryAsync(CancellationToken cancellat
5252
{
5353
await using var dataReader = await ExecuteReaderAsync(CommandBehavior.Default, cancellationToken);
5454

55-
var data = await dataReader.ReadAsync(cancellationToken)
56-
? dataReader.IsDBNull(0) ? null : dataReader.GetValue(0)
57-
: null;
55+
var data = await dataReader.ReadAsync(cancellationToken) ? dataReader.GetValue(0) : null;
5856

5957
while (await dataReader.NextResultAsync(cancellationToken))
6058
{

src/Ydb.Sdk/src/Ado/YdbConnection.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ public override string ConnectionString
173173

174174
internal YdbDataReader? LastReader { get; set; }
175175
internal string LastCommand { get; set; } = string.Empty;
176-
internal bool IsBusy => LastReader is { IsClosed: false };
176+
internal bool IsBusy => LastReader is { IsOpen: true };
177177
internal YdbTransaction? CurrentTransaction { get; private set; }
178178

179179
public override string DataSource => string.Empty; // TODO

0 commit comments

Comments
 (0)