fix linter

Author: KirillKurdyukov

src/EfCore.Ydb/src/Diagnostics/Internal/YdbLoggingDefinitions.cs

@@ -2,6 +2,4 @@
 
 namespace EfCore.Ydb.Diagnostics.Internal;
 
-public class YdbLoggingDefinitions : RelationalLoggingDefinitions
-{
-}
+public class YdbLoggingDefinitions : RelationalLoggingDefinitions;

src/EfCore.Ydb/src/Infrastructure/EntityFrameworkYdbServicesBuilder.cs

@@ -8,7 +8,10 @@ namespace EfCore.Ydb.Infrastructure;
 public class EntityFrameworkYdbServicesBuilder(IServiceCollection serviceCollection)
     : EntityFrameworkRelationalServicesBuilder(serviceCollection)
 {
+    // ReSharper disable once CollectionNeverUpdated.Local
+#pragma warning disable CA1859
     private static readonly IDictionary<Type, ServiceCharacteristics> YdbServices
+#pragma warning restore CA1859
         = new Dictionary<Type, ServiceCharacteristics>
         {
             // TODO: Add items if required

src/EfCore.Ydb/src/Migrations/Internal/YdbHistoryRepository.cs

@@ -122,10 +122,11 @@ PRIMARY KEY(name)
                     await Task.Delay(TimeSpan.FromSeconds(timeoutInSeconds / 2), _watchDogToken.Token);
                     await UpdateLock(name, timeoutInSeconds);
                 }
+                // ReSharper disable once FunctionNeverReturns
             })!, _watchDogToken.Token);
         }
 
-        private async Task<bool> UpdateLock(string name, int timeoutInSeconds)
+        private async Task<bool> UpdateLock(string nameLock, int timeoutInSeconds)
         {
             var command = Connection.DbConnection.CreateCommand();
             command.CommandText =
@@ -138,7 +139,7 @@ UPSERT INTO shedlock (name, locked_at, lock_until, locked_by)
                         @locked_by
                         );
                  """;
-            command.Parameters.Add(new YdbParameter("name", DbType.String, name));
+            command.Parameters.Add(new YdbParameter("name", DbType.String, nameLock));
             command.Parameters.Add(new YdbParameter("locked_by", DbType.String, _pid));
 
             try

src/EfCore.Ydb/src/Migrations/YdbMigrationsSqlGenerator.cs

@@ -262,10 +262,7 @@ protected override void EndStatement(
         MigrationCommandListBuilder builder,
         // ReSharper disable once OptionalParameterHierarchyMismatch
         bool suppressTransaction = true
-    )
-    {
-        base.EndStatement(builder, suppressTransaction);
-    }
+    ) => base.EndStatement(builder, suppressTransaction);
 
     private string DelimitIdentifier(string name, string? schema)
         => Dependencies.SqlGenerationHelper.DelimitIdentifier(name, schema);

src/EfCore.Ydb/src/Storage/Internal/YdbRelationalConnection.cs

@@ -17,7 +17,7 @@ protected override DbConnection CreateDbConnection()
         {
             return DataSource.CreateConnection();
         }
-        
+
         var connection = new YdbConnection(GetValidatedConnectionString());
         return connection;
     }

src/EfCore.Ydb/src/Update/Internal/YdbModificationCommandBatchFactory.cs

@@ -12,21 +12,19 @@ namespace EfCore.Ydb.Update.Internal;
 public class YdbModificationCommandBatchFactory : IModificationCommandBatchFactory
 {
     public YdbModificationCommandBatchFactory(ModificationCommandBatchFactoryDependencies dependencies)
-        => Dependencies = dependencies;
+    {
+        Dependencies = dependencies;
+    }
 
     protected virtual ModificationCommandBatchFactoryDependencies Dependencies { get; }
 
     public ModificationCommandBatch Create()
         => new TemporaryStubModificationCommandBatch(Dependencies);
 }
 
-class TemporaryStubModificationCommandBatch : ReaderModificationCommandBatch
+internal class TemporaryStubModificationCommandBatch(ModificationCommandBatchFactoryDependencies dependencies)
+    : ReaderModificationCommandBatch(dependencies, 2000)
 {
-    public TemporaryStubModificationCommandBatch(ModificationCommandBatchFactoryDependencies dependencies)
-        : base(dependencies, 2000)
-    {
-    }
-
     protected override void Consume(RelationalDataReader reader) =>
         ConsumeAsync(reader).ConfigureAwait(false).GetAwaiter().GetResult();
 

src/EfCore.Ydb/test/EfCore.Ydb.FunctionalTests/AllTests/BulkUpdates/NorthwindBulkUpdatesYdbTest.cs

@@ -5,7 +5,7 @@
 namespace EfCore.Ydb.FunctionalTests.AllTests.BulkUpdates;
 
 // TODO: Await Norhhwind
-class NorthwindBulkUpdatesYdbTest(
+internal class NorthwindBulkUpdatesYdbTest(
     NorthwindBulkUpdatesYdbFixture<NoopModelCustomizer> fixture,
     ITestOutputHelper testOutputHelper
 ) : NorthwindBulkUpdatesRelationalTestBase<NorthwindBulkUpdatesYdbFixture<NoopModelCustomizer>>(

src/EfCore.Ydb/test/EfCore.Ydb.FunctionalTests/AllTests/BulkUpdates/TPTInheritanceBulkUpdatesYdbTest.cs

@@ -4,7 +4,7 @@
 namespace EfCore.Ydb.FunctionalTests.AllTests.BulkUpdates;
 
 // TODO: Key columns are not specified :c
-class TptInheritanceBulkUpdatesYdbTest(
+internal class TPTInheritanceBulkUpdatesYdbTest(
     TPTInheritanceBulkUpdatesYdbFixture fixture,
     ITestOutputHelper testOutputHelper
 ) : TPTInheritanceBulkUpdatesTestBase<TPTInheritanceBulkUpdatesYdbFixture>(fixture, testOutputHelper);

src/EfCore.Ydb/test/EfCore.Ydb.FunctionalTests/AllTests/Update/UpdatesYdbTest.cs

@@ -13,7 +13,7 @@ namespace EfCore.Ydb.FunctionalTests.AllTests.Update;
 // Ignore_before_save_property_is_still_generated,
 // SaveChanges_processes_all_tracked_entities.
 // They're failing, but I cannot ignore them because they're not virtual
-class UpdatesYdbTest
+internal class UpdatesYdbTest
     : UpdatesRelationalTestBase<UpdatesYdbTest.UpdatesYdbFixture>
 // , UpdatesTestBase<UpdatesYdbTest.UpdatesYdbFixture>
 {