update CHANGELOG.md + fix lint

Author: LiamHamsters

src/Ydb.Sdk/CHANGELOG.md

@@ -1,3 +1,4 @@
+- Dev: Parameterized Decimal overflow check (precision/scale).
 - Dev: LogLevel `Warning` -> `Debug` on DeleteSession has been `RpcException`.
 
 ## v0.22.0

src/Ydb.Sdk/src/Ado/YdbParameter.cs

@@ -273,7 +273,7 @@ internal TypedValue TypedValue
     private TypedValue Decimal(decimal value)
     {
         var p = Precision == 0 && Scale == 0 ? 22 : Precision;
-        var s = Precision == 0 && Scale == 0 ? 9  : Scale;
+        var s = Precision == 0 && Scale == 0 ? 9 : Scale;
 
         return value.Decimal((byte)p, (byte)s);
     }

src/Ydb.Sdk/src/Ado/YdbType/YdbTypedValueExtensions.cs

@@ -98,15 +98,15 @@ internal static TypedValue Decimal(this decimal value, byte precision, byte scal
 
         var unscaled = new decimal(rb[0], rb[1], rb[2], false, 0);
 
-        int delta = scale - roundedScale;
+        var delta = scale - roundedScale;
         if (delta > 0)
         {
-            for (int i = 0; i < delta; i++)
+            for (var i = 0; i < delta; i++)
                 unscaled *= 10m;
         }
         else if (delta < 0)
         {
-            for (int i = 0; i < -delta; i++)
+            for (var i = 0; i < -delta; i++)
                 unscaled /= 10m;
         }
 

src/Ydb.Sdk/test/Ydb.Sdk.Ado.Tests/YdbParameterTests.cs

@@ -226,18 +226,19 @@ PRIMARY KEY (DecimalField)
 
         await new YdbCommand(ydbConnection) { CommandText = $"DROP TABLE {decimalTableName};" }.ExecuteNonQueryAsync();
     }
-    
+
     [Fact]
     public async Task Decimal_WhenFractionalDigitsExceedScale_Throws()
     {
         await using var ydb = await CreateOpenConnectionAsync();
         var t = $"T_{Random.Shared.Next()}";
-        await new YdbCommand(ydb){ CommandText = $"CREATE TABLE {t}(d Decimal(5,2), PRIMARY KEY(d))" }.ExecuteNonQueryAsync();
+        await new YdbCommand(ydb){ CommandText = $"CREATE TABLE {t}(d Decimal(5,2), PRIMARY KEY(d))" }
+            .ExecuteNonQueryAsync();
 
         var cmd = new YdbCommand(ydb)
         {
             CommandText = $"INSERT INTO {t}(d) VALUES (@d);",
-            Parameters = { new YdbParameter("d", DbType.Decimal, 123.456m){ Precision = 5, Scale = 2 } }
+            Parameters = { new YdbParameter("d", DbType.Decimal, 123.456m) { Precision = 5, Scale = 2 } }
         };
 
         await Assert.ThrowsAsync<OverflowException>(() => cmd.ExecuteNonQueryAsync());
@@ -248,28 +249,30 @@ public async Task Decimal_WhenIntegerDigitsExceedPrecisionMinusScale_Throws()
     {
         await using var ydb = await CreateOpenConnectionAsync();
         var t = $"T_{Random.Shared.Next()}";
-        await new YdbCommand(ydb){ CommandText = $"CREATE TABLE {t}(d Decimal(5,0), PRIMARY KEY(d))" }.ExecuteNonQueryAsync();
+        await new YdbCommand(ydb){ CommandText = $"CREATE TABLE {t}(d Decimal(5,0), PRIMARY KEY(d))" }
+            .ExecuteNonQueryAsync();
 
         var cmd = new YdbCommand(ydb)
         {
             CommandText = $"INSERT INTO {t}(d) VALUES (@d);",
-            Parameters = { new YdbParameter("d", DbType.Decimal, 100000m){ Precision = 5, Scale = 0 } } // 6 целых цифр
+            Parameters = { new YdbParameter("d", DbType.Decimal, 100000m) { Precision = 5, Scale = 0 } }
         };
 
         await Assert.ThrowsAsync<OverflowException>(() => cmd.ExecuteNonQueryAsync());
     }
-    
+
     [Fact]
     public async Task Decimal_WhenScaleGreaterThanPrecision_ThrowsByMathNotByIf()
     {
         await using var ydb = await CreateOpenConnectionAsync();
         var t = $"T_{Random.Shared.Next()}";
-        await new YdbCommand(ydb){ CommandText = $"CREATE TABLE {t}(d Decimal(5,4), PRIMARY KEY(d))" }.ExecuteNonQueryAsync();
+        await new YdbCommand(ydb){ CommandText = $"CREATE TABLE {t}(d Decimal(5,4), PRIMARY KEY(d))" }
+            .ExecuteNonQueryAsync();
 
         var cmd = new YdbCommand(ydb)
         {
             CommandText = $"INSERT INTO {t}(d) VALUES (@d);",
-            Parameters = { new YdbParameter("d", DbType.Decimal, 0.0m){ Precision = 1, Scale = 2 } }
+            Parameters = { new YdbParameter("d", DbType.Decimal, 0.0m) { Precision = 1, Scale = 2 } }
         };
 
         await Assert.ThrowsAnyAsync<Exception>(() => cmd.ExecuteNonQueryAsync());
@@ -280,14 +283,15 @@ public async Task Decimal_WhenYdbReturnsDecimal35_0_OverflowsDotNetDecimal()
     {
         await using var ydb = await CreateOpenConnectionAsync();
         var t = $"T_{Random.Shared.Next()}";
-        await new YdbCommand(ydb){ CommandText = $"CREATE TABLE {t}(d Decimal(35,0), PRIMARY KEY(d))" }.ExecuteNonQueryAsync();
+        await new YdbCommand(ydb){ CommandText = $"CREATE TABLE {t}(d Decimal(35,0), PRIMARY KEY(d))" }
+            .ExecuteNonQueryAsync();
 
         await new YdbCommand(ydb)
         {
             CommandText = $@"INSERT INTO {t}(d) VALUES (CAST('10000000000000000000000000000000000' AS Decimal(35,0)));"
         }.ExecuteNonQueryAsync();
 
-        var select = new YdbCommand(ydb){ CommandText = $"SELECT d FROM {t};" };
+        var select = new YdbCommand(ydb) { CommandText = $"SELECT d FROM {t};" };
 
         await Assert.ThrowsAsync<OverflowException>(() => select.ExecuteScalarAsync());
     }