Skip to content

Commit 4795225

Browse files
fixes
1 parent 5d5ad0c commit 4795225

File tree

4 files changed

+11
-3
lines changed

4 files changed

+11
-3
lines changed

.github/workflows/tests.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ jobs:
181181
uses: actions/setup-dotnet@v4
182182
with:
183183
dotnet-version: ${{ matrix.dotnet-version }}
184-
- name: Run ADO.NET examples
184+
- name: Run ADO.NET example
185185
run: |
186186
docker cp ydb-local:/ydb_certs/ca.pem ~/
187187
cd ./examples/src/AdoNet
@@ -190,3 +190,7 @@ jobs:
190190
run: |
191191
cd ./examples/src/DapperExample
192192
dotnet run
193+
- name: YDB Topic example
194+
run: |
195+
cd ./examples/src/Topic
196+
dotnet run

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
- Fixed Writer: possible creation of a session after `DisposeAsync()`, which this could happen when there are canceled tasks in `InFlightMessages`.
2+
- Dev: `Writer.MoveNext()` changed exception on cancelToken from `WriterException` to `TaskCanceledException`.
3+
- Dev: changed log level from `Warning` to `Information` in `(Reader / Writer).Initialize()` when it is disposed.
4+
15
## v0.15.0
26
- Dev: added `ValueTask<string?> GetAuthInfoAsync()` in ICredentialProvider.
37
- Feat: `Writer.DisposeAsync()` waits for all in-flight messages to complete.

examples/src/Topic/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ await topicClient.CreateTopic(new CreateTopicSettings
6363
var message = await reader.ReadAsync(readerCts.Token);
6464

6565
logger.LogInformation("Received message: [{MessageData}]", message.Data);
66-
66+
6767
try
6868
{
6969
await message.CommitAsync();

src/Ydb.Sdk/src/Services/Topic/Reader/Reader.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ private async Task Initialize()
9696
{
9797
if (_disposeCts.IsCancellationRequested)
9898
{
99-
_logger.LogInformation("Reader writer is canceled because it has been disposed");
99+
_logger.LogInformation("Initialize reader is canceled because it has been disposed");
100100

101101
return;
102102
}

0 commit comments

Comments
 (0)