fix linter

Author: KirillKurdyukov

src/EfCore.Ydb/src/Storage/Internal/Mapping/YdbJsonTypeMapping.cs

@@ -23,14 +23,14 @@ protected YdbJsonTypeMapping(RelationalTypeMappingParameters parameters) : base(
     private static readonly MethodInfo GetStringMethod
         = typeof(DbDataReader).GetRuntimeMethod(nameof(DbDataReader.GetString), [typeof(int)])!;
 
-    private static readonly PropertyInfo Utf8Property
-        = typeof(Encoding).GetProperty(nameof(Encoding.UTF8))!;
+    private static readonly PropertyInfo? Utf8Property
+        = typeof(Encoding).GetProperty(nameof(Encoding.UTF8));
 
-    private static readonly MethodInfo EncodingGetBytesMethod
-        = typeof(Encoding).GetMethod(nameof(Encoding.GetBytes), [typeof(string)])!;
+    private static readonly MethodInfo? EncodingGetBytesMethod
+        = typeof(Encoding).GetMethod(nameof(Encoding.GetBytes), [typeof(string)]);
 
-    private static readonly ConstructorInfo MemoryStreamConstructor
-        = typeof(MemoryStream).GetConstructor([typeof(byte[])])!;
+    private static readonly ConstructorInfo? MemoryStreamConstructor
+        = typeof(MemoryStream).GetConstructor([typeof(byte[])]);
 
     protected override RelationalTypeMapping Clone(RelationalTypeMappingParameters parameters)
         => new YdbJsonTypeMapping(parameters);
@@ -66,10 +66,10 @@ protected override string GenerateNonNullSqlLiteral(object value)
     }
 
     public override Expression CustomizeDataReaderExpression(Expression expression) => Expression.New(
-        MemoryStreamConstructor,
+        MemoryStreamConstructor ?? throw new Exception(),
         Expression.Call(
-            Expression.Property(null, Utf8Property),
-            EncodingGetBytesMethod,
+            Expression.Property(null, Utf8Property ?? throw new Exception()),
+            EncodingGetBytesMethod ?? throw new Exception(),
             expression)
     );
 }

src/EfCore.Ydb/src/Utilities/ArrayUtil.cs

@@ -2,19 +2,11 @@ namespace EfCore.Ydb.Utilities;
 
 internal static class ArrayUtil
 {
-    internal static readonly bool[][] TrueArrays =
-    [
-        [],
-        [true],
-        [true, true],
-        [true, true, true]
-    ];
-
     internal static readonly bool[][] FalseArrays =
-    [
-        [],
-        [false],
-        [false, false],
-        [false, false, false]
-    ];
+    {
+        new bool[] { },
+        new bool[] { false },
+        new bool[] { false, false },
+        new bool[] { false, false, false }
+    };
 }

src/EfCore.Ydb/test/EfCore.Ydb.FunctionalTests/AllTests/Update/UpdatesYdbTest.cs

@@ -132,14 +132,12 @@ public override Task Save_replaced_principal()
             base.Save_replaced_principal);
 
     private async Task TestIgnoringBase(
-        Func<Task> baseTest,
-        params string[] expectedSql
-    ) => await TestIgnoringBase(_ => baseTest(), false, expectedSql);
+        Func<Task> baseTest
+    ) => await TestIgnoringBase(_ => baseTest(), false);
 
     private async Task TestIgnoringBase(
         Func<bool, Task> baseTest,
-        bool async,
-        params string[] expectedSql
+        bool async
     )
     {
         try
@@ -151,16 +149,16 @@ params string[] expectedSql
             // if (expectedSql.Length == 0) throw;
             var actual = Fixture.TestSqlLoggerFactory.SqlStatements;
 
-            var comms = new StringBuilder();
+            var commas = new StringBuilder();
             foreach (var str in actual)
             {
-                comms
+                commas
                     .Append(">>>\n")
                     .Append(str)
                     .Append("\n<<<\n");
             }
 
-            throw new AggregateException(new Exception(comms.ToString()), e);
+            throw new AggregateException(new Exception(commas.ToString()), e);
         }
     }
 }

src/EfCore.Ydb/test/EfCore.Ydb.FunctionalTests/TestUtilities/YdbTestStore.cs

@@ -8,24 +8,14 @@
 
 namespace EfCore.Ydb.FunctionalTests.TestUtilities;
 
-public class YdbTestStore : RelationalTestStore
+public class YdbTestStore(
+    string name,
+    string? scriptPath = null,
+    string? additionalSql = null,
+    bool shared = true
+) : RelationalTestStore(name, shared, CreateConnection())
 {
     private const int CommandTimeout = 600;
-    private readonly string? _scriptPath;
-    private readonly string? _additionalSql;
-
-    public YdbTestStore(
-        string name,
-        string? scriptPath = null,
-        string? additionalSql = null,
-        string? connectionStringOptions = null,
-        bool shared = true,
-        bool useConnectionString = false
-    ) : base(name, shared, CreateConnection())
-    {
-        _scriptPath = scriptPath;
-        _additionalSql = additionalSql;
-    }
 
     public static YdbTestStore GetOrCreate(
         string name,
@@ -42,13 +32,13 @@ protected override async Task InitializeAsync(
         Func<DbContext, Task>? clean
     )
     {
-        if (_scriptPath is not null)
+        if (scriptPath is not null)
         {
-            await ExecuteScript(_scriptPath);
+            await ExecuteScript(scriptPath);
 
-            if (_additionalSql is not null)
+            if (additionalSql is not null)
             {
-                await ExecuteAsync(Connection, command => command.ExecuteNonQueryAsync(), _additionalSql);
+                await ExecuteAsync(Connection, command => command.ExecuteNonQueryAsync(), additionalSql);
             }
         }
         else
@@ -58,9 +48,9 @@ protected override async Task InitializeAsync(
             await CleanAsync(context);
             await context.Database.EnsureCreatedAsync();
 
-            if (_additionalSql is not null)
+            if (additionalSql is not null)
             {
-                await ExecuteAsync(Connection, command => command.ExecuteNonQueryAsync(), _additionalSql);
+                await ExecuteAsync(Connection, command => command.ExecuteNonQueryAsync(), additionalSql);
             }
 
             if (seed is not null)

src/EfCore.Ydb/test/EfCore.Ydb.FunctionalTests/TestUtilities/YdbTestStoreFactory.cs

@@ -4,23 +4,17 @@
 
 namespace EfCore.Ydb.FunctionalTests.TestUtilities;
 
-public class YdbTestStoreFactory(
-    string? additionalSql = null,
-    string? connectionStringOptions = null,
-    bool useConnectionString = false
-) : RelationalTestStoreFactory
+public class YdbTestStoreFactory(string? additionalSql = null) : RelationalTestStoreFactory
 {
     public static YdbTestStoreFactory Instance { get; } = new();
 
     private readonly string? _scriptPath = null;
 
     public override TestStore Create(string storeName) =>
-        new YdbTestStore(storeName, _scriptPath, additionalSql, connectionStringOptions, shared: false,
-            useConnectionString);
+        new YdbTestStore(storeName, _scriptPath, additionalSql, shared: false);
 
     public override TestStore GetOrCreate(string storeName)
-        => new YdbTestStore(storeName, _scriptPath, additionalSql, connectionStringOptions, shared: true,
-            useConnectionString);
+        => new YdbTestStore(storeName, _scriptPath, additionalSql, shared: true);
 
     public override IServiceCollection AddProviderServices(IServiceCollection serviceCollection)
         => serviceCollection.AddEntityFrameworkYdb();