fix race condition with DisposeAsync & ReleaseLease & TryAcquireLease

KirillKurdyukov · KirillKurdyukov · commit 6bb7655d7b98 · 2025-10-09T20:29:42.000+03:00
diff --git a/src/Ydb.Sdk/src/Ado/Session/ImplicitSessionSource.cs b/src/Ydb.Sdk/src/Ado/Session/ImplicitSessionSource.cs
@@ -42,7 +42,9 @@ private bool TryAcquireLease()
 
     internal void ReleaseLease()
     {
-        if (Interlocked.Decrement(ref _activeLeaseCount) == 0 && Volatile.Read(ref _isDisposed) == 1)
+        Interlocked.Decrement(ref _activeLeaseCount);
+        
+        if (Volatile.Read(ref _isDisposed) == 1 && _activeLeaseCount == 0)
             _drainedTcs.TrySetResult();
     }
 

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,9 @@ private bool TryAcquireLease()`
`42`	`42`
`43`	`43`	`internal void ReleaseLease()`
`44`	`44`	`{`
`45`		`- if (Interlocked.Decrement(ref _activeLeaseCount) == 0 && Volatile.Read(ref _isDisposed) == 1)`
	`45`	`+ Interlocked.Decrement(ref _activeLeaseCount);`
	`46`	`+`
	`47`	`+ if (Volatile.Read(ref _isDisposed) == 1 && _activeLeaseCount == 0)`
`46`	`48`	`_drainedTcs.TrySetResult();`
`47`	`49`	`}`
`48`	`50`