next patch

Author: KirillKurdyukov

src/EFCore.Ydb/src/Extensions/YdbServiceCollectionExtensions.cs

@@ -16,7 +16,6 @@
 using Microsoft.EntityFrameworkCore.Query;
 using Microsoft.EntityFrameworkCore.Storage;
 using Microsoft.EntityFrameworkCore.Update;
-using Microsoft.EntityFrameworkCore.ValueGeneration;
 using Microsoft.Extensions.DependencyInjection;
 
 namespace EntityFrameworkCore.Ydb.Extensions;

src/EFCore.Ydb/src/Query/Internal/YdbMethodCallTranslatorProvider.cs

@@ -1,5 +1,4 @@
 using EntityFrameworkCore.Ydb.Query.Internal.Translators;
-using EntityFrameworkCore.Ydb.Storage.Internal;
 using Microsoft.EntityFrameworkCore.Query;
 
 namespace EntityFrameworkCore.Ydb.Query.Internal;
@@ -15,7 +14,6 @@ public YdbMethodCallTranslatorProvider(RelationalMethodCallTranslatorProviderDep
             [
                 new YdbDateTimeMethodTranslator(sqlExpressionFactory),
                 new YdbMathTranslator(sqlExpressionFactory),
-                new YdbMathTranslator(sqlExpressionFactory),
                 new YdbByteArrayMethodTranslator(sqlExpressionFactory),
             ]
         );

src/EFCore.Ydb/src/Query/Internal/YdbQueryableMethodTranslatingExpressionVisitor.cs

@@ -1,4 +1,3 @@
-using System.Linq.Expressions;
 using EntityFrameworkCore.Ydb.Storage.Internal;
 using Microsoft.EntityFrameworkCore.Query;
 

src/EFCore.Ydb/src/Query/Internal/YdbSqlAliasManager.cs

@@ -1,6 +1,5 @@
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
-using System.Linq;
 using System.Linq.Expressions;
 using Microsoft.EntityFrameworkCore.Query;
 using Microsoft.EntityFrameworkCore.Query.SqlExpressions;
@@ -77,10 +76,7 @@ private Expression VisitLeftJoin(LeftJoinExpression leftJoinExpression)
                 leftJoinExpression.JoinPredicate
             );
 
-        private Expression VisitTable(TableExpressionBase tableExpression)
-        {
-            return tableExpression;
-        }
+        private static Expression VisitTable(TableExpressionBase tableExpression) => tableExpression;
 
         private IReadOnlyList<ProjectionExpression> AdjustAliases(
             IReadOnlyList<ProjectionExpression> projections,

src/EFCore.Ydb/src/Storage/Internal/Mapping/YdbDecimalTypeMapping.cs

@@ -27,5 +27,5 @@ protected override RelationalTypeMapping Clone(RelationalTypeMappingParameters p
 
     protected override string ProcessStoreType(
         RelationalTypeMappingParameters parameters, string storeType, string storeTypeNameBase
-    ) => $"Decimal({parameters.Precision ?? DefaultPrecision}, {parameters.Scale ?? DefaultScale})";
+    ) => $"{storeType}({parameters.Precision ?? DefaultPrecision}, {parameters.Scale ?? DefaultScale})";
 }

src/Ydb.Sdk/src/Ado/YdbCommand.cs

@@ -213,8 +213,7 @@ protected override async Task<DbDataReader> ExecuteDbDataReaderAsync(CommandBeha
         var ydbDataReader = await YdbDataReader.CreateYdbDataReader(
             await YdbConnection.Session.ExecuteQuery(
                 preparedSql.ToString(), ydbParameters, execSettings, transaction?.TransactionControl
-            ),
-            YdbConnection.Session.OnStatus, transaction
+            ), YdbConnection.OnStatus, transaction
         );
 
         YdbConnection.LastReader = ydbDataReader;

src/Ydb.Sdk/src/Ado/YdbConnection.cs

@@ -160,6 +160,16 @@ public override string ConnectionString
 
     private ConnectionState ConnectionState { get; set; } = ConnectionState.Closed; // Invoke AsyncOpen()
 
+    internal void OnStatus(Status status)
+    {
+        _session.OnStatus(status);
+
+        if (!_session.IsActive)
+        {
+            ConnectionState = ConnectionState.Broken;
+        }
+    }
+
     internal YdbDataReader? LastReader { get; set; }
     internal string LastCommand { get; set; } = string.Empty;
     internal bool IsBusy => LastReader is { IsOpen: true };

src/Ydb.Sdk/src/Ado/YdbSchema.cs

@@ -65,7 +65,7 @@ internal static async Task<YdbTable> DescribeTable(
 
             if (status.IsNotSuccess)
             {
-                ydbConnection.Session.OnStatus(status);
+                ydbConnection.OnStatus(status);
 
                 throw new YdbException(status);
             }
@@ -76,7 +76,7 @@ internal static async Task<YdbTable> DescribeTable(
         }
         catch (Driver.TransportException e)
         {
-            ydbConnection.Session.OnStatus(e.Status);
+            ydbConnection.OnStatus(e.Status);
 
             throw new YdbException("Transport error on DescribeTable", e);
         }

src/Ydb.Sdk/src/Ado/YdbTransaction.cs

@@ -99,7 +99,7 @@ private async Task FinishTransaction(Func<string, Task<Status>> finishMethod)
             {
                 Failed = true;
 
-                DbConnection.Session.OnStatus(status);
+                DbConnection.OnStatus(status);
 
                 throw new YdbException(status);
             }
@@ -108,7 +108,7 @@ private async Task FinishTransaction(Func<string, Task<Status>> finishMethod)
         {
             Failed = true;
 
-            DbConnection.Session.OnStatus(e.Status);
+            DbConnection.OnStatus(e.Status);
 
             throw new YdbException(e.Status);
         }