Bug: StaticCredentialsProvider,StatusCode="Unauthenticated" bug (#91)

* Make ClientBase abstract class

* Bug: StaticCredentialsProvider,StatusCode="Unauthenticated" bug

* fix linter

* fix linter

* delete empty auth example

* fix commit

* fix semantic

* fix

Author: KirillKurdyukov

src/Ydb.Sdk/src/Auth/Anonymous.cs renamed to src/Ydb.Sdk/src/Auth/AnonymousProvider.cs

@@ -3,4 +3,9 @@
 public interface ICredentialsProvider
 {
     string? GetAuthInfo();
+
+    Task ProvideConfig(DriverConfig driverConfig)
+    {
+        return Task.CompletedTask;
+    }
 }

src/Ydb.Sdk/src/Auth/Auth.cs

@@ -5,14 +5,12 @@
 
 namespace Ydb.Sdk.Auth;
 
-public class StaticCredentialsProvider : ICredentialsProvider, IUseDriverConfig
+public class StaticCredentialsProvider : ICredentialsProvider
 {
     private readonly ILogger _logger;
     private readonly string _user;
     private readonly string? _password;
 
-    private Driver? _driver;
-
     public int MaxRetries = 5;
 
     private readonly object _lock = new();
@@ -22,6 +20,8 @@ public class StaticCredentialsProvider : ICredentialsProvider, IUseDriverConfig
 
     public float RefreshRatio = .1f;
 
+    private AuthClient? _authClient;
+
     /// <summary>
     /// 
     /// </summary>
@@ -36,7 +36,7 @@ public StaticCredentialsProvider(string user, string? password, ILoggerFactory?
         _logger = loggerFactory.CreateLogger<StaticCredentialsProvider>();
     }
 
-    private async Task Initialize()
+    private async Task UpdateToken()
     {
         _token = await ReceiveToken();
     }
@@ -53,7 +53,7 @@ public string GetAuthInfo()
                 _logger.LogWarning(
                     "Blocking for initial token acquirement, please use explicit Initialize async method.");
 
-                Initialize().Wait();
+                UpdateToken().Wait();
 
                 return _token!.Token;
             }
@@ -66,7 +66,7 @@ public string GetAuthInfo()
                 if (!_token!.IsExpired()) return _token.Token;
                 _logger.LogWarning("Blocking on expired token.");
 
-                _token = ReceiveToken().Result;
+                UpdateToken().Wait();
 
                 return _token.Token;
             }
@@ -134,37 +134,29 @@ private async Task<TokenData> ReceiveToken()
 
     private async Task<TokenData> FetchToken()
     {
-        if (_driver is null)
+        if (_authClient is null)
         {
             _logger.LogError("Driver in for static auth not provided");
             throw new NullReferenceException();
         }
 
-        var client = new AuthClient(_driver);
-        var loginResponse = await client.Login(_user, _password);
+        var loginResponse = await _authClient!.Login(_user, _password);
         if (loginResponse.Status.StatusCode == StatusCode.Unauthorized)
         {
             throw new InvalidCredentialsException(Issue.IssuesToString(loginResponse.Status.Issues));
         }
 
         loginResponse.Status.EnsureSuccess();
         var token = loginResponse.Result.Token;
-        var jwt = new JwtSecurityToken(token);
-        return new TokenData(token, jwt.ValidTo, RefreshRatio);
+
+        return new TokenData(token, new JwtSecurityToken(token).ValidTo, RefreshRatio);
     }
 
     public async Task ProvideConfig(DriverConfig driverConfig)
     {
-        _driver = await Driver.CreateInitialized(
-            new DriverConfig(
-                driverConfig.Endpoint,
-                driverConfig.Database,
-                new AnonymousProvider(),
-                driverConfig.DefaultTransportTimeout,
-                driverConfig.DefaultStreamingTransportTimeout,
-                driverConfig.CustomServerCertificate));
-
-        await Initialize();
+        _authClient = new AuthClient(driverConfig, _logger);
+
+        await UpdateToken();
     }
 
     private class TokenData
@@ -207,3 +199,10 @@ public bool IsRefreshNeeded()
         }
     }
 }
+
+public class InvalidCredentialsException : Exception
+{
+    public InvalidCredentialsException(string message) : base(message)
+    {
+    }
+}

src/Ydb.Sdk/src/Auth/ICredentialsProvider.cs

@@ -4,7 +4,6 @@
 using Microsoft.Extensions.Logging.Abstractions;
 using Ydb.Discovery;
 using Ydb.Discovery.V1;
-using Ydb.Sdk.Auth;
 
 namespace Ydb.Sdk;
 
@@ -70,11 +69,7 @@ public ValueTask DisposeAsync()
 
     public async Task Initialize()
     {
-        if (_config.Credentials is IUseDriverConfig useDriverConfig)
-        {
-            await useDriverConfig.ProvideConfig(_config);
-            _logger.LogInformation("DriverConfig provided to IUseDriverConfig interface");
-        }
+        await _config.Credentials.ProvideConfig(_config);
 
         _logger.LogInformation("Started initial endpoint discovery");
 

src/Ydb.Sdk/src/Auth/IUseDriverConfig.cs

@@ -1,11 +1,89 @@
+using Microsoft.Extensions.Logging;
+using Ydb.Auth;
+using Ydb.Auth.V1;
+using Ydb.Sdk.Client;
+using Ydb.Sdk.Services.Operations;
+using Ydb.Sdk.Transport;
+
 namespace Ydb.Sdk.Services.Auth;
 
-public partial class AuthClient
+internal class AuthClient
 {
-    private readonly Driver _driver;
+    private readonly DriverConfig _config;
+    private readonly ILogger _logger;
+
+    public AuthClient(DriverConfig config, ILogger logger)
+    {
+        _config = config;
+        _logger = logger;
+    }
 
-    public AuthClient(Driver driver)
+    public async Task<LoginResponse> Login(string user, string? password, LoginSettings? settings = null)
     {
-        _driver = driver;
+        settings ??= new LoginSettings();
+        var request = new LoginRequest
+        {
+            OperationParams = settings.MakeOperationParams(),
+            User = user
+        };
+
+        if (password is not null)
+        {
+            request.Password = password;
+        }
+
+        try
+        {
+            await using var transport = new AuthGrpcChannelTransport(_config, _logger);
+
+            var response = await transport.UnaryCall(
+                method: AuthService.LoginMethod,
+                request: request,
+                settings: settings
+            );
+
+            var status = response.Operation.TryUnpack(out LoginResult? resultProto);
+
+            LoginResponse.ResultData? result = null;
+
+            if (status.IsSuccess && resultProto is not null)
+            {
+                result = LoginResponse.ResultData.FromProto(resultProto);
+            }
+
+            return new LoginResponse(status, result);
+        }
+        catch (Driver.TransportException e)
+        {
+            return new LoginResponse(e.Status);
+        }
+    }
+}
+
+public class LoginSettings : OperationRequestSettings
+{
+}
+
+public class LoginResponse : ResponseWithResultBase<LoginResponse.ResultData>
+{
+    internal LoginResponse(Status status, ResultData? result = null) : base(status, result)
+    {
+    }
+
+    public class ResultData
+    {
+        public string Token { get; }
+
+        private ResultData(string token)
+        {
+            Token = token;
+        }
+
+
+        internal static ResultData FromProto(LoginResult resultProto)
+        {
+            var token = resultProto.Token;
+            return new ResultData(token);
+        }
     }
 }

src/Ydb.Sdk/src/Auth/StaticCredentialsProvider.cs

@@ -4,11 +4,11 @@
 
 namespace Ydb.Sdk.Transport;
 
-internal class FixedGrpcChannelTransport : GrpcTransport
+internal class AuthGrpcChannelTransport : GrpcTransport
 {
     private readonly GrpcChannel _channel;
 
-    public FixedGrpcChannelTransport(
+    public AuthGrpcChannelTransport(
         DriverConfig driverConfig,
         ILogger logger
     ) : base(