Skip to content

Commit 860ac94

Browse files
last fixes
1 parent ff916aa commit 860ac94

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

src/Ydb.Sdk/src/Ado/Session/PoolingSessionSource.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -157,9 +157,6 @@ private async ValueTask<ISession> RentAsync(CancellationToken cancellationToken)
157157

158158
try
159159
{
160-
if (IsDisposed)
161-
throw new YdbException("Session Source is disposed.");
162-
163160
var session = _sessionFactory.NewSession(this);
164161
await session.Open(cancellationToken);
165162

src/Ydb.Sdk/test/Ydb.Sdk.Ado.Tests/Session/PoolingSessionSourceMockTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ public async Task StressTest_HighContention_OpenClose()
263263
{
264264
IsBroken = sessionNum =>
265265
{
266-
var isBroken = Random.Shared.NextDouble() < 0.05;
266+
var isBroken = Random.Shared.NextDouble() < 0.2;
267267
sessionIdIsBroken[sessionNum] = isBroken;
268268
return isBroken;
269269
},
@@ -418,7 +418,7 @@ public MockPoolingSession NewSession(PoolingSessionSource<MockPoolingSession> so
418418

419419
return Task.CompletedTask;
420420
},
421-
() => IsBroken(_numSession),
421+
sessionNum => IsBroken(sessionNum),
422422
Interlocked.Increment(ref _sessionOpened)
423423
);
424424

@@ -429,13 +429,13 @@ internal class MockPoolingSession(
429429
PoolingSessionSource<MockPoolingSession> source,
430430
Func<int, Task> mockOpen,
431431
Func<Task> mockDeleteSession,
432-
Func<bool> mockIsBroken,
432+
Func<int, bool> mockIsBroken,
433433
int sessionNum
434434
) : PoolingSessionBase<MockPoolingSession>(source)
435435
{
436436
public int SessionId => sessionNum;
437437
public override IDriver Driver => null!;
438-
public override bool IsBroken => mockIsBroken();
438+
public override bool IsBroken => mockIsBroken(sessionNum);
439439

440440
internal override Task Open(CancellationToken cancellationToken) => mockOpen(sessionNum);
441441
internal override Task DeleteSession() => mockDeleteSession();

src/Ydb.Sdk/test/Ydb.Sdk.Ado.Tests/YdbDataSourceTests.cs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,18 +28,21 @@ public async Task OpenConnectionAsync_WhenMaxSessionPool10_ReturnOpenConnection(
2828
[Fact]
2929
public void CreateCommand_FromDataSource_ReturnDbCommand()
3030
{
31+
var dataSource = new YdbDataSource(ConnectionString + ";MaxSessionPool=5");
3132
for (var i = 0; i < SelectedCount; i++)
3233
{
33-
using var command = _dataSource.CreateCommand("SELECT 1;");
34+
using var command = dataSource.CreateCommand("SELECT 1;");
3435
Assert.Equal(1, command.ExecuteScalar());
3536
}
3637

37-
_dataSource.Dispose();
38+
dataSource.Dispose();
3839
for (var i = 0; i < SelectedCount; i++)
3940
{
40-
using var command = _dataSource.CreateCommand("SELECT 1;");
41+
using var command = dataSource.CreateCommand("SELECT 1;");
4142
Assert.Equal(1, command.ExecuteScalar());
4243
}
44+
45+
dataSource.Dispose();
4346
}
4447

4548
[Fact]

0 commit comments

Comments
 (0)