fix

Author: KirillKurdyukov

src/EFCore.Ydb/src/Query/Internal/YdbSqlExpressionFactory.cs

@@ -1,7 +1,4 @@
-using System;
-using System.Data;
 using System.Diagnostics.CodeAnalysis;
-using EntityFrameworkCore.Ydb.Storage.Internal.Mapping;
 using Microsoft.EntityFrameworkCore.Query;
 using Microsoft.EntityFrameworkCore.Query.SqlExpressions;
 using Microsoft.EntityFrameworkCore.Storage;
@@ -13,32 +10,4 @@ public class YdbSqlExpressionFactory(SqlExpressionFactoryDependencies dependenci
     [return: NotNullIfNotNull("sqlExpression")]
     public override SqlExpression? ApplyTypeMapping(SqlExpression? sqlExpression, RelationalTypeMapping? typeMapping) =>
         base.ApplyTypeMapping(sqlExpression, typeMapping);
-
-    public override SqlExpression Coalesce(SqlExpression left, SqlExpression right,
-        RelationalTypeMapping? typeMapping = null)
-    {
-        // For .Sum(x => x.Decimal) EF generates coalesce(sum(x.Decimal), 0.0)) because SUM must have value
-        if (left is SqlFunctionExpression funcExpression
-            &&
-            right is SqlConstantExpression { TypeMapping: not null } constExpression
-            &&
-            funcExpression.Name.Equals("SUM", StringComparison.OrdinalIgnoreCase)
-            &&
-            funcExpression.Arguments != null
-            &&
-            constExpression.TypeMapping.DbType == DbType.Decimal
-            &&
-            constExpression.Value != null)
-        {
-            // get column expression for SUM function expression
-            var columnExpression = funcExpression.Arguments[0] as ColumnExpression;
-
-            var correctRight = new SqlConstantExpression(constExpression.Value,
-                YdbDecimalTypeMapping.CreateMaxPrecision(columnExpression?.TypeMapping?.Scale));
-
-            return base.Coalesce(left, correctRight, typeMapping);
-        }
-
-        return base.Coalesce(left, right, typeMapping);
-    }
 }

src/EFCore.Ydb/src/Storage/Internal/Mapping/YdbDecimalTypeMapping.cs

@@ -7,20 +7,9 @@ public class YdbDecimalTypeMapping : DecimalTypeMapping
 {
     private const byte DefaultPrecision = 22;
     private const byte DefaultScale = 9;
-    private const byte MaxPrecision = 35;
 
     public new static YdbDecimalTypeMapping Default => new();
 
-    public static YdbDecimalTypeMapping CreateMaxPrecision(int? scale) => new(
-        new RelationalTypeMappingParameters(
-            new CoreTypeMappingParameters(typeof(decimal)),
-            storeType: "Decimal",
-            dbType: System.Data.DbType.Decimal,
-            precision: MaxPrecision,
-            scale: scale ?? DefaultScale
-        )
-    );
-
     private YdbDecimalTypeMapping() : this(
         new RelationalTypeMappingParameters(
             new CoreTypeMappingParameters(typeof(decimal)),

src/EFCore.Ydb/test/EntityFrameworkCore.Ydb.FunctionalTests/Query/DecimalParameterizedYdbTest.cs

@@ -12,6 +12,7 @@ private static DbContextOptions<ParametricDecimalContext> BuildOptions() =>
         new DbContextOptionsBuilder<ParametricDecimalContext>()
             .UseYdb("Host=localhost;Port=2136")
             .EnableServiceProviderCaching(false)
+            .LogTo(Console.WriteLine)
             .Options;
 
     public static TheoryData<int, int, decimal> SuccessCases => new()
@@ -99,7 +100,7 @@ public async Task Should_SumDecimal_When_ValueFitsPrecisionAndScale(int p, int s
             for (var i = 0; i < multiplier; i++) 
                 ctx.Add(new ParamItem { Price = value });
             await ctx.SaveChangesAsync();
-            var got = await ctx.Items.SumAsync(x => x.Price);
+            var got = await ctx.Items.Select(x => x.Price).SumAsync();
 
             Assert.Equal(value * multiplier, got);