fix leak of connections

Author: KirillKurdyukov

src/Ydb.Sdk/tests/Ado/Specification/YdbFactoryFixture.cs

@@ -8,5 +8,5 @@ public class YdbFactoryFixture : IDbFactoryFixture
 {
     public DbProviderFactory Factory => YdbProviderFactory.Instance;
 
-    public string ConnectionString => "Host=localhost;Port=2136;Database=/local";
+    public string ConnectionString => "Host=localhost;Port=2136;Database=local;MaxSessionPool=10";
 }

src/Ydb.Sdk/tests/Ado/YdbAdoUserPasswordTests.cs

@@ -14,8 +14,7 @@ public YdbAdoUserPasswordTests(YdbFactoryFixture fixture) : base(fixture)
     [Fact]
     public async Task Authentication_WhenUserAndPassword_ReturnValidConnection()
     {
-        await using var connection = new YdbConnection(Fixture.ConnectionString);
-        await connection.OpenAsync();
+        await using var connection = await CreateOpenConnectionAsync();
         var ydbCommand = connection.CreateCommand();
         var kurdyukovkirya = "kurdyukovkirya" + Random.Shared.Next();
         ydbCommand.CommandText = $"CREATE USER {kurdyukovkirya} PASSWORD 'password'";
@@ -29,8 +28,7 @@ public async Task Authentication_WhenUserAndPassword_ReturnValidConnection()
         ydbCommand.CommandText = "SELECT 1 + 2";
         Assert.Equal(3, await ydbCommand.ExecuteScalarAsync());
 
-        await using var newConnection = new YdbConnection(Fixture.ConnectionString);
-        await newConnection.OpenAsync();
+        await using var newConnection = await CreateOpenConnectionAsync();
         ydbCommand = newConnection.CreateCommand();
         ydbCommand.CommandText = $"DROP USER {kurdyukovkirya};";
         await ydbCommand.ExecuteNonQueryAsync();
@@ -39,8 +37,7 @@ public async Task Authentication_WhenUserAndPassword_ReturnValidConnection()
     [Fact]
     public async Task ExecuteNonQueryAsync_WhenCreateUser_ReturnEmptyResultSet()
     {
-        await using var connection = new YdbConnection(Fixture.ConnectionString);
-        await connection.OpenAsync();
+        await using var connection = await CreateOpenConnectionAsync();
         var dbCommand = connection.CreateCommand();
         var user = "user" + Random.Shared.Next();
         dbCommand.CommandText = $"CREATE USER {user} PASSWORD '123qweqwe'";

src/Ydb.Sdk/tests/Ado/YdbConnectionTests.cs

@@ -7,8 +7,6 @@
 
 namespace Ydb.Sdk.Tests.Ado;
 
-[Collection("YdbConnectionTests")]
-[CollectionDefinition("YdbConnectionTests isolation test", DisableParallelization = true)]
 public sealed class YdbConnectionTests : YdbAdoNetFixture
 {
     private static readonly TemporaryTables<YdbConnectionTests> Tables = new();
@@ -207,15 +205,11 @@ private List<Task> GenerateTasks()
     {
         return Enumerable.Range(0, 100).Select(async i =>
         {
-            await using var connection = new YdbConnection(ConnectionString);
-            await connection.OpenAsync();
-
+            await using var connection = await CreateOpenConnectionAsync();
             var command = connection.CreateCommand();
             command.CommandText = "SELECT " + i;
-
             var scalar = (int)(await command.ExecuteScalarAsync())!;
             Assert.Equal(i, scalar);
-
             Interlocked.Add(ref _counter, scalar);
         }).ToList();
     }

src/Ydb.Sdk/tests/Ado/YdbDataSourceTests.cs

@@ -43,13 +43,15 @@ public void CreateCommand_FromDataSource_ReturnDbCommand()
     {
         for (var i = 0; i < SelectedCount; i++)
         {
-            Assert.Equal(1, _dataSource.CreateCommand("SELECT 1;").ExecuteScalar());
+            using var command = _dataSource.CreateCommand("SELECT 1;");
+            Assert.Equal(1, command.ExecuteScalar());
         }
 
         _dataSource.Dispose();
         for (var i = 0; i < SelectedCount; i++)
         {
-            Assert.Equal(1, _dataSource.CreateCommand("SELECT 1;").ExecuteScalar());
+            using var command = _dataSource.CreateCommand("SELECT 1;");
+            Assert.Equal(1, command.ExecuteScalar());
         }
     }
 

src/Ydb.Sdk/tests/Fixture/YdbAdoNetFixture.cs

@@ -22,8 +22,8 @@ protected override YdbConnection CreateOpenConnection()
 
     protected async Task<YdbConnection> CreateOpenConnectionAsync()
     {
-        var connection = CreateConnection();
-        connection.ConnectionString = ConnectionString;
+        var connection = new YdbConnection(new YdbConnectionStringBuilder(ConnectionString)
+            { LoggerFactory = Utils.GetLoggerFactory() });
         await connection.OpenAsync();
         return connection;
     }