fix issues

Author: KirillKurdyukov

CHANGELOG.md

@@ -1,5 +1,5 @@
-- **Breaking Change**: Ydb.Sdk.Yc.Auth version < 0.1.0 is not compatible with newer versions.
-- Added IAuthClient to fetch auth token.
+- **Breaking Change**: `Ydb.Sdk.Yc.Auth` version <= 0.1.0 is not compatible with newer versions.
+- Added `IAuthClient` to fetch auth token.
 - Added the `TokenManagerCredentialsProvider` class, which streamlines token lifecycle management.
 - **Breaking Change**: Deleted `AnonymousProvider`. Now users don't need to do anything for anonymous authentication.
   Migration guide:

src/Ydb.Sdk/src/Auth/ICredentialsProvider.cs

@@ -7,5 +7,5 @@ public interface ICredentialsProvider
 
 public interface IAuthClient
 {
-    ValueTask<TokenResponse> FetchToken();
+    Task<TokenResponse> FetchToken();
 }

src/Ydb.Sdk/src/Auth/TokenManagerCredentialsProvider.cs

@@ -34,7 +34,7 @@ internal TokenManagerCredentialsProvider(IAuthClient authClient, IClock clock) :
     public async ValueTask<string> GetAuthInfoAsync() =>
         (await _tokenState.Validate(_clock.UtcNow)).TokenResponse.Token;
 
-    private ValueTask<TokenResponse> FetchToken() => _authClient.FetchToken();
+    private Task<TokenResponse> FetchToken() => _authClient.FetchToken();
 
     private ITokenState UpdateState(ITokenState current, ITokenState next)
     {
@@ -130,7 +130,7 @@ public async ValueTask<ITokenState> Validate(DateTime now)
             }
         }
 
-        public void Init() => _fetchTokenTask = _tokenManagerCredentialsProvider.FetchToken().AsTask();
+        public void Init() => _fetchTokenTask = _tokenManagerCredentialsProvider.FetchToken();
     }
 
     private class BackgroundState : ITokenState
@@ -196,7 +196,7 @@ public async ValueTask<ITokenState> Validate(DateTime now)
             }
         }
 
-        public void Init() => _fetchTokenTask = _tokenManagerCredentialsProvider.FetchToken().AsTask();
+        public void Init() => _fetchTokenTask = _tokenManagerCredentialsProvider.FetchToken();
     }
 
     private class ErrorState : ITokenState

src/Ydb.Sdk/src/Driver.cs

@@ -41,7 +41,7 @@ public Driver(DriverConfig config, ILoggerFactory? loggerFactory = null)
 
         CredentialsProvider = Config.User != null
             ? new TokenManagerCredentialsProvider(
-                new AuthClient(config, _grpcChannelFactory, LoggerFactory),
+                new StaticCredentialsAuthClient(config, _grpcChannelFactory, LoggerFactory),
                 LoggerFactory
             )
             : Config.Credentials;

src/Ydb.Sdk/src/Services/Auth/AuthClient.cs renamed to src/Ydb.Sdk/src/Services/Auth/StaticCredentialsAuthClient.cs

@@ -10,24 +10,24 @@
 
 namespace Ydb.Sdk.Services.Auth;
 
-internal class AuthClient : IAuthClient
+internal class StaticCredentialsAuthClient : IAuthClient
 {
     private readonly DriverConfig _config;
     private readonly GrpcChannelFactory _grpcChannelFactory;
     private readonly ILoggerFactory _loggerFactory;
-    private readonly ILogger<AuthClient> _logger;
+    private readonly ILogger<StaticCredentialsAuthClient> _logger;
 
     private readonly RetrySettings _retrySettings = new(5);
 
-    internal AuthClient(DriverConfig config, GrpcChannelFactory grpcChannelFactory, ILoggerFactory loggerFactory)
+    internal StaticCredentialsAuthClient(DriverConfig config, GrpcChannelFactory grpcChannelFactory, ILoggerFactory loggerFactory)
     {
         _config = config;
         _grpcChannelFactory = grpcChannelFactory;
         _loggerFactory = loggerFactory;
-        _logger = loggerFactory.CreateLogger<AuthClient>();
+        _logger = loggerFactory.CreateLogger<StaticCredentialsAuthClient>();
     }
 
-    public async ValueTask<TokenResponse> FetchToken()
+    public async Task<TokenResponse> FetchToken()
     {
         uint attempt = 0;
         while (true)

src/Ydb.Sdk/tests/Auth/TokenManagerCredentialsProviderTests.cs

@@ -43,7 +43,7 @@ public async Task SyncState_To_ActiveState_To_BackgroundState_To_ActiveState()
         _mockAuthClient.SetupSequence(authClient => authClient.FetchToken())
             .ReturnsAsync(new TokenResponse(Token, now.Add(TimeSpan.FromSeconds(3))))
             .ReturnsAsync(new TokenResponse(Token + Token, now.Add(TimeSpan.FromSeconds(4))))
-            .Returns(new ValueTask<TokenResponse>(tcsTokenResponse.Task));
+            .Returns(tcsTokenResponse.Task);
         _mockClock.SetupSequence(clock => clock.UtcNow)
             .Returns(now)
             .Returns(now.Add(TimeSpan.FromSeconds(2)))