fix linters + added primary constructors

Author: KirillKurdyukov

src/EfCore.Ydb.FunctionalTests/TestUtilities/YdbNorthwindTestStoreFactory.cs

@@ -4,7 +4,7 @@ namespace EfCore.Ydb.FunctionalTests.TestUtilities;
 
 public class YdbNorthwindTestStoreFactory : YdbTestStoreFactory
 {
-    public const string DatabaseName = "Northwind";
+    private const string DatabaseName = "Northwind";
 
     public new static YdbNorthwindTestStoreFactory Instance { get; } = new();
 

src/EfCore.Ydb.FunctionalTests/TestUtilities/YdbTestStoreFactory.cs

@@ -8,11 +8,11 @@ public class YdbTestStoreFactory : RelationalTestStoreFactory
 {
     public static YdbTestStoreFactory Instance { get; } = new();
 
-    private string? _scriptPath = null;
-    private string? _additionalSql = null;
-    private string? _connectionStringOptions = null;
+    private readonly string? _scriptPath = null;
+    private readonly string? _additionalSql = null;
+    private readonly string? _connectionStringOptions = null;
     private readonly string? _connectionString;
-    private bool _useConnectionString = false;
+    private readonly bool _useConnectionString = false;
 
     public YdbTestStoreFactory(
         string? connectionString = null,

src/EfCore.Ydb/src/Abstractions/YdbStringAttribute.cs

@@ -3,6 +3,4 @@
 namespace EfCore.Ydb.Abstractions;
 
 [AttributeUsage(AttributeTargets.Property)]
-public class YdbStringAttribute: Attribute
-{
-}
+public class YdbStringAttribute : Attribute;

src/EfCore.Ydb/src/Diagnostics/Internal/YdbCommandInterceptor.cs

@@ -3,7 +3,7 @@
 
 namespace EfCore.Ydb.Diagnostics.Internal;
 
-// TODO: Temporary for debugging
+// Temporary for debugging
 public class YdbCommandInterceptor : DbCommandInterceptor
 {
     public override InterceptionResult<DbDataReader> ReaderExecuting(

src/EfCore.Ydb/src/Infrastructure/EntityFrameworkYdbServicesBuilder.cs

@@ -5,18 +5,15 @@
 
 namespace EfCore.Ydb.Infrastructure;
 
-public class EntityFrameworkYdbServicesBuilder : EntityFrameworkRelationalServicesBuilder
+public class EntityFrameworkYdbServicesBuilder(IServiceCollection serviceCollection)
+    : EntityFrameworkRelationalServicesBuilder(serviceCollection)
 {
     private static readonly IDictionary<Type, ServiceCharacteristics> YdbServices
         = new Dictionary<Type, ServiceCharacteristics>
         {
             // TODO: Add items if required
         };
 
-    public EntityFrameworkYdbServicesBuilder(IServiceCollection serviceCollection) : base(serviceCollection)
-    {
-    }
-
     protected override ServiceCharacteristics GetServiceCharacteristics(Type serviceType)
     {
         var contains = YdbServices.TryGetValue(serviceType, out var characteristics);

src/EfCore.Ydb/src/Infrastructure/YdbDbContextOptionsBuilder.cs

@@ -4,10 +4,5 @@
 
 namespace EfCore.Ydb.Infrastructure;
 
-public class YdbDbContextOptionsBuilder
-    : RelationalDbContextOptionsBuilder<YdbDbContextOptionsBuilder, YdbOptionsExtension>
-{
-    public YdbDbContextOptionsBuilder(DbContextOptionsBuilder optionsBuilder) : base(optionsBuilder)
-    {
-    }
-}
+public class YdbDbContextOptionsBuilder(DbContextOptionsBuilder optionsBuilder)
+    : RelationalDbContextOptionsBuilder<YdbDbContextOptionsBuilder, YdbOptionsExtension>(optionsBuilder);

src/EfCore.Ydb/src/Metadata/Conventions/YdbConventionSetBuilder.cs

@@ -3,16 +3,12 @@
 
 namespace EfCore.Ydb.Metadata.Conventions;
 
-public class YdbConventionSetBuilder
-    : RelationalConventionSetBuilder
+// ReSharper disable once ClassNeverInstantiated.Global
+public class YdbConventionSetBuilder(
+    ProviderConventionSetBuilderDependencies dependencies,
+    RelationalConventionSetBuilderDependencies relationalDependencies
+) : RelationalConventionSetBuilder(dependencies, relationalDependencies)
 {
-    public YdbConventionSetBuilder(
-        ProviderConventionSetBuilderDependencies dependencies,
-        RelationalConventionSetBuilderDependencies relationalDependencies
-    ) : base(dependencies, relationalDependencies)
-    {
-    }
-
     public override ConventionSet CreateConventionSet()
     {
         var coreConventions = base.CreateConventionSet();

src/EfCore.Ydb/src/Metadata/Conventions/YdbStringAttributeConvention.cs

@@ -7,13 +7,9 @@
 
 namespace EfCore.Ydb.Metadata.Conventions;
 
-public class YdbStringAttributeConvention
-    : PropertyAttributeConventionBase<YdbStringAttribute>
+public class YdbStringAttributeConvention(ProviderConventionSetBuilderDependencies dependencies)
+    : PropertyAttributeConventionBase<YdbStringAttribute>(dependencies)
 {
-    public YdbStringAttributeConvention(ProviderConventionSetBuilderDependencies dependencies) : base(dependencies)
-    {
-    }
-
     protected override void ProcessPropertyAdded(
         IConventionPropertyBuilder propertyBuilder,
         YdbStringAttribute attribute,

src/EfCore.Ydb/src/Metadata/Internal/YdbAnnotationNames.cs

@@ -2,7 +2,7 @@ namespace EfCore.Ydb.Metadata.Internal;
 
 public static class YdbAnnotationNames
 {
-    public const string Prefix = "Ydb";
+    private const string Prefix = "Ydb";
 
     public const string Serial = Prefix + "Serial";
 }

src/EfCore.Ydb/src/Metadata/Internal/YdbAnnotationProvider.cs

@@ -5,12 +5,9 @@
 
 namespace EfCore.Ydb.Metadata.Internal;
 
-public class YdbAnnotationProvider : RelationalAnnotationProvider
+public class YdbAnnotationProvider(RelationalAnnotationProviderDependencies dependencies)
+    : RelationalAnnotationProvider(dependencies)
 {
-    public YdbAnnotationProvider(RelationalAnnotationProviderDependencies dependencies) : base(dependencies)
-    {
-    }
-
     public override IEnumerable<IAnnotation> For(IColumn column, bool designTime)
     {
         if (!designTime)