Handle exception on DeleteSession!

If session is not active not invoke DeleteSession!

Author: KirillKurdyukov

src/Ydb.Sdk/CHANGELOG.md

@@ -1,3 +1,5 @@
+- Handle `YdbException` on `DeleteSession`.
+- Do not invoke `DeleteSession` if the session is not active.
 - `YdbException`: Added cancellation token propagation support in `CommitAsync` and `RollbackAsync`.
 - Deleted legacy exceptions: Driver.TransportException, StatusUnsuccessfulException and InitializationFailureException.
 - Fixed bug: Unhandled exception System.Net.Http.HttpIOException has now been converted to YdbException ([grpc-dotnet issue](https://github.com/grpc/grpc-dotnet/issues/2638)).

src/Ydb.Sdk/src/Ado/YdbDataReader.cs

@@ -65,12 +65,12 @@ private YdbDataReader(
 
     internal static async Task<YdbDataReader> CreateYdbDataReader(
         IServerStream<ExecuteQueryResponsePart> resultSetStream,
-        Action<StatusCode> onStatus,
+        Action<StatusCode> onNotSuccessStatusCode,
         YdbTransaction? ydbTransaction = null,
         CancellationToken cancellationToken = default
     )
     {
-        var ydbDataReader = new YdbDataReader(resultSetStream, onStatus, ydbTransaction);
+        var ydbDataReader = new YdbDataReader(resultSetStream, onNotSuccessStatusCode, ydbTransaction);
         await ydbDataReader.Init(cancellationToken);
 
         return ydbDataReader;

src/Ydb.Sdk/src/Pool/SessionPool.cs

@@ -149,10 +149,6 @@ internal async ValueTask ReleaseSession(TSession session)
             {
                 _idleSessions.Enqueue(session);
             }
-            else
-            {
-                _ = DeleteSession(session);
-            }
         }
         finally
         {
@@ -162,11 +158,20 @@ internal async ValueTask ReleaseSession(TSession session)
 
     private void Release() => _semaphore.Release();
 
-    private Task DeleteSession(TSession session) =>
-        session.DeleteSession().ContinueWith(s =>
+    private async Task DeleteSession(TSession session)
+    {
+        try
         {
-            Logger.LogDebug("Session[{id}] removed with status {status}", session.SessionId, s.Result);
-        });
+            if (session.IsActive)
+            {
+                await session.DeleteSession();    
+            }
+        }
+        catch (YdbException e)
+        {
+            Logger.LogError(e, "Failed to delete session");
+        }
+    }
 
     public async ValueTask DisposeAsync()
     {
@@ -242,7 +247,7 @@ internal TS MakeGrpcRequestSettings<TS>(TS settings) where TS : GrpcRequestSetti
         return settings;
     }
 
-    internal abstract Task<Status> DeleteSession();
+    internal abstract Task DeleteSession();
 }
 
 internal record SessionPoolConfig(

src/Ydb.Sdk/src/Services/Query/SessionPool.cs

@@ -224,7 +224,7 @@ internal async Task<DescribeTableResult> DescribeTable(string path, DescribeTabl
         return response.Operation.Result.Unpack<DescribeTableResult>();
     }
 
-    internal override async Task<Status> DeleteSession()
+    internal override async Task DeleteSession()
     {
         IsActive = false;
 
@@ -237,6 +237,9 @@ internal override async Task<Status> DeleteSession()
             settings
         );
 
-        return Status.FromProto(deleteSessionResponse.Status, deleteSessionResponse.Issues);
+        if (deleteSessionResponse.Status.IsNotSuccess())
+        {
+            throw YdbException.FromServer(deleteSessionResponse.Status, deleteSessionResponse.Issues);
+        }
     }
 }