Skip to content

Commit fc8072c

Browse files
fix test
1 parent d1b1793 commit fc8072c

File tree

3 files changed

+13
-18
lines changed

3 files changed

+13
-18
lines changed

.github/workflows/slo-topic.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,5 +31,5 @@ jobs:
3131
run: |
3232
cd slo/src/TopicService
3333
dotnet run run grpc://localhost:2135 /Root/testdb \
34-
--write-rps 50 \
34+
--write-rps 100 \
3535
--time 600

slo/src/TopicService/SloTopicContext.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ public async Task Run(RunConfig config)
135135
PartitionIds = { partitionId }
136136
}
137137
},
138-
MemoryUsageMaxBytes = 8 * 1024 * 1024,
138+
MemoryUsageMaxBytes = 8 * 1024 * 1024
139139
}.Build();
140140

141141
Logger.LogInformation("Started Reader[PartitionId={PartitionId}]", partitionId);
@@ -193,15 +193,15 @@ int partitionId
193193
{
194194
goto ContinueForeach;
195195
}
196-
196+
197197
if (localStore.TryGetValue(message.PartitionId, out var expectedQueue))
198198
{
199199
if (expectedQueue.TryPeek(out var commitedMessage))
200200
{
201201
if (commitedMessage == message.Data)
202202
{
203203
expectedQueue.TryDequeue(out _);
204-
204+
205205
goto ContinueForeach;
206206
}
207207
}

src/Ydb.Sdk/tests/Topic/ReaderUnitTests.cs

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -684,7 +684,9 @@ public async Task
684684
IBidirectionalStream<StreamReadMessage.Types.FromClient, StreamReadMessage.Types.FromServer>.Current
685685
IBidirectionalStream<StreamReadMessage.Types.FromClient, StreamReadMessage.Types.FromServer>.MoveNextAsync() [Maybe]
686686
*/
687-
// [Fact]
687+
#pragma warning disable xUnit1004
688+
[Fact(Skip = "FLAP TEST")]
689+
#pragma warning restore xUnit1004
688690
public async Task
689691
RunProcessingTopic_WhenReadRequestAfterInitializeThrowTransportException_ShouldRetryInitializeAndReadThenCommitMessage()
690692
{
@@ -1242,8 +1244,8 @@ public async Task
12421244
[Theory]
12431245
[InlineData(true)]
12441246
[InlineData(false)]
1245-
public async Task RunProcessingTopic_WhenStopPartitionSessionRequestBeforeCommit_ThrowReaderExceptionOnCommit(
1246-
bool graceful)
1247+
public async Task
1248+
RunProcessingTopic_WhenStopPartitionSessionRequestBeforeCommit_ThrowReaderExceptionOnCommit(bool graceful)
12471249
{
12481250
var tcsMoveNext = new TaskCompletionSource<bool>();
12491251
var stopPartitionSessionRequest = new TaskCompletionSource<bool>();
@@ -1312,19 +1314,12 @@ public async Task RunProcessingTopic_WhenStopPartitionSessionRequestBeforeCommit
13121314
}.Build();
13131315

13141316
var firstMessage = await reader.ReadAsync();
1315-
Assert.Equal(100, firstMessage.Data);
1316-
if (graceful)
1317-
{
1318-
await firstMessage.CommitAsync();
1319-
}
1320-
else
1321-
{
1322-
Assert.Equal("PartitionSession[1] was closed by server.",
1323-
(await Assert.ThrowsAsync<ReaderException>(() => firstMessage.CommitAsync())).Message);
1324-
}
1325-
13261317
var secondMessage = await reader.ReadAsync();
1318+
1319+
Assert.Equal(100, firstMessage.Data);
1320+
await firstMessage.CommitAsync();
13271321
Assert.Equal(100, secondMessage.Data);
1322+
13281323
Assert.Equal("PartitionSession[1] was closed by server.",
13291324
(await Assert.ThrowsAsync<ReaderException>(() => secondMessage.CommitAsync())).Message);
13301325

0 commit comments

Comments
 (0)