diff --git a/.github/workflows/slo-topic.yaml b/.github/workflows/slo-topic.yaml index 919bfd30..2a21051a 100644 --- a/.github/workflows/slo-topic.yaml +++ b/.github/workflows/slo-topic.yaml @@ -28,7 +28,6 @@ jobs: cd slo/src/TopicService dotnet run create "Host=localhost;Port=2135;Database=/Root/testdb" - name: Run SLO Tests - continue-on-error: true run: | cd slo/src/TopicService dotnet run run "Host=localhost;Port=2135;Database=/Root/testdb" \ diff --git a/src/Ydb.Sdk/CHANGELOG.md b/src/Ydb.Sdk/CHANGELOG.md index 98b6b1e1..87fff2a7 100644 --- a/src/Ydb.Sdk/CHANGELOG.md +++ b/src/Ydb.Sdk/CHANGELOG.md @@ -1,13 +1,17 @@ +- Fixed bug: Unhandled exception. + System.Net.Http.HttpIOException ([#452](https://github.com/ydb-platform/ydb-dotnet-sdk/issues/451)). - dev: LogLevel `Warning` -> `Debug` on AttachStream has been cancelled. ## v0.18.0 -- Disable Discovery mode: skip discovery step and client balancing and use connection to start endpoint ([#420](https://github.com/ydb-platform/ydb-dotnet-sdk/issues/420)). +- Disable Discovery mode: skip discovery step and client balancing and use connection to start + endpoint ([#420](https://github.com/ydb-platform/ydb-dotnet-sdk/issues/420)). ## v0.17.0 - Shutdown channels which are removed from the EndpointPool after discovery calls. -- Fixed bug: Received message exceeds the maximum configured message size ([#421](https://github.com/ydb-platform/ydb-dotnet-sdk/issues/421)). +- Fixed bug: Received message exceeds the maximum configured message + size ([#421](https://github.com/ydb-platform/ydb-dotnet-sdk/issues/421)). - Added `MaxSendMessageSize` \ `MaxReceiveMessageSize` grpc message size settings. - Added `EnableMultipleHttp2Connections` setting to grpc channel. - `Connection.State` is set to `Broken` when the session is deactivated. diff --git a/src/Ydb.Sdk/src/Services/Topic/Reader/Reader.cs b/src/Ydb.Sdk/src/Services/Topic/Reader/Reader.cs index 1513f387..9df59891 100644 --- a/src/Ydb.Sdk/src/Services/Topic/Reader/Reader.cs +++ b/src/Ydb.Sdk/src/Services/Topic/Reader/Reader.cs @@ -198,9 +198,9 @@ await stream.AuthToken(), _deserializer ); } - catch (Driver.TransportException e) + catch (Exception e) { - _logger.LogError(e, "Transport error on executing ReaderSession"); + _logger.LogError(e, "Error on executing ReaderSession"); _ = Task.Run(Initialize, _disposeCts.Token); } @@ -338,9 +338,9 @@ private async Task RunProcessingStreamResponse() Logger.LogInformation("ReaderSession[{SessionId}]: ResponseStream is closed", SessionId); } - catch (Driver.TransportException e) + catch (Exception e) { - Logger.LogError(e, "ReaderSession[{SessionId}] have transport error on processing server messages", + Logger.LogError(e, "ReaderSession[{SessionId}] have error on processing server messages", SessionId); } finally @@ -360,9 +360,9 @@ private async Task RunProcessingStreamRequest() await SendMessage(messageFromClient); } } - catch (Driver.TransportException e) + catch (Exception e) { - Logger.LogError(e, "ReaderSession[{SessionId}] have transport error on Write", SessionId); + Logger.LogError(e, "ReaderSession[{SessionId}] have error on Write", SessionId); ReconnectSession(); diff --git a/src/Ydb.Sdk/src/Services/Topic/Writer/Writer.cs b/src/Ydb.Sdk/src/Services/Topic/Writer/Writer.cs index 62b7cd43..a05a4ca0 100644 --- a/src/Ydb.Sdk/src/Services/Topic/Writer/Writer.cs +++ b/src/Ydb.Sdk/src/Services/Topic/Writer/Writer.cs @@ -314,16 +314,16 @@ await stream.AuthToken(), _sendInFlightMessagesSemaphoreSlim.Release(); } } - catch (Driver.TransportException e) - { - _logger.LogError(e, "Transport error on creating WriterSession"); - - _ = Task.Run(Initialize); - } catch (OperationCanceledException) { _logger.LogInformation("Initialize writer is canceled because it has been disposed"); } + catch (Exception e) + { + _logger.LogError(e, "Error on creating WriterSession"); + + _ = Task.Run(Initialize); + } } public async ValueTask DisposeAsync() @@ -493,9 +493,9 @@ public async Task Write(ConcurrentQueue toSendBuffer) Volatile.Write(ref _seqNum, currentSeqNum); await SendMessage(new MessageFromClient { WriteRequest = writeMessage }); } - catch (Driver.TransportException e) + catch (Exception e) { - Logger.LogError(e, "WriterSession[{SessionId}] have transport error on Write, last SeqNo={SeqNo}", + Logger.LogError(e, "WriterSession[{SessionId}] have error on Write, last SeqNo={SeqNo}", SessionId, Volatile.Read(ref _seqNum)); ReconnectSession(); @@ -564,7 +564,7 @@ Completing task on exception... Logger.LogInformation("WriterSession[{SessionId}]: ResponseStream is closed", SessionId); } - catch (Driver.TransportException e) + catch (Exception e) { Logger.LogError(e, "WriterSession[{SessionId}] have error on processing writeAck", SessionId); }