feat(ACL): link to new Access section

Author: Raubzeug

src/containers/Tenant/Acl/Acl.scss

@@ -1,208 +1,32 @@
-import React from 'react';
+import {Button, Flex, Icon, Text} from '@gravity-ui/uikit';
 
-import {DefinitionList} from '@gravity-ui/components';
-import type {DefinitionListItem} from '@gravity-ui/components';
-import {SquareCheck} from '@gravity-ui/icons';
-import {Icon} from '@gravity-ui/uikit';
-
-import {ResponseError} from '../../../components/Errors/ResponseError';
-import {Loader} from '../../../components/Loader';
-import {schemaAclApi} from '../../../store/reducers/schemaAcl/schemaAcl';
-import type {TACE} from '../../../types/api/acl';
-import {valueIsDefined} from '../../../utils';
-import {cn} from '../../../utils/cn';
+import {
+    TENANT_DIAGNOSTICS_TABS_IDS,
+    TENANT_PAGES_IDS,
+} from '../../../store/reducers/tenant/constants';
+import {setDiagnosticsTab, setTenantPage} from '../../../store/reducers/tenant/tenant';
+import {useTypedDispatch} from '../../../utils/hooks';
 
 import i18n from './i18n';
 
-import './Acl.scss';
-
-const b = cn('ydb-acl');
-
-const prepareLogin = (value: string | undefined) => {
-    if (value && value.endsWith('@staff') && !value.startsWith('svc_')) {
-        const login = value.split('@')[0];
-        return login;
-    }
-
-    return value;
-};
-
-const aclParams = ['access', 'type', 'inheritance'] as const;
-
-type AclParameter = (typeof aclParams)[number];
-
-const aclParamToName: Record<AclParameter, string> = {
-    access: 'Access',
-    type: 'Access type',
-    inheritance: 'Inheritance type',
-};
-
-const defaultInheritanceType = ['Object', 'Container'];
-const defaultAccessType = 'Allow';
-
-const defaultInheritanceTypeSet = new Set(defaultInheritanceType);
-
-function normalizeAcl(acl: TACE[]) {
-    return acl.map((ace) => {
-        const {AccessRules = [], AccessRights = [], AccessType, InheritanceType, Subject} = ace;
-        const access = AccessRules.concat(AccessRights);
-        //"Allow" is default access type. We want to show it only if it isn't default
-        const type = AccessType === defaultAccessType ? undefined : AccessType;
-        let inheritance;
-        // ['Object', 'Container'] - is default inheritance type. We want to show it only if it isn't default
-        if (
-            InheritanceType?.length !== defaultInheritanceTypeSet.size ||
-            InheritanceType.some((t) => !defaultInheritanceTypeSet.has(t))
-        ) {
-            inheritance = InheritanceType;
-        }
-        return {
-            access: access.length ? access : undefined,
-            type,
-            inheritance,
-            Subject,
-        };
-    });
-}
+import ArrowRightFromSquareIcon from '@gravity-ui/icons/svgs/arrow-right-from-square.svg';
 
-interface DefinitionValueProps {
-    value: string | string[];
-}
+export const Acl = () => {
+    const dispatch = useTypedDispatch();
 
-function DefinitionValue({value}: DefinitionValueProps) {
-    const normalizedValue = typeof value === 'string' ? [value] : value;
     return (
-        <div className={b('definition-content')}>
-            {normalizedValue.map((el) => (
-                <span key={el}>{el}</span>
-            ))}
-        </div>
-    );
-}
-
-function getAclListItems(acl?: TACE[]): DefinitionListItem[] {
-    if (!acl || !acl.length) {
-        return [];
-    }
-
-    const normalizedAcl = normalizeAcl(acl);
-
-    return normalizedAcl.map(({Subject, ...data}) => {
-        const definedDataEntries = Object.entries(data).filter(([_key, value]) =>
-            Boolean(value),
-        ) as [AclParameter, string | string[]][];
-
-        if (definedDataEntries.length === 1 && definedDataEntries[0][0] === 'access') {
-            return {
-                name: Subject,
-                content: <DefinitionValue value={definedDataEntries[0][1]} />,
-                multilineName: true,
-            };
-        }
-        return {
-            label: <span className={b('group-label')}>{Subject}</span>,
-            items: aclParams
-                .map((key) => {
-                    const value = data[key];
-                    if (value) {
-                        return {
-                            name: aclParamToName[key],
-                            content: <DefinitionValue value={value} />,
-                            multilineName: true,
-                        };
-                    }
-                    return undefined;
-                })
-                .filter(valueIsDefined),
-        };
-    });
-}
-
-function getOwnerItem(owner?: string): DefinitionListItem[] {
-    const preparedOwner = prepareLogin(owner);
-    if (!preparedOwner) {
-        return [];
-    }
-    return [
-        {
-            name: preparedOwner,
-            content: i18n('title_owner'),
-            multilineName: true,
-        },
-    ];
-}
-
-function getInterruptInheritanceItem(flag?: boolean): DefinitionListItem[] {
-    if (!flag) {
-        return [];
-    }
-    return [
-        {
-            name: i18n('title_interupt-inheritance'),
-            content: <Icon data={SquareCheck} size={20} />,
-            multilineName: true,
-        },
-    ];
-}
-
-export const Acl = ({path, database}: {path: string; database: string}) => {
-    const {currentData, isFetching, error} = schemaAclApi.useGetSchemaAclQuery({path, database});
-
-    const loading = isFetching && !currentData;
-
-    const {acl, effectiveAcl, owner, interruptInheritance} = currentData || {};
-
-    const aclListItems = getAclListItems(acl);
-    const effectiveAclListItems = getAclListItems(effectiveAcl);
-
-    const ownerItem = getOwnerItem(owner);
-
-    const interruptInheritanceItem = getInterruptInheritanceItem(interruptInheritance);
-
-    if (loading) {
-        return <Loader />;
-    }
-
-    if (error) {
-        return <ResponseError error={error} />;
-    }
-
-    if (!acl && !owner && !effectiveAcl) {
-        return <React.Fragment>{i18n('description_empty')}</React.Fragment>;
-    }
-
-    const accessRightsItems = ownerItem.concat(aclListItems);
-
-    return (
-        <div className={b()}>
-            <AclDefinitionList items={interruptInheritanceItem} />
-            <AclDefinitionList items={accessRightsItems} title={i18n('title_rights')} />
-            <AclDefinitionList
-                items={effectiveAclListItems}
-                title={i18n('title_effective-rights')}
-            />
-        </div>
+        <Flex gap={2} alignItems="center">
+            <Text variant="body-2">{i18n('description_section-moved')}</Text>
+            <Button
+                title={i18n('action-open-in-diagnostics')}
+                onClick={() => {
+                    dispatch(setTenantPage(TENANT_PAGES_IDS.diagnostics));
+                    dispatch(setDiagnosticsTab(TENANT_DIAGNOSTICS_TABS_IDS.access));
+                }}
+                size="s"
+            >
+                <Icon data={ArrowRightFromSquareIcon} size={14} />
+            </Button>
+        </Flex>
     );
 };
-
-interface AclDefinitionListProps {
-    items: DefinitionListItem[];
-    title?: string;
-}
-
-function AclDefinitionList({items, title}: AclDefinitionListProps) {
-    if (!items.length) {
-        return null;
-    }
-    return (
-        <React.Fragment>
-            {title && <div className={b('list-title')}>{title}</div>}
-            <DefinitionList
-                items={items}
-                nameMaxWidth={200}
-                className={b('result', {'no-title': !title})}
-                responsive
-            />
-        </React.Fragment>
-    );
-}

src/containers/Tenant/Acl/Acl.tsx

@@ -1,7 +1,4 @@
 {
-  "title_rights": "Access Rights",
-  "title_effective-rights": "Effective Access Rights",
-  "title_owner": "Owner",
-  "title_interupt-inheritance": "Interrupt inheritance",
-  "description_empty": "No Acl data"
+  "description_section-moved": "Section was moved to Diagnostics",
+  "action-open-in-diagnostics": "Open in Diagnostics"
 }